Skip to content

いくつかの例外を回避する #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

いくつかの例外を回避する #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17ca75a
Do not set 'title' mandatory.
oikumene Dec 14, 2022
a9ab06c
Remove log expressions for debug.
oikumene Dec 14, 2022
824a9e5
Remove logging.
oikumene Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions jpndlpy/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,17 @@ def search_text(
items : json
複数の図書情報
"""

data, errs = self.validation_serializer(kwargs)
if not errs:
if not errs and len(data) > 1:
self.response = self.get(data)
return self.response
else:
erros_mes = ''.join(
[key + ' : ' + errs[key][0] + '\n' for key in errs]
)
if errs:
erros_mes = ''.join(
[key + ' : ' + errs[key][0] + '\n' for key in errs]
)
else:
erros_mes = 'Missing data.'
raise Exception(erros_mes)

def validation_serializer(self, kwargs)->tuple:
Expand Down
2 changes: 2 additions & 0 deletions jpndlpy/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ def extract_items(self, items):
'''
item情報を抽出する
'''
if type(items) is not list:
items = [items]
for item in items:
""" Entity Object """
item_object = ItemEntity()
Expand Down
2 changes: 1 addition & 1 deletion jpndlpy/validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
class SearchTextSchema(Schema):
dpid = fields.String()
dpgroupid = fields.String()
title = fields.String(required=True)
title = fields.String()
creator = fields.String()
digitized_publisher = fields.String()
ndc = fields.String()
Expand Down