Merge rust-bitcoin#4720: Add Arbitrary impl for BlockHash, TxMerkleNode, and Wtxid

8cde2ca Add Arbitrary impl for BlockHash, TxMerkleNode, and Wtxid (Shing Him Ng)

Pull request description:

  


ACKs for top commit:
  apoelstra:
    ACK 8cde2ca; successfully ran local tests; sure


Tree-SHA512: 3631dc8fa11b1c3a45378aaa3c652f33cf34d7a4383c6154b6b87c0ae71fcd89bb748b8901bf4455491f6a7403114f3e9d9052bb0c4bf67bf77fa673bce5613d

Author: apoelstra

primitives/src/block.rs

@@ -354,6 +354,13 @@ impl<'a> Arbitrary<'a> for Block {
     }
 }
 
+#[cfg(feature = "arbitrary")]
+impl<'a> Arbitrary<'a> for BlockHash {
+    fn arbitrary(u: &mut Unstructured<'a>) -> arbitrary::Result<Self> {
+        Ok(BlockHash::from_byte_array(u.arbitrary()?))
+    }
+}
+
 #[cfg(feature = "arbitrary")]
 impl<'a> Arbitrary<'a> for Header {
     fn arbitrary(u: &mut Unstructured<'a>) -> arbitrary::Result<Self> {

primitives/src/merkle_tree.rs

@@ -2,6 +2,8 @@
 
 //! Bitcoin Merkle tree functions.
 
+#[cfg(feature = "arbitrary")]
+use arbitrary::{Arbitrary, Unstructured};
 use hashes::sha256d;
 
 hashes::hash_newtype! {
@@ -17,3 +19,10 @@ hashes::impl_hex_for_newtype!(TxMerkleNode, WitnessMerkleNode);
 hashes::impl_debug_only_for_newtype!(TxMerkleNode, WitnessMerkleNode);
 #[cfg(feature = "serde")]
 hashes::impl_serde_for_newtype!(TxMerkleNode, WitnessMerkleNode);
+
+#[cfg(feature = "arbitrary")]
+impl<'a> Arbitrary<'a> for TxMerkleNode {
+    fn arbitrary(u: &mut Unstructured<'a>) -> arbitrary::Result<Self> {
+        Ok(TxMerkleNode::from_byte_array(u.arbitrary()?))
+    }
+}

primitives/src/transaction.rs

@@ -652,6 +652,13 @@ impl<'a> Arbitrary<'a> for Txid {
     }
 }
 
+#[cfg(feature = "arbitrary")]
+impl<'a> Arbitrary<'a> for Wtxid {
+    fn arbitrary(u: &mut Unstructured<'a>) -> arbitrary::Result<Self> {
+        Ok(Wtxid::from_byte_array(u.arbitrary()?))
+    }
+}
+
 #[cfg(feature = "alloc")]
 #[cfg(test)]
 mod tests {