Skip to content

Commit ae1c0ed

Browse files
committed
script: Remove public re-exports
By convention we do not re-export things from modules where they are used. Also the `borrowed` and `owned` modules are private so these public re-exports make no sense. FTR users can do both of these already - `use bitcoin::script::{Script, ScriptBuf};` - `use bitcoin::{Script, ScriptBuf};`
1 parent 2bb9bb6 commit ae1c0ed

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

bitcoin/src/blockdata/script/borrowed.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use secp256k1::{Secp256k1, Verification};
1010
use super::witness_version::WitnessVersion;
1111
use super::{
1212
Builder, Instruction, InstructionIndices, Instructions, PushBytes, RedeemScriptSizeError,
13-
ScriptHash, WScriptHash, WitnessScriptSizeError,
13+
Script, ScriptHash, WScriptHash, WitnessScriptSizeError,
1414
};
1515
use crate::consensus::{self, Encodable};
1616
use crate::key::{PublicKey, UntweakedPublicKey, WPubkeyHash};
@@ -22,10 +22,6 @@ use crate::script::{self, ScriptBufExt as _};
2222
use crate::taproot::{LeafVersion, TapLeafHash, TapNodeHash};
2323
use crate::{Amount, FeeRate, ScriptBuf};
2424

25-
#[rustfmt::skip] // Keep public re-exports separate.
26-
#[doc(inline)]
27-
pub use primitives::script::Script;
28-
2925
crate::internal_macros::define_extension_trait! {
3026
/// Extension functionality for the [`Script`] type.
3127
pub trait ScriptExt impl for Script {

bitcoin/src/blockdata/script/owned.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use hex::FromHex as _;
77
use internals::ToU64 as _;
88
use secp256k1::{Secp256k1, Verification};
99

10-
use super::{opcode_to_verify, Builder, Instruction, PushBytes, ScriptExtPriv as _};
10+
use super::{opcode_to_verify, Builder, Instruction, PushBytes, ScriptBuf, ScriptExtPriv as _};
1111
use crate::consensus;
1212
use crate::key::{
1313
PubkeyHash, PublicKey, TapTweak, TweakedPublicKey, UntweakedPublicKey, WPubkeyHash,
@@ -20,10 +20,6 @@ use crate::script::witness_version::WitnessVersion;
2020
use crate::script::{self, ScriptHash, WScriptHash};
2121
use crate::taproot::TapNodeHash;
2222

23-
#[rustfmt::skip] // Keep public re-exports separate.
24-
#[doc(inline)]
25-
pub use primitives::script::ScriptBuf;
26-
2723
crate::internal_macros::define_extension_trait! {
2824
/// Extension functionality for the [`ScriptBuf`] type.
2925
pub trait ScriptBufExt impl for ScriptBuf {

0 commit comments

Comments
 (0)