Merge rust-bitcoin#5138: fuzz: fix shell script bugs and remove dead code

b0b7c07 fuzz: fix shell script bugs and remove dead code (Klaklax)

Pull request description:

  Fixes two shell script issues in fuzz utilities:
  
  1. Remove unused function `targetFileToHFuzzInputArg()` with undefined variable `$FILE`
  2. Fix syntax error: remove extra quote in `HFUZZ_INPUT_ARGS` assignment
  
  Added in 2023 as a stub but never used due to the $FILE bug. Logic was implemented inline instead, leaving this as forgotten dead code.


ACKs for top commit:
  tcharding:
    ACK b0b7c07
  apoelstra:
    ACK b0b7c07; successfully ran local tests; thanks for finding this!


Tree-SHA512: ebbea05b6a6a8236b8bca396748b4cf668f6a4b3677db7091d28a1d3185a106cb8995ae50e2ea6abc8799b57cd1ebc33403a3ce48cef640c0dc176836b26a25b

Author: apoelstra

fuzz/fuzz-util.sh

@@ -20,14 +20,6 @@ targetFileToName() {
     | sed 's/^_//g'
 }
 
-targetFileToHFuzzInputArg() {
-  baseName=$(basename "$1")
-  dirName="${baseName%.*}"
-  if [ -d "hfuzz_input/$dirName" ]; then
-    echo "HFUZZ_INPUT_ARGS=\"-f hfuzz_input/$FILE/input\""
-  fi
-}
-
 listTargetNames() {
   for target in $(listTargetFiles); do
     targetFileToName "$target"

fuzz/fuzz.sh

@@ -25,7 +25,7 @@ for targetFile in $targetFiles; do
   targetName=$(targetFileToName "$targetFile")
   echo "Fuzzing target $targetName ($targetFile)"
   if [ -d "hfuzz_input/$targetName" ]; then
-    HFUZZ_INPUT_ARGS="-f hfuzz_input/$targetName/input\""
+    HFUZZ_INPUT_ARGS="-f hfuzz_input/$targetName/input"
   else
     HFUZZ_INPUT_ARGS=""
   fi