Parse response only when it's not empty

Previously, _Shipcloud::Shipment.delete(ID)_ caused TypeError converting nil to String

Author: oleksandriuzikov

CHANGELOG.md

@@ -12,6 +12,7 @@
 ### Changed
 
 ### Fixed
+- Parse response only when it is not empty
 
 ## [0.7.0] - 2016-01-21
 ### Added

lib/shipcloud/request/base.rb

@@ -12,7 +12,7 @@ def perform
         connection.setup_https
         response = connection.request
         validate_response(response)
-        JSON.parse(response.body)
+        JSON.parse(response.body) unless response.body.nil?
       rescue JSON::ParserError
         raise ShipcloudError.new(response)
       end

spec/shipcloud/shipment_spec.rb

@@ -98,6 +98,13 @@
         and_return(true)
       Shipcloud::Shipment.delete("123")
     end
+
+    it "doesn't raise an error" do
+      stub_request(:delete, "https://your-api-key:@api.shipcloud.io/v1/shipments/123").
+        to_return(status: 204, body: "")
+      expect { Shipcloud::Shipment.delete("123", api_key: "your-api-key") }.
+        to_not raise_error
+    end
   end
 
   describe ".all" do