Updates ruby and rubocop setup (#40)

* Adds rubocop and rubocop-performance to the development dependencies
* Adds binstub for rubocop
* Updates .rubocop.yml
* Remove ruby versions < 2.3 from supported ruby versions
* Sets Target ruby version to 2.6.3

Author: sfroehler

.codeclimate.yml

@@ -12,6 +12,7 @@ engines:
     enabled: true
   rubocop:
     enabled: true
+    channel: rubocop-0-71
 ratings:
   paths:
   - "**.inc"

.rubocop.yml

@@ -1,7 +1,10 @@
+require: rubocop-performance
+
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.6
   Exclude:
     - vendor/**/*
+    - bin/*
 
 Naming/AccessorMethodName:
   Description: Check the naming of accessor methods for get_/set_.
@@ -39,6 +42,11 @@ Naming/PredicateName:
   Exclude:
     - spec/**/*
 
+Naming/RescuedExceptionsVariableName:
+  Description: 'Use consistent rescued exceptions variables naming.'
+  Enabled: true
+  PreferredName: error
+
 Style/Alias:
   Description: 'Use alias_method instead of alias.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#alias-method'
@@ -133,7 +141,7 @@ Style/EvenOdd:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods'
   Enabled: false
 
-Style/FlipFlop:
+Lint/FlipFlop:
   Description: 'Checks for flip flops'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-flip-flops'
   Enabled: false
@@ -266,6 +274,13 @@ Style/RegexpLiteral:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-r'
   Enabled: false
 
+Style/Sample:
+  Description: >-
+                  Use `sample` instead of `shuffle.first`,
+                  `shuffle.last`, and `shuffle[Fixnum]`.
+  Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
+  Enabled: false
+
 Style/SelfAssignment:
   Description: >-
                  Checks for places where self-assignment shorthand should have
@@ -626,13 +641,6 @@ Performance/ReverseEach:
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerablereverseeach-vs-enumerablereverse_each-code'
   Enabled: false
 
-Performance/Sample:
-  Description: >-
-                  Use `sample` instead of `shuffle.first`,
-                  `shuffle.last`, and `shuffle[Fixnum]`.
-  Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
-  Enabled: false
-
 Performance/Size:
   Description: >-
                   Use `size` instead of `count` for counting

.ruby-version

@@ -1 +1 @@
-2.5.3
+2.6.3

.travis.yml

@@ -2,7 +2,6 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
-  - 2.2
   - 2.3
   - 2.4
   - 2.5

CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Deprecated
 
 ### Removed
+- Removed support for ruby < 2.3. Target ruby version is 2.6
 
 ### Fixed
 

bin/rubocop

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rubocop", "rubocop")

lib/shipcloud.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "net/http"
 require "net/https"
 require "json"
@@ -10,10 +11,11 @@ module Shipcloud
 
   API_HEADERS = {
     "Content-Type" => "application/json",
-    "User-Agent" => "shipcloud-ruby v#{Shipcloud::VERSION}, API #{Shipcloud::API_VERSION}, #{RUBY_VERSION}, #{RUBY_PLATFORM}, #{RUBY_PATCHLEVEL}"
-  }
+    "User-Agent" => "shipcloud-ruby v#{Shipcloud::VERSION}, API #{Shipcloud::API_VERSION}, " \
+      "#{RUBY_VERSION}, #{RUBY_PLATFORM}, #{RUBY_PATCHLEVEL}",
+  }.freeze
 
-  DEFAULT_AFFILIATE_ID = "integration.shipcloud-ruby-gem.v#{Shipcloud::VERSION}".freeze
+  DEFAULT_AFFILIATE_ID = "integration.shipcloud-ruby-gem.v#{Shipcloud::VERSION}"
 
   autoload :Base,           "shipcloud/base"
   autoload :Shipment,       "shipcloud/shipment"
@@ -39,12 +41,14 @@ module Request
   end
 
   class << self
-    attr_accessor :configuration
+    attr_writer :configuration
   end
 
+  # rubocop:disable Naming/MemoizedInstanceVariableName
   def self.configuration
     @configuration ||= Configuration.new
   end
+  # rubocop:enable Naming/MemoizedInstanceVariableName
 
   def self.configure
     yield(configuration)
@@ -61,7 +65,7 @@ class Configuration
 
     def initialize
       @api_key = nil
-      @api_base = 'api.shipcloud.io'
+      @api_base = "api.shipcloud.io"
       @use_ssl = true
       @debug = false
     end

lib/shipcloud/request/base.rb

@@ -9,6 +9,7 @@ def initialize(info)
 
       def perform
         raise AuthenticationError unless @info.api_key
+
         connection.setup_https
         response = connection.request
         validate_response(response)
@@ -26,9 +27,11 @@ def validate_response(response)
         end
       end
 
+      # rubocop:disable Naming/MemoizedInstanceVariableName
       def connection
         @connection ||= Connection.new(info)
       end
+      # rubocop:enable Naming/MemoizedInstanceVariableName
     end
   end
 end

lib/shipcloud/shipcloud_error.rb

@@ -39,6 +39,7 @@ def self.error_class_for(response_code)
 
     def parse_errors
       return [] unless response_body
+
       data = JSON.parse(response_body)
       if data.is_a?(Hash) && data["errors"]
         data["errors"]
@@ -51,6 +52,7 @@ def parse_errors
 
     def response_body
       return unless @response
+
       @response.body
     end
   end

shipcloud.gemspec

@@ -1,5 +1,5 @@
 # coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "shipcloud/version"
 
@@ -19,12 +19,14 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.0"
+  spec.required_ruby_version = ">= 2.3"
 
   spec.add_runtime_dependency "json", ">= 1.8.0"
+  spec.add_development_dependency "pry", "~> 0.10"
   spec.add_development_dependency "rake", "~> 12.0"
   spec.add_development_dependency "rspec", "~> 3.6"
-  spec.add_development_dependency "webmock", "~> 3.0"
-  spec.add_development_dependency "pry", "~> 0.10"
+  spec.add_development_dependency "rubocop", "~> 0.71.0"
+  spec.add_development_dependency "rubocop-performance"
   spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "webmock", "~> 3.0"
 end