Check invalid cli options combination (#131)

Author: janedbal

src/Initializer.php

@@ -234,17 +234,21 @@ public function initCliOptions(string $cwd, array $argv): CliOptions
      */
     public function initFormatter(CliOptions $options): ResultFormatter
     {
-        switch ($options->format) {
-            case 'junit':
-                return new JunitFormatter($this->cwd, $this->stdOutPrinter);
+        $format = $options->format ?? 'console';
 
-            case 'console':
-            case null:
-                return new ConsoleFormatter($this->cwd, $this->stdOutPrinter);
+        if ($format === 'junit') {
+            if ($options->dumpUsages !== null) {
+                throw new InvalidConfigException("Cannot use 'junit' format with '--dump-usages' option.");
+            }
+
+            return new JunitFormatter($this->cwd, $this->stdOutPrinter);
+        }
 
-            default:
-                throw new InvalidConfigException("Invalid format option provided, allowed are 'console' or 'junit'.");
+        if ($format === 'console') {
+            return new ConsoleFormatter($this->cwd, $this->stdOutPrinter);
         }
+
+        throw new InvalidConfigException("Invalid format option provided, allowed are 'console' or 'junit'.");
     }
 
 }

tests/BinTest.php

@@ -19,8 +19,10 @@ public function test(): void
         $noComposerJsonError = 'File composer.json not found';
         $noPackagesError = 'No packages found';
         $parseError = 'Failure while parsing';
+        $junitDumpError = "Cannot use 'junit' format with '--dump-usages' option";
 
         $okOutput = 'No composer issues found';
+        $dumpingOutput = 'Dumping sample usages of';
         $helpOutput = 'Usage:';
 
         $usingConfig = 'Using config';
@@ -38,7 +40,9 @@ public function test(): void
         $this->runCommand('php ../bin/composer-dependency-analyser --composer-json=composer.json', $testsDir, 255, null, $noComposerJsonError);
         $this->runCommand('php ../bin/composer-dependency-analyser --composer-json=../composer.json --config=../composer-dependency-analyser.php', $testsDir, 0, $okOutput, $usingConfig);
         $this->runCommand('php bin/composer-dependency-analyser --composer-json=composer.json --format=console', $rootDir, 0, $okOutput, $usingConfig);
+        $this->runCommand('php bin/composer-dependency-analyser --composer-json=composer.json --format=console --dump-usages=symfony/*', $rootDir, 1, $dumpingOutput, $usingConfig);
         $this->runCommand('php bin/composer-dependency-analyser --composer-json=composer.json --format=junit', $rootDir, 0, $junitOutput, $usingConfig);
+        $this->runCommand('php bin/composer-dependency-analyser --composer-json=composer.json --format=junit --dump-usages=symfony/*', $rootDir, 255, null, $junitDumpError);
     }
 
     private function runCommand(

tests/InitializerTest.php

@@ -130,11 +130,43 @@ public function testInitFormatter(): void
         $optionsFormatJunit = new CliOptions();
         $optionsFormatJunit->format = 'junit';
         self::assertInstanceOf(JunitFormatter::class, $initializer->initFormatter($optionsFormatJunit));
+    }
 
-        self::expectException(InvalidConfigException::class);
-        $optionsFormatUnknown = new CliOptions();
-        $optionsFormatUnknown->format = 'unknown';
-        $initializer->initFormatter($optionsFormatUnknown);
+    /**
+     * @dataProvider provideInitFormatterFailures
+     */
+    public function testInitFormatterFailures(CliOptions $options, string $message): void
+    {
+        $printer = $this->createMock(Printer::class);
+
+        $initializer = new Initializer(__DIR__, $printer, $printer);
+
+        $this->expectException(InvalidConfigException::class);
+        $this->expectExceptionMessage($message);
+        $initializer->initFormatter($options);
+    }
+
+    /**
+     * @return iterable<string, array{CliOptions, string}>
+     */
+    public static function provideInitFormatterFailures(): iterable
+    {
+        $junitWithDumpUsages = new CliOptions();
+        $junitWithDumpUsages->format = 'junit';
+        $junitWithDumpUsages->dumpUsages = 'symfony/*';
+
+        $unknownFormat = new CliOptions();
+        $unknownFormat->format = 'unknown';
+
+        yield 'junit with dump-usages' => [
+            $junitWithDumpUsages,
+            "Cannot use 'junit' format with '--dump-usages' option.",
+        ];
+
+        yield 'unknown format' => [
+            $unknownFormat,
+            "Invalid format option provided, allowed are 'console' or 'junit'.",
+        ];
     }
 
 }