VendorEntrypointProvider: check all ancestors (#101)

Author: janedbal

src/Provider/VendorEntrypointProvider.php

@@ -3,7 +3,7 @@
 namespace ShipMonk\PHPStan\DeadCode\Provider;
 
 use Composer\Autoload\ClassLoader;
-use ReflectionException;
+use ReflectionClass;
 use ReflectionMethod;
 use function array_keys;
 use function str_starts_with;
@@ -33,18 +33,42 @@ public function isEntrypointMethod(ReflectionMethod $method): bool
             return false;
         }
 
-        try {
-            $methodPrototype = $method->getPrototype();
-        } catch (ReflectionException $e) {
-            return false; // hasPrototype available since PHP 8.2
-        }
+        $reflectionClass = $method->getDeclaringClass();
+        $methodName = $method->getName();
+
+        do {
+            if ($this->isForeignMethod($reflectionClass, $methodName)) {
+                return true;
+            }
+
+            foreach ($reflectionClass->getInterfaces() as $interface) {
+                if ($this->isForeignMethod($interface, $methodName)) {
+                    return true;
+                }
+            }
+
+            foreach ($reflectionClass->getTraits() as $trait) {
+                if ($this->isForeignMethod($trait, $methodName)) {
+                    return true;
+                }
+            }
 
-        return $this->isForeignMethod($methodPrototype);
+            $reflectionClass = $reflectionClass->getParentClass();
+        } while ($reflectionClass !== false);
+
+        return false;
     }
 
-    private function isForeignMethod(ReflectionMethod $methodPrototype): bool
+    /**
+     * @param ReflectionClass<object> $reflectionClass
+     */
+    private function isForeignMethod(ReflectionClass $reflectionClass, string $methodName): bool
     {
-        $filePath = $methodPrototype->getDeclaringClass()->getFileName();
+        if (!$reflectionClass->hasMethod($methodName)) {
+            return false;
+        }
+
+        $filePath = $reflectionClass->getFileName();
 
         if ($filePath === false) {
             return true; // php core or extension

tests/Rule/DeadMethodRuleTest.php

@@ -119,7 +119,7 @@ public static function provideFiles(): iterable
         yield 'call-on-class-string' => [__DIR__ . '/data/DeadMethodRule/class-string.php'];
         yield 'array-map-1' => [__DIR__ . '/data/DeadMethodRule/array-map-1.php'];
         yield 'unknown-class' => [__DIR__ . '/data/DeadMethodRule/unknown-class.php'];
-        yield 'provider-default' => [__DIR__ . '/data/DeadMethodRule/providers/default.php'];
+        yield 'provider-vendor' => [__DIR__ . '/data/DeadMethodRule/providers/vendor.php'];
         yield 'provider-symfony' => [__DIR__ . '/data/DeadMethodRule/providers/symfony.php', 8_00_00];
         yield 'provider-phpunit' => [__DIR__ . '/data/DeadMethodRule/providers/phpunit.php', 8_00_00];
         yield 'provider-doctrine' => [__DIR__ . '/data/DeadMethodRule/providers/doctrine.php', 8_00_00];

tests/Rule/data/DeadMethodRule/providers/default.php

@@ -0,0 +1,46 @@
+<?php declare(strict_types = 1);
+
+namespace Default;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\Rule as RuleFromVendor;
+
+interface IMyRule extends RuleFromVendor
+{
+    public function getNodeType(): string;
+}
+
+class MyRule implements IMyRule {
+
+    public function getNodeType(): string
+    {
+        return '';
+    }
+
+    public function processNode(Node $node, Scope $scope): array
+    {
+        return [];
+    }
+
+    public function unused(): array // error: Unused Default\MyRule::unused
+    {
+        return [];
+    }
+
+}
+
+class MyRuleDirect implements RuleFromVendor
+{
+
+    public function getNodeType(): string
+    {
+        return '';
+    }
+
+    public function processNode(Node $node, Scope $scope): array
+    {
+        return [];
+    }
+
+}