Skip to content

Commit 059292c

Browse files
JanTvrdikclaude
andcommitted
Fix deprecated PHPCS configuration syntax
- Replace comma-separated array values with proper XML element format - Remove deprecated Generic.Functions.CallTimePassByReference sniff - Replace deprecated Squiz.WhiteSpace.LanguageConstructSpacing with Generic.WhiteSpace.LanguageConstructSpacing - Update ForbiddenFunctions, ForbiddenComments, ForbiddenAnnotations, and TypeHint rules 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent d7a0419 commit 059292c

File tree

1 file changed

+51
-41
lines changed

1 file changed

+51
-41
lines changed

phpcs.xml.dist

Lines changed: 51 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
<property name="maxPadding" value="1"/>
4848
</properties>
4949
</rule>
50-
<rule ref="Generic.Functions.CallTimePassByReference"/>
5150
<rule ref="Generic.Functions.OpeningFunctionBraceBsdAllman"/>
5251
<rule ref="Generic.NamingConventions.ConstructorName"/>
5352
<rule ref="Generic.PHP.BacktickOperator"/>
@@ -60,28 +59,24 @@
6059
<rule ref="Generic.PHP.DisallowShortOpenTag"/>
6160
<rule ref="Generic.PHP.ForbiddenFunctions">
6261
<properties>
63-
<property
64-
name="forbiddenFunctions"
65-
type="array"
66-
value="
67-
mt_rand=>rand,
68-
sizeof=>count,
69-
delete=>unset,
70-
print=>echo,
71-
join=>implode,
72-
split=>explode,
73-
is_null=>null,
74-
create_function=>null,
75-
key_exists=>array_key_exists,
76-
floatval=>null,
77-
boolval=>null,
78-
intval=>null,
79-
strval=>null,
80-
settype=>null,
81-
exit=>null,
82-
reset=>array_key_first
83-
"
84-
/>
62+
<property name="forbiddenFunctions" type="array">
63+
<element key="mt_rand" value="rand"/>
64+
<element key="sizeof" value="count"/>
65+
<element key="delete" value="unset"/>
66+
<element key="print" value="echo"/>
67+
<element key="join" value="implode"/>
68+
<element key="split" value="explode"/>
69+
<element key="is_null" value="null"/>
70+
<element key="create_function" value="null"/>
71+
<element key="key_exists" value="array_key_exists"/>
72+
<element key="floatval" value="null"/>
73+
<element key="boolval" value="null"/>
74+
<element key="intval" value="null"/>
75+
<element key="strval" value="null"/>
76+
<element key="settype" value="null"/>
77+
<element key="exit" value="null"/>
78+
<element key="reset" value="array_key_first"/>
79+
</property>
8580
</properties>
8681
</rule>
8782
<rule ref="Generic.Strings.UnnecessaryStringConcat">
@@ -219,7 +214,7 @@
219214
<property name="spacing" value="1"/>
220215
</properties>
221216
</rule>
222-
<rule ref="Squiz.WhiteSpace.LanguageConstructSpacing"/>
217+
<rule ref="Generic.WhiteSpace.LanguageConstructSpacing"/>
223218
<rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
224219
<rule ref="Squiz.WhiteSpace.MemberVarSpacing"/>
225220
<rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing">
@@ -290,12 +285,27 @@
290285
<rule ref="SlevomatCodingStandard.Commenting.UselessInheritDocComment"/>
291286
<rule ref="SlevomatCodingStandard.Commenting.ForbiddenComments">
292287
<properties>
293-
<property name="forbiddenCommentPatterns" type="array" value="~^[a-zA-Z0-9]+ constructor.?$~,~PhpStorm~,~^[GS]et [a-zA-Z0-9]+$~"/>
288+
<property name="forbiddenCommentPatterns" type="array">
289+
<element value="~^[a-zA-Z0-9]+ constructor.?$~"/>
290+
<element value="~PhpStorm~"/>
291+
<element value="~^[GS]et [a-zA-Z0-9]+$~"/>
292+
</property>
294293
</properties>
295294
</rule>
296295
<rule ref="SlevomatCodingStandard.Commenting.ForbiddenAnnotations">
297296
<properties>
298-
<property name="forbiddenAnnotations" type="array" value="@author,@created,@version,@package,@copyright,@license,@since,@link,@group,@expectedException" />
297+
<property name="forbiddenAnnotations" type="array">
298+
<element value="@author"/>
299+
<element value="@created"/>
300+
<element value="@version"/>
301+
<element value="@package"/>
302+
<element value="@copyright"/>
303+
<element value="@license"/>
304+
<element value="@since"/>
305+
<element value="@link"/>
306+
<element value="@group"/>
307+
<element value="@expectedException"/>
308+
</property>
299309
</properties>
300310
</rule>
301311
<rule ref="SlevomatCodingStandard.ControlStructures.AssignmentInCondition"/>
@@ -378,32 +388,32 @@
378388
<rule ref="SlevomatCodingStandard.TypeHints.PropertyTypeHint">
379389
<properties>
380390
<property name="enableNativeTypeHint" value="true"/>
381-
<property name="traversableTypeHints" type="array" value="
382-
Generator,
383-
Traversable,
384-
Doctrine\Common\Collections\Collection
385-
"/>
391+
<property name="traversableTypeHints" type="array">
392+
<element value="Generator"/>
393+
<element value="Traversable"/>
394+
<element value="Doctrine\Common\Collections\Collection"/>
395+
</property>
386396
</properties>
387397
</rule>
388398

389399
<rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint">
390400
<properties>
391-
<property name="traversableTypeHints" type="array" value="
392-
Generator,
393-
Traversable,
394-
Doctrine\Common\Collections\Collection
395-
"/>
401+
<property name="traversableTypeHints" type="array">
402+
<element value="Generator"/>
403+
<element value="Traversable"/>
404+
<element value="Doctrine\Common\Collections\Collection"/>
405+
</property>
396406
</properties>
397407
<exclude name="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingTraversableTypeHintSpecification"/><!-- this has problems with vendor libs, PHPStan checks this much more reliably -->
398408
<exclude name="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint"/><!-- this has problems with vendor libs, PHPStan checks this much more reliably -->
399409
</rule>
400410
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint">
401411
<properties>
402-
<property name="traversableTypeHints" type="array" value="
403-
Generator,
404-
Traversable,
405-
Doctrine\Common\Collections\Collection
406-
"/>
412+
<property name="traversableTypeHints" type="array">
413+
<element value="Generator"/>
414+
<element value="Traversable"/>
415+
<element value="Doctrine\Common\Collections\Collection"/>
416+
</property>
407417
</properties>
408418
<exclude name="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingTraversableTypeHintSpecification"/><!-- this has problems with vendor libs, PHPStan checks this much more reliably -->
409419
</rule>

0 commit comments

Comments
 (0)