Enhance RuleTestCase to support multiple errors on same line

Key improvements:
- Update regex to properly parse multiple error comments using non-greedy matching
- Simplify expected errors parsing by removing complex sorting logic
- Add comprehensive test cases for multiple errors per line scenarios
- Add dedicated test method demonstrating 2, 3, and 4 errors on single lines
- Add test cases for mixed valid/invalid operations on same line

The enhanced RuleTestCase now correctly handles the common scenario where
multiple PHPStan rule violations occur on the same line of code, making it
much more practical for testing complex rules.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: JanTvrdik

src/RuleTestCase.php

@@ -30,9 +30,9 @@ protected function analyseFile(string $file, bool $autofix = false): void
     {
         $analyserErrors = $this->gatherAnalyserErrors([$file]);
 
-        if ($autofix === true) {
+        if ($autofix) {
             $this->autofix($file, $analyserErrors);
-            self::fail("File $file was autofixed. This setup should never remain in the codebase.");
+            self::fail("File {$file} was autofixed. This setup should never remain in the codebase.");
         }
 
         $actualErrors = $this->processActualErrors($analyserErrors);
@@ -74,27 +74,18 @@ private function parseExpectedErrors(string $file): array
         $expectedErrors = [];
 
         foreach ($fileLines as $line => $row) {
-            /** @var array{0: list<string>, 1: list<non-empty-string>} $matches */
-            $matched = preg_match_all('#// error:(.+)#', $row, $matches);
+            $matched = preg_match_all('#// error:(.*?)(?=// error:|$)#', $row, $matches);
 
             if ($matched === false) {
                 throw new LogicException('Error while matching errors');
             }
 
-            if ($matched === 0) {
-                continue;
-            }
-
             foreach ($matches[1] as $error) {
-                $actualLine = $line + 1;
-                $key = sprintf('%04d', $actualLine) . '-' . uniqid();
-                $expectedErrors[$key] = $this->formatErrorForAssert(trim($error), $actualLine);
+                $expectedErrors[] = $this->formatErrorForAssert(trim($error), $line + 1);
             }
         }
 
-        ksort($expectedErrors);
-
-        return array_values($expectedErrors);
+        return $expectedErrors;
     }
 
     private function formatErrorForAssert(string $message, int $line): string

tests/Rule/Data/DisallowDivisionByLiteralZeroRule/code.php

@@ -12,5 +12,13 @@ function testDivision(): void
 
     $invalidDivision = $a / 0; // error: Division by literal zero is not allowed
     $anotherInvalidDivision = 5 / 0; // error: Division by literal zero is not allowed
-}
 
+    // Test multiple errors on same line - each gets detected separately
+    $multipleErrors = ($a / 0) + (5 / 0); // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed
+
+    // Test three errors on one line
+    $threeErrors = ($a / 0) + (5 / 0) + (10 / 0); // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed
+
+    // Test mixed valid/invalid on same line (should only have one error)
+    $mixedLine = ($a / 2) + (5 / 0); // error: Division by literal zero is not allowed
+}

tests/Rule/Data/DisallowDivisionByLiteralZeroRule/multiple-errors.php

@@ -0,0 +1,21 @@
+<?php declare(strict_types = 1);
+
+namespace DisallowDivisionByLiteralZeroRule;
+
+function testMultipleErrorsPerLine(): void
+{
+    $a = 10;
+
+    // Line with two errors
+    $twoErrors = ($a / 0) + (5 / 0); // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed
+
+    // Line with three errors
+    $threeErrors = ($a / 0) + (5 / 0) + (10 / 0); // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed
+
+    // Line with four errors
+    $fourErrors = ($a / 0) + (5 / 0) + (10 / 0) + (15 / 0); // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed
+
+    // Mixed valid and invalid operations (only invalid ones should error)
+    $mixed = ($a / 2) + (5 / 0) + ($a / 3) + (10 / 0); // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed
+}
+

tests/RuleTestCaseTest.php

@@ -22,5 +22,12 @@ public function testRule(): void
         $this->analyseFile(__DIR__ . '/Rule/Data/DisallowDivisionByLiteralZeroRule/code.php');
     }
 
-}
+    public function testMultipleErrorsOnSameLine(): void
+    {
+        // Create a dedicated test file for multiple errors demonstration
+        $testFile = __DIR__ . '/Rule/Data/DisallowDivisionByLiteralZeroRule/multiple-errors.php';
 
+        $this->analyseFile($testFile);
+    }
+
+}