|
2 | 2 |
|
3 | 3 | namespace EnforceIteratorToArrayPreserveKeysRule;
|
4 | 4 |
|
| 5 | +/** |
| 6 | + * Isolate the generator, so that PHPStan is not aware of the keys. |
| 7 | + */ |
| 8 | +function passThru(\Generator $iterable): \Generator { |
| 9 | + yield from $iterable; |
| 10 | +} |
| 11 | + |
5 | 12 | $objectAsKey = function () {
|
6 | 13 | yield new \stdClass => 1;
|
7 | 14 | };
|
|
17 | 24 | };
|
18 | 25 |
|
19 | 26 |
|
20 |
| -iterator_to_array($objectAsKey()); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss. |
21 |
| -iterator_to_array($dataLoss()); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss. |
22 |
| -iterator_to_array($noKeys()); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss. |
| 27 | +iterator_to_array(passThru($objectAsKey())); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss. |
| 28 | +iterator_to_array(passThru($dataLoss())); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss. |
| 29 | +iterator_to_array(passThru($noKeys())); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss. |
23 | 30 |
|
24 |
| -iterator_to_array($objectAsKey(), false); |
25 |
| -iterator_to_array($dataLoss(), false); |
26 |
| -iterator_to_array($noKeys(), true); |
27 |
| -iterator_to_array(... [$noKeys(), true]); |
| 31 | +iterator_to_array(passThru($objectAsKey()), false); |
| 32 | +iterator_to_array(passThru($dataLoss()), false); |
| 33 | +iterator_to_array(passThru($noKeys()), true); |
| 34 | +iterator_to_array(... [passThru($noKeys()), true]); |
28 | 35 | iterator_to_array(
|
29 | 36 | preserve_keys: true,
|
30 |
| - iterator: $noKeys() |
| 37 | + iterator: passThru($noKeys()) |
31 | 38 | );
|
0 commit comments