Merge branch 'master' into fix-enforce-native-return

Author: mspirkov

.github/workflows/checks.yml

@@ -1,5 +1,6 @@
 name: Checks
 on:
+    workflow_dispatch:
     pull_request:
     push:
         branches:
@@ -13,7 +14,7 @@ jobs:
         steps:
             -
                 name: Checkout code
-                uses: actions/checkout@v4
+                uses: actions/checkout@v6
             -
                 name: Setup PHP
                 uses: shivammathur/setup-php@v2
@@ -38,7 +39,7 @@ jobs:
         steps:
             -
                 name: Checkout code
-                uses: actions/checkout@v4
+                uses: actions/checkout@v6
             -
                 name: Setup PHP
                 uses: shivammathur/setup-php@v2

.github/workflows/lint.yml

@@ -1,5 +1,6 @@
 name: phpcs.xml lint
 on:
+    workflow_dispatch:
     pull_request:
     push:
         branches:
@@ -12,7 +13,7 @@ jobs:
         steps:
             -
                 name: Checkout code
-                uses: actions/checkout@v3
+                uses: actions/checkout@v6
 
             -
                 name: Install dependencies

composer.json

@@ -11,7 +11,7 @@
     ],
     "require": {
         "php": "^7.4 || ^8.0",
-        "phpstan/phpstan": "^2.1.8"
+        "phpstan/phpstan": "^2.1.32"
     },
     "require-dev": {
         "editorconfig-checker/editorconfig-checker": "^10.6.0",

composer.lock

@@ -41,7 +41,7 @@ public function processNode(
             return [];
         }
 
-        if (!$node->isPublic() || $node->isReadOnly() || $node->hasHooks()) {
+        if (!$node->isPublic() || $node->isReadOnly() || $node->hasHooks() || $node->isPrivateSet() || $node->isProtectedSet()) {
             return [];
         }
 

src/Rule/EnforceReadonlyPublicPropertyRule.php

@@ -244,7 +244,7 @@ private function comparePhpDocAndNativeType(
             return [];
         }
 
-        if ($nativeReturnType instanceof MixedType) {
+        if ($nativeReturnType instanceof MixedType || $nativeReturnType->isVoid()->yes()) {
             return [];
         }
 

src/Rule/ForbidPhpDocNullabilityMismatchWithNativeTypehintRule.php

@@ -57,3 +57,9 @@ class ImplementingClass implements MyInterface {
 class ImplementingClass2 implements MyInterface {
     public readonly string $key;
 }
+
+class AsymmetricVisibility {
+    public private(set) string $privateSet;
+    public protected(set) string $protectedSet;
+    public public(set) string $publicSet; // error: Public property `publicSet` not marked as readonly.
+}

tests/Rule/data/EnforceReadonlyPublicPropertyRule/code-84.php

@@ -2,6 +2,7 @@
 
 namespace ForbidPhpDocNotMatchingNativeTypehintRule;
 
+use Exception;
 
 class HelloWorld
 {
@@ -105,4 +106,12 @@ public static function getStringMissingNull($stringOrNullInTemplate): ?string //
         return $stringOrNullInTemplate;
     }
 
+    /**
+     * @return never
+     */
+    public function throwSomeException(): void
+    {
+        throw new Exception();
+    }
+
 }