Skip to content

Compare forbidCustomFunctions with spaze/phpstan-disallowed-calls #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compare forbidCustomFunctions with spaze/phpstan-disallowed-calls #292

wants to merge 2 commits into from

Conversation

janedbal
Copy link
Member

@janedbal janedbal commented Dec 3, 2024 •
edited
Loading

This MR uses tests of our forbidCustomFunctions against logic in spaze/phpstan-disallowed-calls and changes the test files to display the diff of the behaviour.

Assuming our tests are correct then disallowed-calls reports:

  • false negative for any red diff (error removed)
  • false positive for any green diff (error added)

@janedbal janedbal mentioned this pull request Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janedbal