Skip to content

ForbidVariableTypeOverwriting: relax allowed narrowing and generalization #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ForbidVariableTypeOverwriting: relax allowed narrowing and generalization #295

wants to merge 2 commits into from

Conversation

janedbal
Copy link
Member

@janedbal janedbal commented Mar 5, 2025 •
edited
Loading

Since phpstan/phpstan-src#3853, following assignment:

interface SomeInterface {}
class SomeClass {}

function test(SomeInterface & SomeClass $classWithInterface) {
    $classWithInterface = new SomeClass();
}

no longer passes the old condition as those are false:

$previousVariableType->isSuperTypeOf($newVariableType)->yes(); // false
$newVariableType->isSuperTypeOf($previousVariableType)->yes(); // false

@janedbal
Copy link
Member Author

Logic kept, superseded by #296

@janedbal janedbal closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janedbal