EnforceReadonlyPublicPropertyRule: support asymmetric visibility #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not report publicPropertyNotReadonly error when property uses private(set) or protected(set) modifiers, as these properties are effectively readonly from outside the class. Fixes #319
Required for asymmetric visibility support (isPrivateSet/isProtectedSet methods).
JanTvrdik
force-pushed
the
fix-asymmetric-visibility-319
branch
from
4163e83 to
15f29df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
shipmonk.publicPropertyNotReadonlyto support PHP 8.4 asymmetric visibilityprivate(set)orprotected(set)modifiers, as these are effectively readonly from outside the classFixes #319
Test plan
public private(set),public protected(set), andpublic public(set)properties