Add closure-actions rule

Author: RobbieTheWagner

config/recommended.js

@@ -83,6 +83,7 @@ module.exports = {
 
     // Ember Suave and Netguru Rules
     'ship-shape/avoid-leaking-state-in-components': 'error',
+    'ship-shape/closure-actions': 'error',
     'ship-shape/no-direct-property-access': 'error',
     'ship-shape/no-empty-attrs': 'error',
     'ship-shape/no-observers': 'error',

lib/rules/closure-actions.js

@@ -0,0 +1,29 @@
+'use strict';
+
+var utils = require('../../lib/utils/utils');
+
+//------------------------------------------------------------------------------
+// Components - Closure actions
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+  var message = 'Use closure actions, unless you need bubbling';
+
+  var report = function(node) {
+    context.report(node, message);
+  };
+
+  return {
+    MemberExpression: function(node) {
+      var isSendAction = utils.isThisExpression(node.object) &&
+        utils.isIdentifier(node.property) &&
+        node.property.name === 'sendAction';
+
+      if (isSendAction) {
+        report(node);
+      }
+    }
+  };
+
+};

tests/lib/rules/closure-actions.js

@@ -0,0 +1,35 @@
+'use strict';
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+var rule = require('../../../lib/rules/closure-actions');
+var RuleTester = require('eslint').RuleTester;
+
+// ------------------------------------------------------------------------------
+// Tests
+// ------------------------------------------------------------------------------
+
+var eslintTester = new RuleTester();
+eslintTester.run('closure-actions', rule, {
+  valid: [
+    {
+      code: 'export default Component.extend();',
+      parserOptions: {ecmaVersion: 6, sourceType: "module"},
+    },
+    {
+      code: 'export default Component.extend({actions: {pushLever() {this.attr.boom();}}});',
+      parserOptions: {ecmaVersion: 6, sourceType: "module"},
+    }
+  ],
+  invalid: [
+    {
+      code: 'export default Component.extend({actions: {pushLever() {this.sendAction("detonate");}}});',
+      parserOptions: {ecmaVersion: 6, sourceType: "module"},
+      errors: [{
+        message: 'Use closure actions, unless you need bubbling',
+      }],
+    }
+  ]
+});