Skip to content

Commit 57089d6

Browse files
Merge pull request #266 from adambkaplan/bump-build-v0.17.0
bump(*): Update shipwright-io/build and Tekton deps
2 parents e5fde90 + aff4594 commit 57089d6

File tree

877 files changed

+72972
-15713
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

877 files changed

+72972
-15713
lines changed

controllers/result.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package controllers
22

33
import (
4+
"time"
5+
46
ctrl "sigs.k8s.io/controller-runtime"
57
)
68

79
// Requeue triggers a object requeue.
810
func Requeue() (ctrl.Result, error) {
9-
return ctrl.Result{Requeue: true}, nil
11+
return ctrl.Result{RequeueAfter: 1 * time.Second}, nil
1012
}
1113

1214
// RequeueOnError triggers requeue when error is not nil.
@@ -16,10 +18,10 @@ func RequeueOnError(err error) (ctrl.Result, error) {
1618

1719
// RequeueWithError triggers a object requeue because the informed error happend.
1820
func RequeueWithError(err error) (ctrl.Result, error) {
19-
return ctrl.Result{Requeue: true}, err
21+
return ctrl.Result{RequeueAfter: 1 * time.Second}, err
2022
}
2123

2224
// NoRequeue all done, the object does not need reconciliation anymore.
2325
func NoRequeue() (ctrl.Result, error) {
24-
return ctrl.Result{Requeue: false}, nil
26+
return ctrl.Result{}, nil
2527
}

controllers/shipwrightbuild_controller.go

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"context"
99
"fmt"
1010
"path/filepath"
11+
"time"
1112

1213
"github.com/go-logr/logr"
1314
"github.com/manifestival/manifestival"
@@ -180,7 +181,11 @@ func (r *ShipwrightBuildReconciler) Reconcile(ctx context.Context, req ctrl.Requ
180181
// ReconcileTekton
181182
_, requeue, err := tekton.ReconcileTekton(ctx, r.CRDClient, r.TektonOperatorClient)
182183
if err != nil {
183-
return ctrl.Result{Requeue: requeue}, err
184+
requeueInterval := 0 * time.Second
185+
if requeue {
186+
requeueInterval = 1 * time.Second
187+
}
188+
return ctrl.Result{RequeueAfter: requeueInterval}, err
184189
}
185190
if requeue {
186191
return Requeue()
@@ -261,7 +266,11 @@ func (r *ShipwrightBuildReconciler) Reconcile(ctx context.Context, req ctrl.Requ
261266
if common.BoolFromEnvVar(UseManagedWebhookCerts) {
262267
requeue, err = certmanager.ReconcileCertManager(ctx, r.CRDClient, r.Client, r.Logger, targetNamespace)
263268
if err != nil {
264-
return ctrl.Result{Requeue: requeue}, err
269+
requeueInterval := 0 * time.Second
270+
if requeue {
271+
requeueInterval = 1 * time.Second
272+
}
273+
return ctrl.Result{RequeueAfter: requeueInterval}, err
265274
}
266275
if requeue {
267276
return Requeue()

controllers/shipwrightbuild_controller_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ func testShipwrightBuildReconcilerReconcile(t *testing.T, targetNamespace string
176176
// This makes testing brittle and unable to capture the behavior on a real cluster.
177177
// Requeue can return "true" because the tests think the CRD for ClusterBuildStrategies
178178
// do not exist yet.
179-
g.Expect(res.Requeue).To(o.BeTrue(), "checking requeue for Reconcile")
179+
g.Expect(res.RequeueAfter).NotTo(o.BeZero(), "checking requeue for Reconcile")
180180
err = c.Get(ctx, deploymentName, &appsv1.Deployment{})
181181
g.Expect(err).To(o.BeNil())
182182
err = c.Get(ctx, namespacedName, b)
@@ -199,7 +199,7 @@ func testShipwrightBuildReconcilerReconcile(t *testing.T, targetNamespace string
199199
// This makes testing brittle and unable to capture the behavior on a real cluster.
200200
// Requeue can return "true" because the tests think the CRD for ClusterBuildStrategies
201201
// do not exist yet.
202-
g.Expect(res.Requeue).To(o.BeTrue())
202+
g.Expect(res.RequeueAfter).NotTo(o.BeZero())
203203
err = c.Get(ctx, deploymentName, deployment)
204204
g.Expect(err).To(o.BeNil())
205205
containers := deployment.Spec.Template.Spec.Containers
@@ -229,7 +229,7 @@ func testShipwrightBuildReconcilerReconcile(t *testing.T, targetNamespace string
229229

230230
res, err := r.Reconcile(ctx, req)
231231
g.Expect(err).To(o.BeNil())
232-
g.Expect(res.Requeue).To(o.BeFalse())
232+
g.Expect(res.RequeueAfter).To(o.BeZero())
233233

234234
err = c.Get(ctx, deploymentName, &appsv1.Deployment{})
235235
g.Expect(errors.IsNotFound(err)).To(o.BeTrue())
@@ -342,7 +342,7 @@ func TestShipwrightBuildReconciler_OperandReadiness(t *testing.T) {
342342
req := reconcile.Request{NamespacedName: namespacedName}
343343
res, err := r.Reconcile(ctx, req)
344344
g.Expect(err).To(o.BeNil())
345-
g.Expect(res.Requeue).To(o.BeTrue(), "Reconciliation should requeue when TektonConfig is not ready")
345+
g.Expect(res.RequeueAfter).NotTo(o.BeZero(), "Reconciliation should requeue when TektonConfig is not ready")
346346

347347
// Verify that the ShipwrightBuild is marked as not ready
348348
updated := &v1alpha1.ShipwrightBuild{}
@@ -363,7 +363,7 @@ func TestShipwrightBuildReconciler_OperandReadiness(t *testing.T) {
363363
// Trigger reconciliation again
364364
res, err = r.Reconcile(ctx, req)
365365
g.Expect(err).To(o.BeNil())
366-
g.Expect(res.Requeue).To(o.BeFalse(), "Should not requeue after TektonConfig is ready")
366+
g.Expect(res.RequeueAfter).To(o.BeZero(), "Should not requeue after TektonConfig is ready")
367367

368368
// Fetch and verify ShipwrightBuild is now ready
369369
err = c.Get(ctx, req.NamespacedName, updated)

go.mod

Lines changed: 44 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,34 @@ require (
77
github.com/go-logr/logr v1.4.3
88
github.com/manifestival/controller-runtime-client v0.4.0
99
github.com/manifestival/manifestival v0.7.2
10-
github.com/onsi/ginkgo/v2 v2.23.4
11-
github.com/onsi/gomega v1.37.0
12-
github.com/shipwright-io/build v0.16.0
13-
github.com/tektoncd/operator v0.76.0
10+
github.com/onsi/ginkgo/v2 v2.25.1
11+
github.com/onsi/gomega v1.38.1
12+
github.com/shipwright-io/build v0.17.0
13+
github.com/tektoncd/operator v0.77.0
1414
gopkg.in/yaml.v2 v2.4.0
15-
k8s.io/api v0.32.5
16-
k8s.io/apiextensions-apiserver v0.32.5
17-
k8s.io/apimachinery v0.33.0
15+
k8s.io/api v0.33.4
16+
k8s.io/apiextensions-apiserver v0.33.4
17+
k8s.io/apimachinery v0.33.4
1818
// go mod tidy forces this to v1.5.2
1919
k8s.io/client-go v1.5.2
20-
sigs.k8s.io/controller-runtime v0.20.4
20+
knative.dev/pkg v0.0.0-20250424013628-d5e74d29daa3
21+
sigs.k8s.io/controller-runtime v0.21.0
2122
)
2223

2324
require (
24-
contrib.go.opencensus.io/exporter/ocagent v0.7.1-0.20200907061046-05415f1de66d // indirect
25+
contrib.go.opencensus.io/exporter/ocagent v0.7.1-0.20230502190836-7399e0f8ee5e // indirect
2526
contrib.go.opencensus.io/exporter/prometheus v0.4.2 // indirect
27+
github.com/Masterminds/semver/v3 v3.4.0 // indirect
2628
github.com/beorn7/perks v1.0.1 // indirect
29+
github.com/blang/semver/v4 v4.0.0 // indirect
2730
github.com/blendle/zapdriver v1.3.1 // indirect
2831
github.com/census-instrumentation/opencensus-proto v0.4.1 // indirect
2932
github.com/cespare/xxhash/v2 v2.3.0 // indirect
3033
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
3134
github.com/emicklei/go-restful/v3 v3.12.2 // indirect
3235
github.com/evanphx/json-patch/v5 v5.9.11 // indirect
33-
github.com/fsnotify/fsnotify v1.8.0 // indirect
36+
github.com/fsnotify/fsnotify v1.9.0 // indirect
37+
github.com/fxamacker/cbor/v2 v2.8.0 // indirect
3438
github.com/go-logr/zapr v1.3.0 // indirect
3539
github.com/go-openapi/jsonpointer v0.21.1 // indirect
3640
github.com/go-openapi/jsonreference v0.21.0 // indirect
@@ -39,11 +43,12 @@ require (
3943
github.com/gogo/protobuf v1.3.2 // indirect
4044
github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect
4145
github.com/golang/protobuf v1.5.4 // indirect
46+
github.com/google/btree v1.1.3 // indirect
4247
github.com/google/gnostic-models v0.6.9 // indirect
4348
github.com/google/go-cmp v0.7.0 // indirect
44-
github.com/google/pprof v0.0.0-20250403155104-27863c87afa6 // indirect
49+
github.com/google/pprof v0.0.0-20250820193118-f64d9cf942d6 // indirect
4550
github.com/google/uuid v1.6.0 // indirect
46-
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 // indirect
51+
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.1 // indirect
4752
github.com/hashicorp/golang-lru v1.0.2 // indirect
4853
github.com/josharian/intern v1.0.0 // indirect
4954
github.com/json-iterator/go v1.1.12 // indirect
@@ -52,54 +57,51 @@ require (
5257
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
5358
github.com/modern-go/reflect2 v1.0.2 // indirect
5459
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
55-
github.com/openshift-pipelines/pipelines-as-code v0.35.0 // indirect
60+
github.com/openshift-pipelines/pipelines-as-code v0.36.0 // indirect
61+
github.com/openshift-pipelines/tektoncd-pruner v0.0.0-20250711075231-9c8624123820 // indirect
5662
github.com/openshift/api v0.0.0-20240521185306-0314f31e7774 // indirect
5763
github.com/openshift/apiserver-library-go v0.0.0-20230816171015-6bfafa975bfb // indirect
5864
github.com/openshift/client-go v0.0.0-20240523113335-452272e0496d // indirect
59-
github.com/prometheus/client_golang v1.22.0 // indirect
65+
github.com/pkg/errors v0.9.1 // indirect
66+
github.com/prometheus/client_golang v1.23.0 // indirect
6067
github.com/prometheus/client_model v0.6.2 // indirect
61-
github.com/prometheus/common v0.63.0 // indirect
68+
github.com/prometheus/common v0.65.0 // indirect
6269
github.com/prometheus/procfs v0.16.1 // indirect
6370
github.com/prometheus/statsd_exporter v0.28.0 // indirect
64-
github.com/spf13/pflag v1.0.6 // indirect
65-
github.com/tektoncd/pipeline v1.0.0 // indirect
71+
github.com/spf13/pflag v1.0.7 // indirect
72+
github.com/tektoncd/pipeline v1.3.1 // indirect
6673
github.com/tektoncd/triggers v0.32.0 // indirect
74+
github.com/x448/float16 v0.8.4 // indirect
6775
go.opencensus.io v0.24.0 // indirect
76+
go.uber.org/automaxprocs v1.6.0 // indirect
6877
go.uber.org/multierr v1.11.0 // indirect
6978
go.uber.org/zap v1.27.0 // indirect
70-
golang.org/x/net v0.39.0 // indirect
79+
go.yaml.in/yaml/v2 v2.4.2 // indirect
80+
go.yaml.in/yaml/v3 v3.0.4 // indirect
81+
golang.org/x/net v0.43.0 // indirect
7182
golang.org/x/oauth2 v0.30.0 // indirect
72-
golang.org/x/sync v0.14.0 // indirect
73-
golang.org/x/sys v0.33.0 // indirect
74-
golang.org/x/term v0.31.0 // indirect
75-
golang.org/x/text v0.24.0 // indirect
76-
golang.org/x/time v0.11.0 // indirect
77-
golang.org/x/tools v0.32.0 // indirect
83+
golang.org/x/sync v0.16.0 // indirect
84+
golang.org/x/sys v0.35.0 // indirect
85+
golang.org/x/term v0.34.0 // indirect
86+
golang.org/x/text v0.28.0 // indirect
87+
golang.org/x/time v0.12.0 // indirect
88+
golang.org/x/tools v0.36.0 // indirect
7889
gomodules.xyz/jsonpatch/v2 v2.5.0 // indirect
79-
google.golang.org/api v0.231.0 // indirect
80-
google.golang.org/genproto/googleapis/api v0.0.0-20250428153025-10db94c68c34 // indirect
81-
google.golang.org/genproto/googleapis/rpc v0.0.0-20250428153025-10db94c68c34 // indirect
82-
google.golang.org/grpc v1.72.0 // indirect
83-
google.golang.org/protobuf v1.36.6 // indirect
90+
google.golang.org/api v0.237.0 // indirect
91+
google.golang.org/genproto/googleapis/api v0.0.0-20250603155806-513f23925822 // indirect
92+
google.golang.org/genproto/googleapis/rpc v0.0.0-20250603155806-513f23925822 // indirect
93+
google.golang.org/grpc v1.74.2 // indirect
94+
google.golang.org/protobuf v1.36.7 // indirect
95+
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
8496
gopkg.in/inf.v0 v0.9.1 // indirect
8597
gopkg.in/yaml.v3 v3.0.1 // indirect
8698
k8s.io/klog/v2 v2.130.1 // indirect
8799
k8s.io/kube-openapi v0.0.0-20250318190949-c8a335a9a2ff // indirect
88100
k8s.io/utils v0.0.0-20250502105355-0f33e8f1c979 // indirect
89-
knative.dev/pkg v0.0.0-20250424013628-d5e74d29daa3 // indirect
90101
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect
91-
sigs.k8s.io/structured-merge-diff/v4 v4.7.0 // indirect
92-
sigs.k8s.io/yaml v1.4.0 // indirect
93-
)
94-
95-
require (
96-
github.com/fxamacker/cbor/v2 v2.8.0 // indirect
97-
github.com/google/btree v1.1.3 // indirect
98-
github.com/pkg/errors v0.9.1 // indirect
99-
github.com/x448/float16 v0.8.4 // indirect
100-
go.uber.org/automaxprocs v1.6.0 // indirect
101-
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
102102
sigs.k8s.io/randfill v1.0.0 // indirect
103+
sigs.k8s.io/structured-merge-diff/v4 v4.7.0 // indirect
104+
sigs.k8s.io/yaml v1.6.0 // indirect
103105
)
104106

105107
// Go modules at times does not effectively resolve transitive dependencies that share
@@ -113,4 +115,4 @@ require (
113115
// go module version standardization (v0.y.z, with y and z representing the k8s 1.y.z minor/patch
114116
// versions). `go mod tidy` will often overwrite the desired client-go version to v1.5.2, so we
115117
// pin the version here.
116-
replace k8s.io/client-go => k8s.io/client-go v0.32.4
118+
replace k8s.io/client-go => k8s.io/client-go v0.33.4

0 commit comments

Comments
 (0)