Fix Uri\WhatWg\Url::withPort() when an invalid value is passed

kocsismate · TimWolla · kocsismate · commit 43c3afeff78f · 2025-09-27T13:22:05.000+02:00
Cherry-picked from lexbor/lexbor@4ccbc54 Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
diff --git a/NEWS b/NEWS
@@ -5,6 +5,9 @@ PHP                                                                        NEWS
 - Opcache
   . Fixed segfault in function JIT due to NAN to bool warning. (Girgias)
 
+- URI:
+  . Fixed Uri\WhatWg\Url::withPort() when an invalid value is passed. (timwolla)
+
 25 Sep 2025, PHP 8.5.0RC1
 
 - Core:
diff --git a/ext/lexbor/lexbor/url/url.c b/ext/lexbor/lexbor/url/url.c
@@ -1906,7 +1906,7 @@ lxb_url_parse_basic_h(lxb_url_parser_t *parser, lxb_url_t *url,
             {
                 if (begin == p) {
                     if (override_state != LXB_URL_STATE__UNDEF) {
-                        lxb_url_parse_return(orig_data, buf, LXB_STATUS_OK);
+                        lxb_url_parse_return(orig_data, buf, LXB_STATUS_ERROR);
                     }
 
                     state = LXB_URL_STATE_PATH_START_STATE;

Original file line number	Diff line number	Diff line change
`@@ -1906,7 +1906,7 @@ lxb_url_parse_basic_h(lxb_url_parser_t parser, lxb_url_t url,`
`1906`	`1906`	`{`
`1907`	`1907`	`if (begin == p) {`
`1908`	`1908`	`if (override_state != LXB_URL_STATE__UNDEF) {`
`1909`		`- lxb_url_parse_return(orig_data, buf, LXB_STATUS_OK);`
	`1909`	`+ lxb_url_parse_return(orig_data, buf, LXB_STATUS_ERROR);`
`1910`	`1910`	`}`
`1911`	`1911`
`1912`	`1912`	`state = LXB_URL_STATE_PATH_START_STATE;`