Skip to content

Commit 32f55dd

Browse files
authored
fix(ci): Properly check boolean input as string in publish condition (#448)
GitHub Actions converts boolean inputs to strings ('true'/'false'). Checking the value directly would be truthy even for 'false'. Fixed by checking: publish_to_pypi != 'false' This ensures: - Runs when checkbox is checked (value: 'true') - Runs with default value (default: true) - Skips when checkbox is unchecked (value: 'false')
1 parent 4ddda26 commit 32f55dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/pypi-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ jobs:
222222

223223
publish:
224224
needs: [build-wheels, build-sdist]
225-
if: github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.event.inputs.publish_to_pypi)
225+
if: github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.event.inputs.publish_to_pypi != 'false')
226226
runs-on: ubuntu-latest
227227

228228
steps:

0 commit comments

Comments
 (0)