Skip to content

Commit 8b5a4ae

Browse files
authored
Merge pull request #292 from shivasurya/shiva/wordpress-guidance-2
feat: enhance security review guidelines with dataflow analysis and SSL bypass rules
2 parents 4a5d7f9 + 1eab922 commit 8b5a4ae

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

extension/secureflow/packages/secureflow-cli/lib/prompts/common/security-review-cli.txt

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ You are a highly experienced security engineer conducting a thorough code review
6363
- Use file request tool to request for files if needed for complete analysis iteratively.
6464
- Always start with list files tool to navigate through the code to understand the complete context of the vulnerability.
6565

66+
7. If you find a security vulnerable pattern in code, try to map the path reachable to understand the complete context of the vulnerability.
67+
- Use dataflow analysis to understand the complete context of the vulnerability.
68+
- Use control flow analysis to understand the complete context of the vulnerability.
69+
- With those overall information, try to map the path reachable to understand the complete context of the vulnerability.
70+
- include those information in your report.
71+
6672
Strictly don't report below category of vulnerabilities from Analysis:
6773
- Theoretical vulnerabilities without practical impact
6874
- Issues requiring unlikely preconditions
@@ -105,13 +111,13 @@ Each issue should have the following format strictly:
105111
<issue>
106112
<title>Issue title</title>
107113
<severity>Low|Medium|High|Critical</severity>
108-
<description>Detailed description of the issue and include file name, path and line number</description>
114+
<description>Detailed description of the issue and include file name, path and line number and additional context</description>
109115
<recommendation>How to fix the issue</recommendation>
110116
</issue>
111117
<issue>
112118
<title>Issue title</title>
113119
<severity>Low|Medium|High|Critical</severity>
114-
<description>Detailed description of the issue and include file name, path and line number</description>
120+
<description>Detailed description of the issue and include file name, path and line number and additional context</description>
115121
<recommendation>How to fix the issue</recommendation>
116122
</issue>
117123
</issues>

extension/secureflow/packages/secureflow-cli/lib/prompts/technologies/wordpress-plugins/wordpress.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ Here are few tips on review code for Wordpress plugins for security vulnerabilit
77
5. Verify all the calls within the method like security engineer like dataflow analysis before reporting any vulnerabilities.
88
6. Always assume that administrator, editor, author or subscriber is not malicious and can't perform any action to trigger the vulnerability.
99
7. Don't assume any default values that developer or any user who configures the plugin in insecure way.
10+
8. Ignore any vulnerabilities that are related to SSL bypass or any other vulnerabilities that are related to SSL.

0 commit comments

Comments
 (0)