wip 77

Author: shivkumar98

05-javascript-a-ds-new/2-advanced-javascript/2d-learn-recursion-by-building-binary-converter/README.md

@@ -454,11 +454,11 @@
 ## 🟥 Making Stack Animation 
 * I want to show an animation of how `5` is converted to it's binary input using an animation
 * I create a new function to show the animation:
-```js
-const showAnimation = () => {}
-```
+   ```js
+   const showAnimation = () => {}
+   ```
 * And then I call this function and return early, in checkUserInput, when input is 5:
-```js
+   ```js
    const checkUserInput = () => {
       // CHECK USER INPUT LOGIC
 
@@ -468,4 +468,27 @@ const showAnimation = () => {}
    }
    // REST OF CODE
    };
-```
+   ```
+
+### 🔺 Refactoring checkUserInput() 🔺
+* My `checkUserInput` function has loads of duplication with parsing the user input:
+   <details>
+   <summary>checkUserInput()</summary>
+
+   ```js
+   const checkUserInput = () => {
+      if (!numberInput.value || isNaN(parseInt(numberInput.value)) || parseInt(numberInput.value)<0) {
+         alert("Please provide a decimal number greater than or equal to 0");
+         return;
+      }
+
+      if (parseInt(numberInput.value) === 5) {
+         showAnimation();
+         return; 
+      }
+
+      result.textContent = decimalToBinary(parseInt(numberInput.value))
+      numberInput.value = ''
+   }
+   ```
+   </details>