Merge pull request #75 from acelaya-forks/phpunit-notices

Address notices reported by latest PHPUnit

Author: acelaya

composer.json

@@ -15,7 +15,7 @@
         "php": "^8.4",
         "ext-zlib": "*",
         "fig/http-message-util": "^1.1",
-        "geoip2/geoip2": "^3.2",
+        "geoip2/geoip2": "^3.3",
         "guzzlehttp/guzzle": "^7.10",
         "shlinkio/shlink-config": "^4.0",
         "symfony/filesystem": "^8.0 || ^7.4"
@@ -24,8 +24,7 @@
         "devster/ubench": "^2.1",
         "phpstan/phpstan": "^2.1",
         "phpstan/phpstan-phpunit": "^2.0",
-        "phpunit/phpunit": "^12.4",
-        "roave/security-advisories": "dev-master",
+        "phpunit/phpunit": "^12.5",
         "shlinkio/php-coding-standard": "~2.5.0",
         "symfony/var-dumper": "^8.0"
     },

phpunit.xml.dist

@@ -5,7 +5,10 @@
     bootstrap="./vendor/autoload.php"
     colors="true"
     cacheDirectory="build/.phpunit.cache"
-    displayDetailsOnTestsThatTriggerWarnings="true"
+    displayDetailsOnPhpunitDeprecations="true"
+    displayDetailsOnTestsThatTriggerDeprecations="true"
+    displayDetailsOnPhpunitNotices="true"
+    displayDetailsOnTestsThatTriggerNotices="true"
 >
     <testsuites>
         <testsuite name="IpGeolocation">

test/GeoLite2/DbUpdaterTest.php

@@ -8,6 +8,7 @@
 use GuzzleHttp\Exception\ClientException;
 use GuzzleHttp\Psr7\Request;
 use GuzzleHttp\Psr7\Response;
+use PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\MockObject\MockObject;
@@ -26,6 +27,7 @@
 
 use function sys_get_temp_dir;
 
+#[AllowMockObjectsWithoutExpectations]
 class DbUpdaterTest extends TestCase
 {
     private MockObject & ClientInterface $httpClient;
@@ -146,7 +148,7 @@ public static function provideInvalidLicenses(): iterable
     private function dbUpdater(bool $throwOnExtract = false, string|null $licenseKey = 'foobar'): DbUpdater
     {
         $options = new GeoLite2Options($licenseKey, 'db_location', tempDir: sys_get_temp_dir());
-        $fileExtractor = $this->createMock(FileExtractorInterface::class);
+        $fileExtractor = $this->createStub(FileExtractorInterface::class);
 
         if ($throwOnExtract) {
             $fileExtractor->method('extractFile')->willThrowException(ExtractException::forInvalidCompressedFile(''));