Relax (again) the check in blockLoader in RangeFieldMapper, since it seem to fail in practice

shmuelhanoch · shmuelhanoch · commit 30ced99e46f7 · 2025-10-26T10:43:54.000+02:00
diff --git a/server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java b/server/src/main/java/org/elasticsearch/index/mapper/RangeFieldMapper.java
@@ -374,7 +374,8 @@ public BlockLoader blockLoader(BlockLoaderContext blContext) {
             if (rangeType != RangeType.DATE) {
                 throw new UnsupportedOperationException("loading blocks is only supported for date fields");
             }
-            if (blContext.fieldExtractPreference() == DOC_VALUES && hasDocValues()) {
+            // TODO: do we need this additional check?
+            if (/* blContext.fieldExtractPreference() == DOC_VALUES && */ hasDocValues()) {
                 return new DateRangeDocValuesLoader(name());
             }
             throw new IllegalStateException("Cannot load blocks without doc values");

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,8 @@ public BlockLoader blockLoader(BlockLoaderContext blContext) {`
`374`	`374`	`if (rangeType != RangeType.DATE) {`
`375`	`375`	`throw new UnsupportedOperationException("loading blocks is only supported for date fields");`
`376`	`376`	`}`
`377`		`- if (blContext.fieldExtractPreference() == DOC_VALUES && hasDocValues()) {`
	`377`	`+ // TODO: do we need this additional check?`
	`378`	`+ if (/* blContext.fieldExtractPreference() == DOC_VALUES && */ hasDocValues()) {`
`378`	`379`	`return new DateRangeDocValuesLoader(name());`
`379`	`380`	`}`
`380`	`381`	`throw new IllegalStateException("Cannot load blocks without doc values");`