Skip to content

Commit c6b96ac

Browse files
authored
Log a missing secret instead of failing (#127)
1 parent 9b59736 commit c6b96ac

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

shpkpr/vault.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# stdlib imports
2+
import logging
3+
4+
5+
logger = logging.getLogger(__name__)
16

27

38
def resolve_secrets(vault_client, rendered_template):
@@ -14,7 +19,10 @@ def resolve_secrets(vault_client, rendered_template):
1419
# parse the secret source and retrieve from vault
1520
path, key = definition["source"].split(":")
1621
path = "secret/{0}".format(path)
17-
secret = vault_client.read(path)["data"][key]
18-
resolved_secrets[name] = secret
22+
secret = vault_client.read(path)
23+
if secret:
24+
resolved_secrets[name] = secret["data"][key]
25+
else:
26+
logger.info("Couldn't locate secret in Vault: {0}".format(path))
1927

2028
return resolved_secrets

0 commit comments

Comments
 (0)