remove constant.js (#2969)

vitek-rostislav · web-flow · commit 485a19f538aa · 2024-02-01T09:10:36.000+01:00
diff --git a/assets/js/admin/components/AdvancedSearch.js b/assets/js/admin/components/AdvancedSearch.js
@@ -1,7 +1,6 @@
 import 'select2/dist/js/select2.full';
 import Ajax from '../../common/utils/Ajax';
 import Register from '../../common/utils/Register';
-import constant from '../utils/constant';
 
 export default class AdvancedSearch {
 
@@ -71,7 +70,7 @@ export default class AdvancedSearch {
     }
 
     static updateValueByOperator ($rulesContainer, $rule, operator) {
-        $rule.find('.js-advanced-search-rule-value').toggle(operator !== constant('\\Shopsys\\FrameworkBundle\\Model\\AdvancedSearch\\AdvancedSearchFilterInterface::OPERATOR_NOT_SET'));
+        $rule.find('.js-advanced-search-rule-value').toggle(operator !== 'notSet');
     }
 
     static init ($container) {
diff --git a/assets/js/admin/components/MassActionConfirm.js b/assets/js/admin/components/MassActionConfirm.js
@@ -1,4 +1,3 @@
-import constant from '../utils/constant';
 import Window from '../utils/Window';
 import Register from '../../common/utils/Register';
 import Translator from 'bazinga-translator';
@@ -16,10 +15,10 @@ export default class MassActionConfirm {
                 const selectType = $('.js-mass-action-select-type').val();
                 let count;
                 switch (selectType) {
-                    case constant('\\Shopsys\\FrameworkBundle\\Model\\Product\\MassAction\\ProductMassActionData::SELECT_TYPE_CHECKED'):
+                    case 'selectTypeChecked':
                         count = $('.js-grid-mass-action-select-row:checked').length;
                         break;
-                    case constant('\\Shopsys\\FrameworkBundle\\Model\\Product\\MassAction\\ProductMassActionData::SELECT_TYPE_ALL_RESULTS'):
+                    case 'selectTypeAllResults':
                         count = $('.js-grid').data('total-count');
                         break;
                 }
diff --git a/assets/js/admin/components/OrderItems.js b/assets/js/admin/components/OrderItems.js
@@ -3,7 +3,6 @@ import Register from '../../common/utils/Register';
 import { addNewItemToCollection, removeItemFromCollection } from '../validation/customization/customizeCollectionBundle';
 import ProductPicker from './ProductPicker';
 import { escapeHtml } from '../../common/utils/escapeHtml';
-import constant from '../utils/constant';
 import '../../common/bootstrap/tooltip';
 import Translator from 'bazinga-translator';
 import Window from '../utils/Window';
@@ -134,18 +133,19 @@ export default class OrderItems {
 
     getNewIndex ($collection) {
         let maxIndex = 0;
+        const newItemIndex = 'new_';
 
         $collection.find('.js-order-item').each(function () {
             const indexStr = $(this).data('index').toString();
-            if (indexStr.indexOf(constant('\\Shopsys\\FrameworkBundle\\Model\\Order\\OrderData::NEW_ITEM_PREFIX')) === 0) {
+            if (indexStr.indexOf(newItemIndex) === 0) {
                 const index = parseInt(indexStr.slice(4));
                 if (index > maxIndex) {
                     maxIndex = index;
                 }
             }
         });
 
-        return constant('\\Shopsys\\FrameworkBundle\\Model\\Order\\OrderData::NEW_ITEM_PREFIX') + (maxIndex + 1);
+        return newItemIndex + (maxIndex + 1);
     }
 
     static onPriceCalculationChange ($orderItem) {
diff --git a/assets/js/admin/components/Product.js b/assets/js/admin/components/Product.js
@@ -1,4 +1,3 @@
-import constant from '../utils/constant';
 import Register from '../../common/utils/Register';
 
 export default class Product {
@@ -10,12 +9,13 @@ export default class Product {
             Product.toggleIsUsingStock($(this).val() === '1');
         });
 
+        const alternateAvailability = 'setAlternateAvailability';
         $outOfStockActionSelection.change(function () {
-            Product.toggleIsUsingAlternateAvailability($(this).val() === constant('\\Shopsys\\FrameworkBundle\\Model\\Product\\Product::OUT_OF_STOCK_ACTION_SET_ALTERNATE_AVAILABILITY'));
+            Product.toggleIsUsingAlternateAvailability($(this).val() === alternateAvailability);
         });
 
         Product.toggleIsUsingStock(usingStockSelection.filter(':checked').val() === '1');
-        Product.toggleIsUsingAlternateAvailability($outOfStockActionSelection.val() === constant('\\Shopsys\\FrameworkBundle\\Model\\Product\\Product::OUT_OF_STOCK_ACTION_SET_ALTERNATE_AVAILABILITY'));
+        Product.toggleIsUsingAlternateAvailability($outOfStockActionSelection.val() === alternateAvailability);
 
         Product.initializeSideNavigation($container);
     }
diff --git a/assets/js/admin/utils/constant.js b/assets/js/admin/utils/constant.js
diff --git a/assets/js/admin/validation/form/validation.js b/assets/js/admin/validation/form/validation.js
@@ -0,0 +1 @@
+export const VALIDATION_GROUP_DEFAULT = 'Default';
diff --git a/assets/js/admin/validation/form/validationAdvert.js b/assets/js/admin/validation/form/validationAdvert.js
@@ -1,7 +1,7 @@
 // Script is named "noticer.js" because scripts named "advert.js" are often blocked by browser (e.g. by AdBlock plugin)
 
-import constant from '../../utils/constant';
 import Register from '../../../common/utils/Register';
+import { VALIDATION_GROUP_DEFAULT } from './validation';
 
 export default function validationAdvert () {
     const $advertForm = $('form[name="advert_form"]');
@@ -36,13 +36,13 @@ export default function validationAdvert () {
 
     $advertForm.jsFormValidator({
         'groups': function () {
-            const groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+            const groups = [VALIDATION_GROUP_DEFAULT];
 
             const checkedType = getCheckedType();
-            if (checkedType === constant('\\Shopsys\\FrameworkBundle\\Model\\Advert\\Advert::TYPE_CODE')) {
-                groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Advert\\AdvertFormType::VALIDATION_GROUP_TYPE_CODE'));
-            } else if (checkedType === constant('\\Shopsys\\FrameworkBundle\\Model\\Advert\\Advert::TYPE_IMAGE')) {
-                groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Advert\\AdvertFormType::VALIDATION_GROUP_TYPE_IMAGE'));
+            if (checkedType === 'code') {
+                groups.push('typeCode');
+            } else if (checkedType === 'image') {
+                groups.push('typeImage');
             }
 
             return groups;
diff --git a/assets/js/admin/validation/form/validationCustomer.js b/assets/js/admin/validation/form/validationCustomer.js
@@ -1,13 +1,13 @@
-import constant from '../../utils/constant';
 import Register from '../../../common/utils/Register';
+import { VALIDATION_GROUP_DEFAULT } from './validation';
 
 export default function validationCustomer () {
     const $customerDeliveryAddressForm = $('#customer_form_deliveryAddressData');
     $customerDeliveryAddressForm.jsFormValidator({
         'groups': function () {
-            const groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+            const groups = [VALIDATION_GROUP_DEFAULT];
             if ($customerDeliveryAddressForm.find('#customer_form_deliveryAddressData_deliveryAddress_addressFilled').is(':checked')) {
-                groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Customer\\DeliveryAddressFormType::VALIDATION_GROUP_DIFFERENT_DELIVERY_ADDRESS'));
+                groups.push('differentDeliveryAddress');
             }
 
             return groups;
@@ -17,9 +17,9 @@ export default function validationCustomer () {
     $customerBillingAddressForm.jsFormValidator({
         'groups': function () {
 
-            var groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+            var groups = [VALIDATION_GROUP_DEFAULT];
             if ($customerBillingAddressForm.find('#customer_form_billingAddressData_companyData_companyCustomer').is(':checked')) {
-                groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Customer\\BillingAddressFormType::VALIDATION_GROUP_COMPANY_CUSTOMER'));
+                groups.push('companyCustomer');
             }
 
             return groups;
diff --git a/assets/js/admin/validation/form/validationFreTransportAndPayment.js b/assets/js/admin/validation/form/validationFreTransportAndPayment.js
@@ -1,15 +1,15 @@
-import constant from '../../utils/constant';
 import Register from '../../../common/utils/Register';
+import { VALIDATION_GROUP_DEFAULT } from './validation';
 
 export default function validationFreeTransportAndPayment () {
     $('.js-free-transport-and-payment-price-limit').each(function () {
         const $priceLimitForm = $(this);
         $priceLimitForm.jsFormValidator({
             'groups': function () {
 
-                const groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+                const groups = [VALIDATION_GROUP_DEFAULT];
                 if ($priceLimitForm.find('.js-free-transport-and-payment-price-limit-enabled').is(':checked')) {
-                    groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\TransportAndPayment\\FreeTransportAndPaymentPriceLimitsFormType::VALIDATION_GROUP_PRICE_LIMIT_ENABLED'));
+                    groups.push('priceLimitEnabled');
                 }
 
                 return groups;
diff --git a/assets/js/admin/validation/form/validationMailTemplate.js b/assets/js/admin/validation/form/validationMailTemplate.js
@@ -1,5 +1,5 @@
-import constant from '../../utils/constant';
 import Register from '../../../common/utils/Register';
+import { VALIDATION_GROUP_DEFAULT } from './validation';
 
 export default function validationMailTemplate () {
     $('#js-mail-templates').find('.js-mail-template').each(function () {
@@ -9,9 +9,9 @@ export default function validationMailTemplate () {
         $(this).jsFormValidator({
             'groups': function () {
 
-                const groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+                const groups = [VALIDATION_GROUP_DEFAULT];
                 if ($(self).find('#' + sendMailId).is(':checked')) {
-                    groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Mail\\MailTemplateFormType::VALIDATION_GROUP_SEND_MAIL'));
+                    groups.push('sendMail');
                 }
 
                 return groups;
diff --git a/assets/js/admin/validation/form/validationOrder.js b/assets/js/admin/validation/form/validationOrder.js
@@ -1,14 +1,14 @@
-import constant from '../../utils/constant';
 import Register from '../../../common/utils/Register';
+import { VALIDATION_GROUP_DEFAULT } from './validation';
 
 export default function validationOrder ($container) {
     const $orderForm = $container.filterAllNodes('form[name="order_form"]');
     $orderForm.jsFormValidator({
         'groups': function () {
 
-            var groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+            var groups = [VALIDATION_GROUP_DEFAULT];
             if (!$orderForm.find('#order_form_shippingAddressGroup_deliveryAddressSameAsBillingAddress').is(':checked')) {
-                groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Order\\OrderFormType::VALIDATION_GROUP_DELIVERY_ADDRESS_SAME_AS_BILLING_ADDRESS'));
+                groups.push('deliveryAddressSameAsBillingAddress');
             }
 
             return groups;
@@ -22,9 +22,9 @@ export default function validationOrder ($container) {
         $orderItemForm.jsFormValidator({
             'groups': function () {
 
-                const groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+                const groups = [VALIDATION_GROUP_DEFAULT];
                 if ($orderItemForm.find('.js-set-prices-manually').is(':checked')) {
-                    groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Order\\OrderItemFormType::VALIDATION_GROUP_NOT_USING_PRICE_CALCULATION'));
+                    groups.push('notUsingPriceCalculation');
                 }
 
                 return groups;
diff --git a/assets/js/admin/validation/form/validationProduct.js b/assets/js/admin/validation/form/validationProduct.js
@@ -1,20 +1,20 @@
-import constant from '../../utils/constant';
 import Register from '../../../common/utils/Register';
+import { VALIDATION_GROUP_DEFAULT } from './validation';
 
 export default function validationProduct () {
     const $productForm = $('form[name="product_form"]');
     $productForm.jsFormValidator({
         'groups': function () {
 
-            const groups = [constant('\\Shopsys\\FrameworkBundle\\Form\\ValidationGroup::VALIDATION_GROUP_DEFAULT')];
+            const groups = [VALIDATION_GROUP_DEFAULT];
 
             if ($('input[name="product_form[displayAvailabilityGroup][usingStock]"]:checked').val() === '1') {
-                groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Product\\ProductFormType::VALIDATION_GROUP_USING_STOCK'));
-                if ($('select[name="product_form[displayAvailabilityGroup][stockGroup][outOfStockAction]"]').val() === constant('\\Shopsys\\FrameworkBundle\\Model\\Product\\Product::OUT_OF_STOCK_ACTION_SET_ALTERNATE_AVAILABILITY')) {
-                    groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Product\\ProductFormType::VALIDATION_GROUP_USING_STOCK_AND_ALTERNATE_AVAILABILITY'));
+                groups.push('usingStock');
+                if ($('select[name="product_form[displayAvailabilityGroup][stockGroup][outOfStockAction]"]').val() === 'setAlternateAvailability') {
+                    groups.push('usingStockAndAlternateAvailability');
                 }
             } else {
-                groups.push(constant('\\Shopsys\\FrameworkBundle\\Form\\Admin\\Product\\ProductFormType::VALIDATION_GROUP_NOT_USING_STOCK'));
+                groups.push('notUsingStock');
             }
 
             return groups;
diff --git a/assets/js/common/components/datePicker.js b/assets/js/common/components/datePicker.js
@@ -1,6 +1,5 @@
 import 'jquery-ui/datepicker';
 import Register from '../utils/Register';
-import constant from '../../admin/utils/constant';
 
 /* Czech initialisation for the jQuery UI date picker plugin. */
 /* Written by Tomas Muller (tomas@tomas-muller.net). */
@@ -30,7 +29,7 @@ export default function datePicker ($container) {
         const options = Object.assign({}, $.datepicker.regional[global.locale] || $.datepicker.regional['']);
 
         // Date format is fixed so that it is understood by back-end
-        options.dateFormat = constant('\\Shopsys\\FrameworkBundle\\Form\\DatePickerType::FORMAT_JS');
+        options.dateFormat = 'dd.mm.yy';
 
         $(this).datepicker(options);
     });
diff --git a/assets/js/common/validation/ConstraintNotNull.js b/assets/js/common/validation/ConstraintNotNull.js
@@ -1,5 +1,3 @@
-import constant from '../../admin/utils/constant';
-
 (function (window) {
 
     const SymfonyComponentValidatorConstraintsNotNull = function () {
@@ -11,9 +9,9 @@ import constant from '../../admin/utils/constant';
 
             let isValueNull;
 
-            if (element.type === constant('\\Symfony\\Component\\Form\\Extension\\Core\\Type\\CheckboxType::class')) {
+            if (element.type === 'Symfony\\Component\\Form\\Extension\\Core\\Type\\CheckboxType') {
                 isValueNull = value === null;
-            } else if (element.type === constant('\\Shopsys\\FrameworkBundle\\Form\\SingleCheckboxChoiceType::class')) {
+            } else if (element.type === 'Shopsys\\FrameworkBundle\\Form\\SingleCheckboxChoiceType') {
                 isValueNull = true;
                 for (const i in value) {
                     if (value.hasOwnProperty(i) && value[i] === true) {
diff --git a/assets/js/common/validation/customizeBundle.js b/assets/js/common/validation/customizeBundle.js
@@ -1,5 +1,4 @@
 import { highlightSubmitButtons, findElementsToHighlight } from './validationHelpers';
-import constant from '../../admin/utils/constant';
 import Timeout from '../utils/Timeout';
 import Window from '../../admin/utils/Window';
 import Translator from 'bazinga-translator';
@@ -18,7 +17,7 @@ export default class CustomizeBundle {
 
     static ckeditorValidationInit (element) {
         $.each(element.children, function (index, childElement) {
-            if (childElement.type === constant('\\FOS\\CKEditorBundle\\Form\\Type\\CKEditorType::class')
+            if (childElement.type === 'FOS\\CKEditorBundle\\Form\\Type\\CKEditorType'
                 && CKEDITOR.instances[childElement.id]
             ) {
                 CKEDITOR.instances[childElement.id].on('change', function () {
@@ -179,7 +178,7 @@ export default class CustomizeBundle {
     }
 
     static isExpandedChoiceFormType (element, value) {
-        return element.type === constant('\\Symfony\\Component\\Form\\Extension\\Core\\Type\\ChoiceType::class') && $.isArray(value);
+        return element.type === 'Symfony\\Component\\Form\\Extension\\Core\\Type\\ChoiceType' && $.isArray(value);
     }
 
     static isExpandedChoiceEmpty (value) {
diff --git a/assets/js/common/validation/customizeFpValidator.js b/assets/js/common/validation/customizeFpValidator.js

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`import 'select2/dist/js/select2.full';`
`2`	`2`	`import Ajax from '../../common/utils/Ajax';`
`3`	`3`	`import Register from '../../common/utils/Register';`
`4`		`-import constant from '../utils/constant';`
`5`	`4`
`6`	`5`	`export default class AdvancedSearch {`
`7`	`6`
`@@ -71,7 +70,7 @@ export default class AdvancedSearch {`
`71`	`70`	`}`
`72`	`71`
`73`	`72`	`static updateValueByOperator ($rulesContainer, $rule, operator) {`
`74`		`- $rule.find('.js-advanced-search-rule-value').toggle(operator !== constant('\\Shopsys\\FrameworkBundle\\Model\\AdvancedSearch\\AdvancedSearchFilterInterface::OPERATOR_NOT_SET'));`
	`73`	`+ $rule.find('.js-advanced-search-rule-value').toggle(operator !== 'notSet');`
`75`	`74`	`}`
`76`	`75`
`77`	`76`	`static init ($container) {`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export const VALIDATION_GROUP_DEFAULT = 'Default';`