ChoiceType values are not translated by default (#3859)

Author: grossmannmartin

src/Form/Admin/Advert/AdvertFormType.php

@@ -87,7 +87,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                     t('HTML code') => Advert::TYPE_CODE,
                     t('Image with link') => Advert::TYPE_IMAGE,
                 ],
-                'choice_translation_domain' => false,
                 'expanded' => true,
                 'multiple' => false,
                 'constraints' => [

src/Form/Admin/Article/ArticleFormType.php

@@ -111,7 +111,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                     t('Site') => Article::TYPE_SITE,
                     t('Link') => Article::TYPE_LINK,
                 ],
-                'choice_translation_domain' => false,
                 'expanded' => true,
                 'multiple' => false,
                 'label' => t('Type'),

src/Form/Admin/Category/CategoryFormType.php

@@ -152,7 +152,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 'required' => false,
                 'multiple' => true,
                 'expanded' => true,
-                'choice_translation_domain' => false,
                 'choices' => $this->categoryAutomatedFilterFacade->getAllValuesIndexedByLabel(),
                 'choice_attr' => function ($choice, $key, $value) use ($categoryAutomatedFiltersNotesIndexedByValue) {
                     $iconTitle = $categoryAutomatedFiltersNotesIndexedByValue[$value] ?? null;

src/Form/Admin/Complaint/ComplaintFormType.php

@@ -145,7 +145,6 @@ private function createBasicInformationGroup(
                 'label' => t('Resolution'),
                 'required' => true,
                 'choices' => $this->complaintResolutionEnum->getAllIndexedByTranslations(),
-                'choice_translation_domain' => false,
                 'multiple' => false,
                 'expanded' => false,
                 'attr' => [

src/Form/Admin/Customer/RoleGroup/CustomerUserRoleGroupFormType.php

@@ -50,7 +50,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             'multiple' => true,
             'expanded' => true,
             'choices' => $this->customerUserRole->getAvailableRoles(),
-            'choice_translation_domain' => false,
         ]);
 
         $builder->add('actionBar', ActionBarType::class, [

src/Form/Admin/PriceList/ImportPriceListFormType.php

@@ -51,7 +51,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 'choices' => $this->priceListFacade->getAll(),
                 'choice_label' => 'name',
                 'choice_value' => 'id',
-                'choice_translation_domain' => false,
                 'group_by' => function (PriceList $priceList) {
                     return $this->domain->getDomainConfigById($priceList->getDomainId())->getName();
                 },

src/Form/Admin/PromoCode/PromoCodeFlagType.php

@@ -50,7 +50,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 t('Products with this flag') => PromoCodeFlag::TYPE_INCLUSIVE,
                 t('Products without this flag') => PromoCodeFlag::TYPE_EXCLUSIVE,
             ],
-            'choice_translation_domain' => false,
             'expanded' => true,
             'multiple' => false,
             'constraints' => [

src/Form/Admin/PromoCode/PromoCodeFormType.php

@@ -125,7 +125,6 @@ private function buildBaseGroup(FormBuilderInterface $builder): void
                 'expanded' => true,
                 'multiple' => false,
                 'choices' => $this->promoCodeTypeEnum->getAllIndexedByTranslations(),
-                'choice_translation_domain' => false,
                 'label' => t('Discount type'),
                 'attr' => [
                     'class' => 'js-promo-code-discount-type',

src/Form/ChoiceTypeExtension.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Shopsys\FrameworkBundle\Form;
+
+use Override;
+use Symfony\Component\Form\AbstractTypeExtension;
+use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
+use Symfony\Component\OptionsResolver\OptionsResolver;
+
+class ChoiceTypeExtension extends AbstractTypeExtension
+{
+    /**
+     * @param \Symfony\Component\OptionsResolver\OptionsResolver $resolver
+     */
+    #[Override]
+    public function configureOptions(OptionsResolver $resolver): void
+    {
+        $resolver->setDefaults([
+            'choice_translation_domain' => false,
+        ]);
+    }
+
+    /**
+     * @return iterable
+     */
+    #[Override]
+    public static function getExtendedTypes(): iterable
+    {
+        yield ChoiceType::class;
+    }
+}