Merge pull request #63 from shopware/fix-double-slash

fix: remove double slash from url

Author: Gaitholabi

src/EventListener/BeforeRegistrationStartsListener.php

@@ -33,9 +33,10 @@ public function __invoke(BeforeRegistrationStartsEvent $event): void
         }
 
         $shop = $event->getShop();
+        $url = rtrim($shop->getShopUrl(), '/');
 
         try {
-            $this->httpClient->request('HEAD', sprintf("%s/api/_info/config", $shop->getShopUrl()), [
+            $this->httpClient->request('HEAD', sprintf("%s/api/_info/config", $url), [
                 'timeout' => 10,
                 'max_redirects' => 0,
             ]);
@@ -44,7 +45,7 @@ public function __invoke(BeforeRegistrationStartsEvent $event): void
                 return;
             }
 
-            throw new ShopURLIsNotReachableException($shop->getShopUrl(), $e);
+            throw new ShopURLIsNotReachableException($url, $e);
         }
     }
 }

tests/EventListener/BeforeRegistrationStartsListenerTest.php

@@ -91,7 +91,7 @@ public function testListenerMustThrowExceptionBecauseTheShopURLIsNotReachable():
 
         $shop = $this->createMock(ShopInterface::class);
         $shop
-            ->expects(self::exactly(2))
+            ->expects(self::once())
             ->method('getShopUrl')
             ->willReturn('https://shop-url.com');
 
@@ -124,7 +124,7 @@ public function testListenerMustThrowExceptionBecauseTheShopURLRedirectsToAnothe
 
         $shop = $this->createMock(ShopInterface::class);
         $shop
-            ->expects(self::exactly(2))
+            ->expects(self::once())
             ->method('getShopUrl')
             ->willReturn('https://shop-url.com');
 
@@ -150,6 +150,35 @@ public function testListenerMustThrowExceptionBecauseTheShopURLRedirectsToAnothe
         );
     }
 
+    public function testRequestSentWithoutDoubleBackslash()
+    {
+        $shop = $this->createMock(ShopInterface::class);
+        $shop
+            ->expects(self::once())
+            ->method('getShopUrl')
+            ->willReturn('https://shop-url.com/');
+
+        $this->httpClient
+            ->expects(self::once())
+            ->method('request')
+            ->with('HEAD', 'https://shop-url.com/api/_info/config', [
+                'timeout' => 10,
+                'max_redirects' => 0,
+            ]);
+
+        $listener = new BeforeRegistrationStartsListener(
+            $this->httpClient,
+            true
+        );
+
+        $listener->__invoke(
+            new BeforeRegistrationStartsEvent(
+                $this->createMock(RequestInterface::class),
+                $shop
+            )
+        );
+    }
+
     #[DataProvider('unauthorizedHttpExceptionProvider')]
     public function testListenerDoesNotThrowExceptionWhenTheExceptionCodeIsHTTPUnauthorized($exception): void
     {