fix: bc

Author: cyl3x

src/Response/PaymentResponse.php

@@ -98,11 +98,19 @@ public static function createStatusResponse(string $status, string $message = ''
     }
 
     /**
-     * @param self::ACTION_*|'' $status
+     * @deprecated tag:v5.0.0 - Will be removed and is replaced by {@see self::redirectUrl}
      */
-    public static function redirect(string $url, string $status = ''): ResponseInterface
+    public static function redirect(string $url): ResponseInterface
     {
-        return self::createResponse(array_filter(['redirectUrl' => $url, 'status' => $status]));
+        return self::createResponse(['redirectUrl' => $url]);
+    }
+
+    /**
+     * @param self::ACTION_* $status
+     */
+    public static function redirectUrl(string $status, string $url): ResponseInterface
+    {
+        return self::createResponse(array_filter(['status' => $status, 'redirectUrl' => $url]));
     }
 
     /**

tests/Response/PaymentResponseTest.php

@@ -123,6 +123,9 @@ public function testValidateError(): void
         static::assertSame('{"message":"error"}', $response->getBody()->getContents());
     }
 
+    /**
+     * @deprecated tag:v5.0.0 - Will be removed
+     */
     public function testRedirect(): void
     {
         $response = PaymentResponse::redirect('https://example.com');
@@ -131,11 +134,11 @@ public function testRedirect(): void
         static::assertSame('{"redirectUrl":"https:\/\/example.com"}', $response->getBody()->getContents());
     }
 
-    public function testRedirectWithStatus(): void
+    public function testRedirectUrl(): void
     {
-        $response = PaymentResponse::redirect('https://example.com', PaymentResponse::ACTION_PROCESS);
+        $response = PaymentResponse::redirectUrl(PaymentResponse::ACTION_PROCESS, 'https://example.com');
 
         static::assertSame(200, $response->getStatusCode());
-        static::assertSame('{"redirectUrl":"https:\/\/example.com","status":"process"}', $response->getBody()->getContents());
+        static::assertSame('{"status":"process","redirectUrl":"https:\/\/example.com"}', $response->getBody()->getContents());
     }
 }