Skip to content

Commit 5e02e38

Browse files
batazorbatazor
committed
improve observability
1 parent 29e25b3 commit 5e02e38

File tree

7 files changed

+145
-168
lines changed

7 files changed

+145
-168
lines changed

‎boundaries/link/go.mod‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,24 @@ require (
1919
github.com/prometheus/client_golang v1.23.2
2020
github.com/redis/rueidis v1.0.68
2121
github.com/segmentio/encoding v0.5.3
22-
github.com/shortlink-org/go-sdk/auth v0.0.0-20251129215632-4fad40209522
23-
github.com/shortlink-org/go-sdk/batch v0.0.0-20251129215632-4fad40209522
24-
github.com/shortlink-org/go-sdk/cache v0.0.0-20251129215632-4fad40209522
25-
github.com/shortlink-org/go-sdk/config v0.0.0-20251129215632-4fad40209522
26-
github.com/shortlink-org/go-sdk/context v0.0.0-20251129215632-4fad40209522
27-
github.com/shortlink-org/go-sdk/cqrs v0.0.0-20251129215632-4fad40209522
28-
github.com/shortlink-org/go-sdk/db v0.0.0-20251129215632-4fad40209522
29-
github.com/shortlink-org/go-sdk/flags v0.0.0-20251129215632-4fad40209522
30-
github.com/shortlink-org/go-sdk/flight_trace v0.0.0-20251129215632-4fad40209522
31-
github.com/shortlink-org/go-sdk/graceful_shutdown v0.0.0-20251129215632-4fad40209522
32-
github.com/shortlink-org/go-sdk/grpc v0.0.0-20251129215632-4fad40209522
33-
github.com/shortlink-org/go-sdk/http v0.0.0-20251129215632-4fad40209522
34-
github.com/shortlink-org/go-sdk/kratos v0.0.0-20251129215632-4fad40209522
35-
github.com/shortlink-org/go-sdk/logger v0.0.0-20251129215632-4fad40209522
36-
github.com/shortlink-org/go-sdk/observability v0.0.0-20251129215632-4fad40209522
37-
github.com/shortlink-org/go-sdk/saga v0.0.0-20251129215632-4fad40209522
38-
github.com/shortlink-org/go-sdk/specification v0.0.0-20251129215632-4fad40209522
39-
github.com/shortlink-org/go-sdk/watermill v0.0.0-20251129215632-4fad40209522
22+
github.com/shortlink-org/go-sdk/auth v0.0.0-20251203170842-4c6548ea718b
23+
github.com/shortlink-org/go-sdk/batch v0.0.0-20251203170842-4c6548ea718b
24+
github.com/shortlink-org/go-sdk/cache v0.0.0-20251203170842-4c6548ea718b
25+
github.com/shortlink-org/go-sdk/config v0.0.0-20251203170842-4c6548ea718b
26+
github.com/shortlink-org/go-sdk/context v0.0.0-20251203170842-4c6548ea718b
27+
github.com/shortlink-org/go-sdk/cqrs v0.0.0-20251203170842-4c6548ea718b
28+
github.com/shortlink-org/go-sdk/db v0.0.0-20251203170842-4c6548ea718b
29+
github.com/shortlink-org/go-sdk/flags v0.0.0-20251203170842-4c6548ea718b
30+
github.com/shortlink-org/go-sdk/flight_trace v0.0.0-20251203170842-4c6548ea718b
31+
github.com/shortlink-org/go-sdk/graceful_shutdown v0.0.0-20251203170842-4c6548ea718b
32+
github.com/shortlink-org/go-sdk/grpc v0.0.0-20251203170842-4c6548ea718b
33+
github.com/shortlink-org/go-sdk/http v0.0.0-20251203170842-4c6548ea718b
34+
github.com/shortlink-org/go-sdk/kratos v0.0.0-20251203170842-4c6548ea718b
35+
github.com/shortlink-org/go-sdk/logger v0.0.0-20251203170842-4c6548ea718b
36+
github.com/shortlink-org/go-sdk/observability v0.0.0-20251203170842-4c6548ea718b
37+
github.com/shortlink-org/go-sdk/saga v0.0.0-20251203170842-4c6548ea718b
38+
github.com/shortlink-org/go-sdk/specification v0.0.0-20251203170842-4c6548ea718b
39+
github.com/shortlink-org/go-sdk/watermill v0.0.0-20251203170842-4c6548ea718b
4040
github.com/spf13/viper v1.21.0
4141
github.com/stretchr/testify v1.11.1
4242
github.com/syndtr/goleveldb v1.0.1-0.20220721030215-126854af5e6d
@@ -171,7 +171,7 @@ require (
171171
github.com/prometheus/otlptranslator v1.0.0 // indirect
172172
github.com/prometheus/procfs v0.19.2 // indirect
173173
github.com/rcrowley/go-metrics v0.0.0-20250401214520-65e299d6c5c9 // indirect
174-
github.com/redis/go-redis/v9 v9.17.0 // indirect
174+
github.com/redis/go-redis/v9 v9.17.2 // indirect
175175
github.com/redis/rueidis/rueidiscompat v1.0.68 // indirect
176176
github.com/redis/rueidis/rueidisotel v1.0.68 // indirect
177177
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect

‎boundaries/link/go.sum‎

Lines changed: 38 additions & 38 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎boundaries/link/internal/usecases/link/add.go‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ func (uc *UC) Add(ctx context.Context, in *domain.Link) (*domain.Link, error) {
7777
return err
7878
}
7979

80-
span.SetStatus(otelcodes.Ok, "Link saved to store successfully")
8180
return nil
8281
}).Build()
8382
if err := errorHelper(ctx, uc.log, errs); err != nil {
@@ -132,13 +131,10 @@ func (uc *UC) Add(ctx context.Context, in *domain.Link) (*domain.Link, error) {
132131
case codes.AlreadyExists:
133132
span.SetAttributes(attribute.Bool("permission.already_exists", true))
134133
span.AddEvent("permission relationship already existed")
135-
span.SetStatus(otelcodes.Ok, "relationship already exists")
136134

137135
return nil
138136
default:
139137
if int32(st.Code()) == int32(permission.ErrorReason_ERROR_REASON_TOO_MANY_PRECONDITIONS_IN_REQUEST) {
140-
span.SetStatus(otelcodes.Ok, "skipped: too many preconditions")
141-
142138
return nil
143139
}
144140
}
@@ -157,7 +153,6 @@ func (uc *UC) Add(ctx context.Context, in *domain.Link) (*domain.Link, error) {
157153
attribute.Bool("permission.already_exists", false),
158154
attribute.String("grpc.code", codes.OK.String()),
159155
)
160-
span.SetStatus(otelcodes.Ok, "relationship created")
161156

162157
return nil
163158
}).Reject(func(ctx context.Context, thenErr error) error {

‎boundaries/metadata/go.mod‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,22 @@ require (
1010
github.com/chromedp/chromedp v0.14.2
1111
github.com/google/wire v0.7.0
1212
github.com/minio/minio-go/v7 v7.0.97
13-
github.com/shortlink-org/go-sdk/auth v0.0.0-20251129215632-4fad40209522
14-
github.com/shortlink-org/go-sdk/cache v0.0.0-20251129215632-4fad40209522
15-
github.com/shortlink-org/go-sdk/config v0.0.0-20251129215632-4fad40209522
16-
github.com/shortlink-org/go-sdk/context v0.0.0-20251129215632-4fad40209522
17-
github.com/shortlink-org/go-sdk/cqrs v0.0.0-20251129215632-4fad40209522
18-
github.com/shortlink-org/go-sdk/db v0.0.0-20251129215632-4fad40209522
19-
github.com/shortlink-org/go-sdk/flags v0.0.0-20251129215632-4fad40209522
20-
github.com/shortlink-org/go-sdk/flight_trace v0.0.0-20251129215632-4fad40209522
21-
github.com/shortlink-org/go-sdk/graceful_shutdown v0.0.0-20251129215632-4fad40209522
22-
github.com/shortlink-org/go-sdk/grpc v0.0.0-20251129215632-4fad40209522
23-
github.com/shortlink-org/go-sdk/http v0.0.0-20251129215632-4fad40209522
24-
github.com/shortlink-org/go-sdk/logger v0.0.0-20251129215632-4fad40209522
25-
github.com/shortlink-org/go-sdk/observability v0.0.0-20251129215632-4fad40209522
26-
github.com/shortlink-org/go-sdk/s3 v0.0.0-20251129215632-4fad40209522
27-
github.com/shortlink-org/go-sdk/saga v0.0.0-20251129215632-4fad40209522
28-
github.com/shortlink-org/go-sdk/watermill v0.0.0-20251129215632-4fad40209522
13+
github.com/shortlink-org/go-sdk/auth v0.0.0-20251203170842-4c6548ea718b
14+
github.com/shortlink-org/go-sdk/cache v0.0.0-20251203170842-4c6548ea718b
15+
github.com/shortlink-org/go-sdk/config v0.0.0-20251203170842-4c6548ea718b
16+
github.com/shortlink-org/go-sdk/context v0.0.0-20251203170842-4c6548ea718b
17+
github.com/shortlink-org/go-sdk/cqrs v0.0.0-20251203170842-4c6548ea718b
18+
github.com/shortlink-org/go-sdk/db v0.0.0-20251203170842-4c6548ea718b
19+
github.com/shortlink-org/go-sdk/flags v0.0.0-20251203170842-4c6548ea718b
20+
github.com/shortlink-org/go-sdk/flight_trace v0.0.0-20251203170842-4c6548ea718b
21+
github.com/shortlink-org/go-sdk/graceful_shutdown v0.0.0-20251203170842-4c6548ea718b
22+
github.com/shortlink-org/go-sdk/grpc v0.0.0-20251203170842-4c6548ea718b
23+
github.com/shortlink-org/go-sdk/http v0.0.0-20251203170842-4c6548ea718b
24+
github.com/shortlink-org/go-sdk/logger v0.0.0-20251203170842-4c6548ea718b
25+
github.com/shortlink-org/go-sdk/observability v0.0.0-20251203170842-4c6548ea718b
26+
github.com/shortlink-org/go-sdk/s3 v0.0.0-20251203170842-4c6548ea718b
27+
github.com/shortlink-org/go-sdk/saga v0.0.0-20251203170842-4c6548ea718b
28+
github.com/shortlink-org/go-sdk/watermill v0.0.0-20251203170842-4c6548ea718b
2929
github.com/spf13/viper v1.21.0
3030
github.com/stretchr/testify v1.11.1
3131
github.com/testcontainers/testcontainers-go v0.40.0
@@ -158,7 +158,7 @@ require (
158158
github.com/prometheus/otlptranslator v1.0.0 // indirect
159159
github.com/prometheus/procfs v0.19.2 // indirect
160160
github.com/rcrowley/go-metrics v0.0.0-20250401214520-65e299d6c5c9 // indirect
161-
github.com/redis/go-redis/v9 v9.17.0 // indirect
161+
github.com/redis/go-redis/v9 v9.17.2 // indirect
162162
github.com/redis/rueidis v1.0.68 // indirect
163163
github.com/redis/rueidis/rueidiscompat v1.0.68 // indirect
164164
github.com/redis/rueidis/rueidisotel v1.0.68 // indirect

0 commit comments

Comments
 (0)