Skip to content

Commit c9bb6bf

Browse files
czentgrshrinidhijoshi
authored andcommitted
[native] Fix incorrect exclusion of PrestoC++ unit tests
The regex used int he CTest command to run tests excludes tests with “velox” in the name leading to skipped tests such as presto_to_velox_query_plan_test and others. This results in missing coverage and non-detection of introduced issues.
1 parent 6f41628 commit c9bb6bf

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/prestocpp-linux-build-and-unit-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ jobs:
117117
# Ensure transitive dependency libboost-iostreams is found.
118118
ldconfig /usr/local/lib
119119
cd presto-native-execution/_build/release
120-
ctest -j 4 -VV --output-on-failure --exclude-regex velox.*
120+
ctest -j 4 -VV --output-on-failure --exclude-regex ^velox.*
121121
122122
- name: Upload artifacts
123123
if: |

presto-native-execution/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ cmake-and-build: #: cmake and build without updating submodules which requires
119119
cmake --build $(BUILD_BASE_DIR)/$(BUILD_DIR) -j $(NUM_THREADS)
120120

121121
unittest: debug #: Build with debugging and run unit tests
122-
cd $(BUILD_BASE_DIR)/debug && ctest -j $(NUM_THREADS) -VV --output-on-failure --exclude-regex velox.*
122+
cd $(BUILD_BASE_DIR)/debug && ctest -j $(NUM_THREADS) -VV --output-on-failure --exclude-regex ^velox.*
123123

124124
presto_protocol: #: Build the presto_protocol serde library
125125
cd presto_cpp/presto_protocol; $(MAKE) presto_protocol

0 commit comments

Comments
 (0)