chore: refine cmake

Author: shuai132

CMakeLists.txt

@@ -11,21 +11,21 @@ else ()
     add_compile_options(-Wall -Wunused-parameter)
 endif ()
 
-option(CORO_DISABLE_EXCEPTION "" OFF)
-option(CORO_ENABLE_LOCAL_STORAGE "" OFF)
+option(CORO_DISABLE_EXCEPTION "Disable C++ exceptions" OFF)
+option(CORO_ENABLE_LOCAL_STORAGE "Enable coroutine local storage" OFF)
 
 add_library(${PROJECT_NAME} INTERFACE)
 target_include_directories(${PROJECT_NAME} INTERFACE include)
 
 if (CORO_DISABLE_EXCEPTION)
-    add_definitions(-DCORO_DISABLE_EXCEPTION)
+    target_compile_definitions(${PROJECT_NAME} INTERFACE CORO_DISABLE_EXCEPTION)
 endif ()
 if (CORO_ENABLE_LOCAL_STORAGE)
-    add_definitions(-CORO_ENABLE_LOCAL_STORAGE)
+    target_compile_definitions(${PROJECT_NAME} INTERFACE CORO_ENABLE_LOCAL_STORAGE)
 endif ()
 
-# test
-option(CORO_BUILD_TEST "" OFF)
+# Test
+option(CORO_BUILD_TEST "Build tests" OFF)
 if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
     set(CORO_BUILD_TEST ON)
 endif ()
@@ -37,44 +37,43 @@ if (CORO_BUILD_TEST)
     # github actions runner of macOS is very slow
     if ($ENV{GITHUB_ACTIONS} AND $ENV{RUNNER_OS} STREQUAL "macOS")
         set(CORO_TEST_RUNNER_VERY_SLOW ON)
-        add_definitions(-DCORO_TEST_RUNNER_VERY_SLOW)
+        add_compile_definitions(CORO_TEST_RUNNER_VERY_SLOW)
     endif ()
 
     if (CORO_ENABLE_SANITIZE_ADDRESS)
-        set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address")
-        set(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address")
+        add_compile_options(-fsanitize=address)
+        add_link_options(-fsanitize=address)
     endif ()
     if (CORO_ENABLE_SANITIZE_THREAD)
-        set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=thread")
-        set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=thread")
+        add_compile_options(-fsanitize=thread)
+        add_link_options(-fsanitize=thread)
     endif ()
+
     if (CORO_DISABLE_EXCEPTION)
         if (MSVC)
             # MSVC: Remove default exception handling flags and add disable flags
             string(REPLACE "/EHsc" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
             string(REPLACE "/EHs" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
             string(REPLACE "/EHc" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
             add_compile_options(/EHs-c-)
-            add_definitions(-D_HAS_EXCEPTIONS=0)
+            add_compile_definitions(_HAS_EXCEPTIONS=0)
         else ()
             # GCC/Clang
             add_compile_options(-fno-exceptions)
         endif ()
     endif ()
 
     include_directories(test/detail)
-
-    file(GLOB SRCS test/coro_task.cpp)
     link_libraries(${PROJECT_NAME})
 
     # test task
     set(TARGET_NAME ${PROJECT_NAME}_task)
-    add_executable(${TARGET_NAME} ${SRCS})
+    add_executable(${TARGET_NAME} test/coro_task.cpp)
 
     # test task verbose
     set(TARGET_NAME ${PROJECT_NAME}_task_verbose)
-    add_executable(${TARGET_NAME} ${SRCS})
-    target_compile_definitions(${TARGET_NAME} PUBLIC -DCORO_DEBUG_LEAK_LOG=LOG -DCORO_DEBUG_LIFECYCLE=LOG)
+    add_executable(${TARGET_NAME} test/coro_task.cpp)
+    target_compile_definitions(${TARGET_NAME} PUBLIC CORO_DEBUG_LEAK_LOG=LOG CORO_DEBUG_LIFECYCLE=LOG)
 
     # test mutex
     set(TARGET_NAME ${PROJECT_NAME}_mutex)
@@ -131,25 +130,24 @@ if (CORO_BUILD_TEST)
     # test multi thread(use single thread)
     set(TARGET_NAME ${PROJECT_NAME}_multi_thread_st)
     add_executable(${TARGET_NAME} test/coro_multi_thread.cpp)
-    target_compile_definitions(${TARGET_NAME} PRIVATE -DCORO_USE_SINGLE_THREAD)
+    target_compile_definitions(${TARGET_NAME} PRIVATE CORO_USE_SINGLE_THREAD)
 
     # test coro_local (requires CORO_ENABLE_LOCAL_STORAGE)
     set(TARGET_NAME ${PROJECT_NAME}_coro_local)
     add_executable(${TARGET_NAME} test/coro_local.cpp)
-    target_compile_definitions(${TARGET_NAME} PRIVATE -DCORO_ENABLE_LOCAL_STORAGE)
+    target_compile_definitions(${TARGET_NAME} PRIVATE CORO_ENABLE_LOCAL_STORAGE)
 
     message(STATUS "ASIO_PATH: $ENV{ASIO_PATH}")
-    # test asio adaptor (optional, requires asio)
+    # test asio adaptor (optional, requires asio and exceptions enabled)
     set(TARGET_NAME ${PROJECT_NAME}_asio_adaptor)
     if (NOT "$ENV{ASIO_PATH}" STREQUAL "" AND NOT CORO_DISABLE_EXCEPTION)
-        if (MINGW)
-            add_compile_options(-D_WIN32_WINNT=0x0601)
-            link_libraries(ws2_32 wsock32)
-        endif ()
-
-        add_definitions(-DASIO_NO_DEPRECATED)
         add_executable(${TARGET_NAME} test/coro_asio_adaptor.cpp)
         target_include_directories(${TARGET_NAME} PRIVATE $ENV{ASIO_PATH})
+        target_compile_definitions(${TARGET_NAME} PRIVATE ASIO_NO_DEPRECATED)
+        if (MINGW)
+            target_compile_definitions(${TARGET_NAME} PRIVATE _WIN32_WINNT=0x0601)
+            target_link_libraries(${TARGET_NAME} PRIVATE ws2_32 wsock32)
+        endif ()
     else ()
         add_executable(${TARGET_NAME} test/coro_empty.cpp)
     endif ()