Remove unused Pexp_unreachable and Texp_unreachable.

Author: cristianoc

analysis/reanalyze/src/Arnold.ml

@@ -998,9 +998,6 @@ module Compile = struct
     | Texp_pack _ ->
       notImplemented "Texp_pack";
       assert false
-    | Texp_unreachable ->
-      notImplemented "Texp_unreachable";
-      assert false
     | Texp_extension_constructor _ when true ->
       notImplemented "Texp_extension_constructor";
       assert false

analysis/reanalyze/src/SideEffects.ml

@@ -67,7 +67,6 @@ let rec exprNoSideEffects (expr : Typedtree.expression) =
   | Texp_override _ -> false
   | Texp_letexception (_ec, e) -> e |> exprNoSideEffects
   | Texp_pack _ -> false
-  | Texp_unreachable -> false
   | Texp_extension_constructor _ when true -> true
   | _ -> (* on ocaml 4.08: Texp_letop | Texp_open *) true
 

analysis/src/Utils.ml

@@ -116,7 +116,6 @@ let identifyPexp pexp =
   | Pexp_pack _ -> "Pexp_pack"
   | Pexp_extension _ -> "Pexp_extension"
   | Pexp_open _ -> "Pexp_open"
-  | Pexp_unreachable -> "Pexp_unreachable"
 
 let identifyPpat pat =
   match pat with

compiler/frontend/bs_ast_mapper.ml

@@ -376,7 +376,6 @@ module E = struct
     | Pexp_open (ovf, lid, e) ->
       open_ ~loc ~attrs ovf (map_loc sub lid) (sub.expr sub e)
     | Pexp_extension x -> extension ~loc ~attrs (sub.extension sub x)
-    | Pexp_unreachable -> unreachable ~loc ~attrs ()
 end
 
 module P = struct

compiler/ml/ast_helper.ml

@@ -181,7 +181,6 @@ module Exp = struct
   let pack ?loc ?attrs a = mk ?loc ?attrs (Pexp_pack a)
   let open_ ?loc ?attrs a b c = mk ?loc ?attrs (Pexp_open (a, b, c))
   let extension ?loc ?attrs a = mk ?loc ?attrs (Pexp_extension a)
-  let unreachable ?loc ?attrs () = mk ?loc ?attrs Pexp_unreachable
 
   let case lhs ?guard rhs = {pc_lhs = lhs; pc_guard = guard; pc_rhs = rhs}
 end

compiler/ml/ast_helper.mli

@@ -202,7 +202,6 @@ module Exp : sig
   val open_ :
     ?loc:loc -> ?attrs:attrs -> override_flag -> lid -> expression -> expression
   val extension : ?loc:loc -> ?attrs:attrs -> extension -> expression
-  val unreachable : ?loc:loc -> ?attrs:attrs -> unit -> expression
 
   val case : pattern -> ?guard:expression -> expression -> case
 end

compiler/ml/ast_iterator.ml

@@ -358,7 +358,6 @@ module E = struct
       iter_loc sub lid;
       sub.expr sub e
     | Pexp_extension x -> sub.extension sub x
-    | Pexp_unreachable -> ()
 end
 
 module P = struct

compiler/ml/ast_mapper.ml

@@ -339,7 +339,6 @@ module E = struct
     | Pexp_open (ovf, lid, e) ->
       open_ ~loc ~attrs ovf (map_loc sub lid) (sub.expr sub e)
     | Pexp_extension x -> extension ~loc ~attrs (sub.extension sub x)
-    | Pexp_unreachable -> unreachable ~loc ~attrs ()
 end
 
 module P = struct

compiler/ml/ast_mapper_from0.ml

@@ -347,7 +347,7 @@ module E = struct
     | Pexp_open (ovf, lid, e) ->
       open_ ~loc ~attrs ovf (map_loc sub lid) (sub.expr sub e)
     | Pexp_extension x -> extension ~loc ~attrs (sub.extension sub x)
-    | Pexp_unreachable -> unreachable ~loc ~attrs ()
+    | Pexp_unreachable -> assert false
 end
 
 module P = struct

compiler/ml/ast_mapper_to0.ml

@@ -345,7 +345,6 @@ module E = struct
     | Pexp_open (ovf, lid, e) ->
       open_ ~loc ~attrs ovf (map_loc sub lid) (sub.expr sub e)
     | Pexp_extension x -> extension ~loc ~attrs (sub.extension sub x)
-    | Pexp_unreachable -> unreachable ~loc ~attrs ()
 end
 
 module P = struct