Merge pull request #272 from shurco/271-bug-incorrect-redirect-to-install-page-on-500-errors-when-installing

🐛 fix(api): prevent incorrect redirect to install page on GitHub API …

Author: shurco

internal/handlers/private/setting.go

@@ -33,13 +33,13 @@ func Version(c *fiber.Ctx) error {
 	if err == sql.ErrNoRows {
 		version = update.VersionInfo()
 
+		// Try to fetch latest release, but don't fail if GitHub API is unavailable
 		release, err := update.FetchLatestRelease(context.Background(), "shurco", "litecart")
 		if err != nil {
+			// Log the error but continue without update information
+			// This prevents blocking access when GitHub API is unavailable
 			log.ErrorStack(err)
-			return webutil.StatusInternalServerError(c)
-		}
-
-		if version.CurrentVersion != release.Name {
+		} else if version.CurrentVersion != release.Name {
 			version.NewVersion = release.Name
 			version.ReleaseURL = release.GetUrl()
 		}

web/admin/src/routes/+layout.ts

@@ -37,10 +37,6 @@ export const load: LayoutLoad = async ({ url, fetch }) => {
       if (versionData?.success) {
         isAuthenticated = true
       }
-    } else if (versionResponse.status === 500) {
-      // Server error - likely means app is not installed
-      // Backend should handle this, but for client-side navigation, redirect to install
-      throw redirect(302, `${base}/install`)
     } else if (versionResponse.status === 400 || versionResponse.status === 401 || versionResponse.status === 403) {
       // 400 = missing/malformed token (app installed but not authenticated)
       // 401/403 = unauthorized (app installed but not authenticated)
@@ -72,9 +68,6 @@ export const load: LayoutLoad = async ({ url, fetch }) => {
         // 400 = missing/malformed token (app installed but not authenticated)
         // 401/403 = unauthorized (app installed but not authenticated)
         throw redirect(302, `${base}/signin`)
-      } else if (productsResponse.status === 500) {
-        // Server error - likely means app is not installed
-        throw redirect(302, `${base}/install`)
       }
     } catch (error) {
       // If it's already a redirect, rethrow it