Skip to content

Commit 81e74e9

Browse files
committed
Fix KeyperSetManager.t.sol
1 parent 52bdea6 commit 81e74e9

File tree

1 file changed

+33
-7
lines changed

1 file changed

+33
-7
lines changed

test/KeyperSetManager.t.sol

Lines changed: 33 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ contract KeyperSetManagerTest is Test {
1010
KeyperSet public members0;
1111
KeyperSet public members1;
1212
address public owner;
13-
13+
1414
function setUp() public {
1515
owner = vm.addr(42);
1616
vm.prank(owner);
@@ -26,10 +26,10 @@ contract KeyperSetManagerTest is Test {
2626
function testGetNumKeyperSets() public {
2727
assertEq(keyperSetManager.getNumKeyperSets(), 0);
2828
vm.prank(owner);
29-
keyperSetManager.addKeyperSet(0, address(members0));
29+
keyperSetManager.addKeyperSet(1, address(members0));
3030
assertEq(keyperSetManager.getNumKeyperSets(), 1);
3131
vm.prank(owner);
32-
keyperSetManager.addKeyperSet(1, address(members0));
32+
keyperSetManager.addKeyperSet(2, address(members0));
3333
assertEq(keyperSetManager.getNumKeyperSets(), 2);
3434
}
3535

@@ -39,7 +39,7 @@ contract KeyperSetManagerTest is Test {
3939
abi.encodeWithSelector(
4040
IAccessControl.AccessControlUnauthorizedAccount.selector,
4141
address(1),
42-
keyperSetManager.DEFAULT_ADMIN_ROLE
42+
0
4343
)
4444
);
4545
keyperSetManager.addKeyperSet(0, address(members0));
@@ -48,23 +48,43 @@ contract KeyperSetManagerTest is Test {
4848
function testAddKeyperSetRequiresFinalizedSet() public {
4949
KeyperSet ks = new KeyperSet();
5050
vm.expectRevert(KeyperSetNotFinalized.selector);
51+
vm.prank(owner);
5152
keyperSetManager.addKeyperSet(0, address(ks));
5253
}
5354

5455
function testAddKeyperSetRequiresIncreasingActivationBlock() public {
56+
vm.prank(owner);
5557
keyperSetManager.addKeyperSet(1000, address(members0));
5658
vm.expectRevert(AlreadyHaveKeyperSet.selector);
59+
vm.prank(owner);
5760
keyperSetManager.addKeyperSet(999, address(members1));
61+
vm.prank(owner);
5862
keyperSetManager.addKeyperSet(1000, address(members1));
5963
}
6064

61-
event KeyperSetAdded(uint64 activationSlot, address keyperSetContract);
65+
event KeyperSetAdded(
66+
uint64 activationBlock,
67+
address keyperSetContract,
68+
address[] members,
69+
uint64 threshold,
70+
uint64 eon
71+
);
6272

6373
function testAddKeyperSetEmits() public {
6474
vm.expectEmit(address(keyperSetManager));
65-
emit KeyperSetAdded(1000, address(members0));
75+
address[] memory members;
76+
emit KeyperSetAdded(
77+
1000,
78+
address(members0),
79+
members,
80+
0,
81+
0
82+
);
6683
vm.prank(owner);
67-
keyperSetManager.addKeyperSet(1000, address(members0));
84+
keyperSetManager.addKeyperSet(
85+
1000,
86+
address(members0)
87+
);
6888
}
6989

7090
function testGetKeyperSetIndexByBlockEmpty() public {
@@ -73,7 +93,9 @@ contract KeyperSetManagerTest is Test {
7393
}
7494

7595
function testGetKeyperSetIndexByBlock() public {
96+
vm.prank(owner);
7697
keyperSetManager.addKeyperSet(1000, address(members0));
98+
vm.prank(owner);
7799
keyperSetManager.addKeyperSet(1100, address(members1));
78100

79101
vm.expectRevert(NoActiveKeyperSet.selector);
@@ -90,14 +112,18 @@ contract KeyperSetManagerTest is Test {
90112
}
91113

92114
function testGetKeyperSetActivationBlock() public {
115+
vm.prank(owner);
93116
keyperSetManager.addKeyperSet(1000, address(members0));
117+
vm.prank(owner);
94118
keyperSetManager.addKeyperSet(1100, address(members1));
95119
assertEq(keyperSetManager.getKeyperSetActivationBlock(0), 1000);
96120
assertEq(keyperSetManager.getKeyperSetActivationBlock(1), 1100);
97121
}
98122

99123
function testGetKeyperSetAddress() public {
124+
vm.prank(owner);
100125
keyperSetManager.addKeyperSet(1000, address(members0));
126+
vm.prank(owner);
101127
keyperSetManager.addKeyperSet(1100, address(members1));
102128
assertEq(keyperSetManager.getKeyperSetAddress(0), address(members0));
103129
assertEq(keyperSetManager.getKeyperSetAddress(1), address(members1));

0 commit comments

Comments
 (0)