Skip to content

Commit 026b6a8

Browse files
committed
Use identity from db instea of recomputing
1 parent 38829b5 commit 026b6a8

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

rolling-shutter/keyperimpl/shutterservice/database/shutterservice.sqlc.gen.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rolling-shutter/keyperimpl/shutterservice/database/sql/queries/shutterservice.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ SELECT
142142
f.log_index,
143143
e.eon AS eon,
144144
e.ttl AS ttl,
145+
e.identity AS identity,
145146
e.decrypted AS decrypted
146147
FROM fired_triggers f
147148
INNER JOIN event_trigger_registered_event e ON f.identity_prefix = e.identity_prefix AND f.sender = e.sender

rolling-shutter/keyperimpl/shutterservice/eventtriggerregisteredprocessor.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
package shutterservice
22

33
import (
4+
"bytes"
45
"context"
56
"math"
67

78
"github.com/ethereum/go-ethereum/accounts/abi/bind"
8-
"github.com/ethereum/go-ethereum/common"
9+
"github.com/ethereum/go-ethereum/crypto"
910
"github.com/jackc/pgx/v4"
1011
"github.com/jackc/pgx/v4/pgxpool"
1112
"github.com/pkg/errors"
@@ -73,7 +74,6 @@ func (p *EventTriggerRegisteredEventProcessor) ProcessEvents(ctx context.Context
7374
Hex("definition", registryEvent.TriggerDefinition).
7475
Uint64("ttl", registryEvent.Ttl).
7576
Logger()
76-
evLog.Debug().Msg("processing event trigger registered event")
7777

7878
if registryEvent.Eon > math.MaxInt64 {
7979
evLog.Info().Msg("skipping event trigger registered event with Eon > math.MaxInt64")
@@ -101,7 +101,7 @@ func (p *EventTriggerRegisteredEventProcessor) ProcessEvents(ctx context.Context
101101
Sender: shdb.EncodeAddress(registryEvent.Sender),
102102
Definition: registryEvent.TriggerDefinition,
103103
Ttl: int64(registryEvent.Ttl),
104-
Identity: computeEventTriggerIdentity(registryEvent.IdentityPrefix, registryEvent.Sender),
104+
Identity: computeEventTriggerIdentity(registryEvent),
105105
})
106106
if err != nil {
107107
return errors.Wrap(err, "failed to insert event trigger registered event into db")
@@ -120,6 +120,9 @@ func (p *EventTriggerRegisteredEventProcessor) RollbackEvents(ctx context.Contex
120120
return nil
121121
}
122122

123-
func computeEventTriggerIdentity(identityPrefix common.Hash, sender common.Address) []byte {
124-
return append(identityPrefix[:], sender[:]...)
123+
func computeEventTriggerIdentity(event *triggerRegistryBindings.ShuttereventtriggerregistryEventTriggerRegistered) []byte {
124+
var buf bytes.Buffer
125+
buf.Write(event.IdentityPrefix[:])
126+
buf.Write(event.Sender.Bytes())
127+
return crypto.Keccak256(buf.Bytes())
125128
}

rolling-shutter/keyperimpl/shutterservice/newblock.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -225,11 +225,7 @@ func (kpr *Keyper) prepareEventBasedTriggers(ctx context.Context) ([]epochkghand
225225

226226
identities := []identitypreimage.IdentityPreimage{}
227227
for _, firedTrigger := range firedTriggers {
228-
identity, err := computeIdentityForFiredTrigger(&firedTrigger)
229-
if err != nil {
230-
return nil, errors.Wrapf(err, "failed to compute identity for fired trigger %v", firedTrigger)
231-
}
232-
identities = append(identities, identity)
228+
identities = append(identities, firedTrigger.Identity)
233229
}
234230

235231
decryptionTrigger := epochkghandler.DecryptionTrigger{

0 commit comments

Comments
 (0)