Fix outdated tx pointer issue

See #449

Author: jannikluhn

rolling-shutter/keyperimpl/gnosis/database/gnosiskeyper.sqlc.gen.go

@@ -43,20 +43,25 @@ SELECT * FROM tx_pointer
 WHERE eon = $1;
 
 -- name: InitTxPointer :exec
-INSERT INTO tx_pointer (eon, slot, value)
-VALUES ($1, $2, 0)
+INSERT INTO tx_pointer (eon, age, value)
+VALUES ($1, $2, $3)
 ON CONFLICT DO NOTHING;
 
 -- name: SetTxPointer :exec
-INSERT INTO tx_pointer (eon, slot, value)
+INSERT INTO tx_pointer (eon, age, value)
 VALUES ($1, $2, $3)
 ON CONFLICT (eon) DO UPDATE
-SET slot = $2, value = $3;
+SET age = $2, value = $3;
 
--- name: SetTxPointerSlot :exec
+-- name: IncrementTxPointerAge :one
 UPDATE tx_pointer
-SET slot = $2
-WHERE eon = $1;
+SET age = age + 1
+WHERE eon = $1
+RETURNING age;
+
+-- name: ResetAllTxPointerAges :exec
+UPDATE tx_pointer
+SET age = NULL;
 
 -- name: SetCurrentDecryptionTrigger :exec
 INSERT INTO current_decryption_trigger (eon, slot, tx_pointer, identities_hash)

rolling-shutter/keyperimpl/gnosis/database/models.sqlc.gen.go

@@ -29,7 +29,7 @@ CREATE TABLE transaction_submitted_event_count(
 
 CREATE TABLE tx_pointer(
     eon bigint PRIMARY KEY,
-    slot bigint NOT NULL DEFAULT 0,
+    age bigint,
     value bigint NOT NULL DEFAULT 0
 );
 

rolling-shutter/keyperimpl/gnosis/database/sql/queries/gnosiskeyper.sql

@@ -2,6 +2,7 @@ package gnosis
 
 import (
 	"context"
+	"database/sql"
 	"math"
 
 	"github.com/jackc/pgx/v4"
@@ -279,8 +280,11 @@ func (h *DecryptionKeysHandler) HandleMessage(ctx context.Context, msg p2pmsg.Me
 		Int64("tx-pointer-updated", newTxPointer).
 		Msg("updating tx pointer")
 	err := gnosisDB.SetTxPointer(ctx, database.SetTxPointerParams{
-		Eon:   int64(keys.Eon),
-		Slot:  int64(extra.Slot),
+		Eon: int64(keys.Eon),
+		Age: sql.NullInt64{
+			Int64: 0,
+			Valid: true,
+		},
 		Value: newTxPointer,
 	})
 	if err != nil {

rolling-shutter/keyperimpl/gnosis/database/sql/schemas/gnosiskeyper.sql

@@ -164,6 +164,16 @@ func (kpr *Keyper) Start(ctx context.Context, runner service.Runner) error {
 		return err
 	}
 
+	// Set all transaction pointer ages to infinity. They will be reset to zero when the next
+	// decryption keys arrive, telling us the agreed upon pointer value. Pointer values that are
+	// not in the db yet are not affected. They will be initialized to zero when we first access
+	// them. This is most importantly the case for the pointer value of not yet started eons.
+	gnosisDB := database.New(kpr.dbpool)
+	err = gnosisDB.ResetAllTxPointerAges(ctx)
+	if err != nil {
+		return errors.Wrap(err, "failed to reset transaction pointer age")
+	}
+
 	runner.Go(func() error { return kpr.processInputs(ctx) })
 	return runner.StartService(kpr.core, kpr.chainSyncClient, kpr.slotTicker, kpr.eonKeyPublisher)
 }

rolling-shutter/keyperimpl/gnosis/handlers.go

@@ -3,6 +3,7 @@ package gnosis
 import (
 	"bytes"
 	"context"
+	"database/sql"
 
 	"github.com/jackc/pgx/v4"
 	"github.com/jackc/pgx/v4/pgxpool"
@@ -283,8 +284,11 @@ func (i *MessagingMiddleware) advanceTxPointer(ctx context.Context, msg *p2pmsg.
 		Int64("tx-pointer-updated", newTxPointer).
 		Msg("updating tx pointer")
 	err := gnosisDB.SetTxPointer(ctx, database.SetTxPointerParams{
-		Eon:   int64(msg.Eon),
-		Slot:  int64(extra.Slot),
+		Eon: int64(msg.Eon),
+		Age: sql.NullInt64{
+			Int64: 0,
+			Valid: true,
+		},
 		Value: newTxPointer,
 	})
 	if err != nil {