Even further speedup generate

The gendocs step used to always be run unconditionally, this now also
uses make to detect changed source files.

Author: ulope

rolling-shutter/Makefile

@@ -38,8 +38,8 @@ test: test-unit
 test-all: test-unit test-integration
 
 generate: install-codegen-tools
-	${GO} generate -skip="gendocs.go" -x ./...
-	${GO} generate -run="gendocs.go" -x ./...
+	${GO} generate -skip="make docs" -x ./...
+	${GO} generate -run="make docs" -x ./...
 
 coverage:
 	${GO} test ${GOFLAGS} -covermode=count -coverprofile=coverage.out ./...

rolling-shutter/docs/Makefile

@@ -0,0 +1,4 @@
+docs: rolling-shutter.md
+
+rolling-shutter.md: ../medley/rootcmd/root.go $(shell find ../cmd -iname '*.go' ! -iname '*_test.go')
+	go run gendocs.go

rolling-shutter/docs/docs.go

@@ -0,0 +1,3 @@
+package docs
+
+//go:generate make docs

rolling-shutter/docs/gendocs.go

@@ -8,7 +8,6 @@ import (
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/cmd"
 )
 
-//go:generate go run gendocs.go
 func main() {
 	err := doc.GenMarkdownTree(cmd.Command(), "./")
 	if err != nil {

rolling-shutter/main.go

@@ -5,8 +5,6 @@ import (
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/medley/rootcmd"
 )
 
-//go:generate go run -C docs gendocs.go
-
 func main() {
 	rootcmd.Main(cmd.Command())
 }

rolling-shutter/medley/rootcmd/root.go

@@ -25,7 +25,7 @@ var (
 	ArgNameLogformat string = "logformat"
 	logLevelArg      string
 	ArgNameLoglevel  string = "loglevel"
-	reLogLevelConfig        = regexp.MustCompile("^(?:(?P<logger>[\\w/._-]+)?:(?P<level>debug|info|warn(?:ing)?|error|fatal|panic),?)+$")
+	reLogLevelConfig        = regexp.MustCompile(`^(?:([\w/.-]+)?:(debug|info|warn(?:ing)?|error|fatal|panic),?)+$`)
 )
 
 func configureCaller(l zerolog.Logger, short bool) zerolog.Logger {
@@ -116,9 +116,9 @@ func setupLogging() (zerolog.Logger, error) {
 					return l, errors.Wrapf(err, "flag '%s' value '%s' not recognized", ArgNameLoglevel, logLevel)
 				}
 				zerolog.SetGlobalLevel(level)
-				golog.SetLogLevel("*", levelName)
+				_ = golog.SetLogLevel("*", levelName)
 			} else {
-				golog.SetLogLevel(loggerName, levelName)
+				_ = golog.SetLogLevel(loggerName, levelName)
 			}
 		}
 	}