Add p2p message handling and validation metrics

Author: jannikluhn

rolling-shutter/p2p/messaging.go

@@ -34,10 +34,7 @@ func (r *ValidatorRegistry) GetCombinedValidator(topic string) pubsub.ValidatorE
 		startTime := time.Now()
 		defer func() {
 			elapsedTime := time.Since(startTime)
-			log.Debug().
-				Str("topic", topic).
-				Str("duration", elapsedTime.String()).
-				Msg("validated message")
+			metricsP2PMessageValidationTime.WithLabelValues(topic).Observe(elapsedTime.Seconds())
 		}()
 
 		ignored := false
@@ -275,13 +272,16 @@ func (m *P2PMessaging) runHandleMessages(ctx context.Context) error {
 			if !ok {
 				return nil
 			}
+			startTime := time.Now()
 			if err := m.handle(ctx, msg); err != nil {
 				log.Info().
 					Err(err).
 					Str("topic", msg.GetTopic()).
 					Str("sender-id", msg.GetFrom().String()).
 					Msg("failed to handle message")
 			}
+			elapsedTime := time.Since(startTime)
+			metricsP2PMessageHandlingTime.WithLabelValues(msg.GetTopic()).Observe(elapsedTime.Seconds())
 		case <-ctx.Done():
 			return ctx.Err()
 		}

rolling-shutter/p2p/metrics.go

@@ -0,0 +1,30 @@
+package p2p
+
+import "github.com/prometheus/client_golang/prometheus"
+
+var metricsP2PMessageValidationTime = prometheus.NewHistogramVec(
+	prometheus.HistogramOpts{
+		Namespace: "shutter",
+		Subsystem: "p2p",
+		Name:      "message_validation_time_seconds",
+		Help:      "Histogram of the time it takes to validate a P2P message.",
+		Buckets:   prometheus.DefBuckets,
+	},
+	[]string{"topic"},
+)
+
+var metricsP2PMessageHandlingTime = prometheus.NewHistogramVec(
+	prometheus.HistogramOpts{
+		Namespace: "shutter",
+		Subsystem: "p2p",
+		Name:      "message_handling_time_seconds",
+		Help:      "Histogram of the time it takes to handle a P2P message.",
+		Buckets:   prometheus.DefBuckets,
+	},
+	[]string{"topic"},
+)
+
+func init() {
+	prometheus.MustRegister(metricsP2PMessageValidationTime)
+	prometheus.MustRegister(metricsP2PMessageHandlingTime)
+}