Make max tx pointer age configurable

Author: jannikluhn

rolling-shutter/keyperimpl/gnosis/config.go

@@ -102,6 +102,7 @@ type GnosisConfig struct {
 	Contracts            *GnosisContractsConfig       `shconfig:",required"`
 	EncryptedGasLimit    uint64                       `shconfig:",required"`
 	MinGasPerTransaction uint64                       `shconfig:",required"`
+	MaxTxPointerAge      uint64                       `shconfig:",required"`
 	SecondsPerSlot       uint64                       `shconfig:",required"`
 	SlotsPerEpoch        uint64                       `shconfig:",required"`
 	GenesisSlotTimestamp uint64                       `shconfig:",required"`
@@ -113,6 +114,7 @@ func NewGnosisConfig() *GnosisConfig {
 		Contracts:            NewGnosisContractsConfig(),
 		EncryptedGasLimit:    0,
 		MinGasPerTransaction: 0,
+		MaxTxPointerAge:      0,
 		SecondsPerSlot:       0,
 		SlotsPerEpoch:        0,
 		GenesisSlotTimestamp: 0,
@@ -134,6 +136,9 @@ func (c *GnosisConfig) Validate() error {
 	if c.SecondsPerSlot == 0 {
 		return errors.Errorf("seconds per slot must not be zero")
 	}
+	if c.MaxTxPointerAge > math.MaxInt64 {
+		return errors.Errorf("max tx pointer age is too big")
+	}
 	return nil
 }
 
@@ -144,6 +149,7 @@ func (c *GnosisConfig) SetDefaultValues() error {
 func (c *GnosisConfig) SetExampleValues() error {
 	c.EncryptedGasLimit = 1_000_000
 	c.MinGasPerTransaction = 21_000
+	c.MaxTxPointerAge = 5
 	c.SecondsPerSlot = 5
 	c.SlotsPerEpoch = 16
 	c.GenesisSlotTimestamp = 1665410700

rolling-shutter/keyperimpl/gnosis/newslot.go

@@ -26,9 +26,6 @@ import (
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/shdb"
 )
 
-// Maximum age of a tx pointer in blocks before it is considered outdated.
-const maxTxPointerAge = 2
-
 func (kpr *Keyper) processNewSlot(ctx context.Context, slot slotticker.Slot) error {
 	return kpr.maybeTriggerDecryption(ctx, slot.Number)
 }
@@ -161,7 +158,7 @@ func (kpr *Keyper) isProposerRegistered(ctx context.Context, slot uint64, block
 	return isRegistered, proposerDuty.ValidatorIndex, nil
 }
 
-func getTxPointer(ctx context.Context, db *pgxpool.Pool, eon int64) (int64, error) {
+func getTxPointer(ctx context.Context, db *pgxpool.Pool, eon int64, maxTxPointerAge int64) (int64, error) {
 	gnosisKeyperDB := gnosisdatabase.New(db)
 	var txPointer int64
 	var txPointerAge int64
@@ -235,7 +232,7 @@ func (kpr *Keyper) triggerDecryption(
 	}
 	keyperConfigIndex := eonStruct.KeyperConfigIndex
 
-	txPointer, err := getTxPointer(ctx, kpr.dbpool, keyperConfigIndex)
+	txPointer, err := getTxPointer(ctx, kpr.dbpool, keyperConfigIndex, int64(kpr.config.Gnosis.MaxTxPointerAge))
 	if err != nil {
 		return err
 	}

rolling-shutter/keyperimpl/gnosis/newslot_test.go

@@ -17,6 +17,7 @@ func TestGetTxPointerBasicIntegration(t *testing.T) {
 	t.Cleanup(dbclose)
 	db := gnosisDatabase.New(dbpool)
 
+	maxTxPointerAge := int64(5)
 	err := db.SetTxPointer(ctx, gnosisDatabase.SetTxPointerParams{
 		Eon: 2,
 		Age: sql.NullInt64{
@@ -27,7 +28,7 @@ func TestGetTxPointerBasicIntegration(t *testing.T) {
 	})
 	assert.NilError(t, err)
 
-	txPointer, err := getTxPointer(ctx, dbpool, 2)
+	txPointer, err := getTxPointer(ctx, dbpool, 2, maxTxPointerAge)
 	assert.NilError(t, err)
 	assert.Equal(t, txPointer, int64(5))
 }
@@ -53,7 +54,7 @@ func TestGetTxPointerInfiniteIntegration(t *testing.T) {
 	})
 	assert.NilError(t, err)
 
-	txPointer, err := getTxPointer(ctx, dbpool, 2)
+	txPointer, err := getTxPointer(ctx, dbpool, 2, 5)
 	assert.NilError(t, err)
 	assert.Equal(t, txPointer, int64(10))
 }
@@ -64,6 +65,7 @@ func TestGetTxPointerOutdatedIntegration(t *testing.T) {
 	t.Cleanup(dbclose)
 	db := gnosisDatabase.New(dbpool)
 
+	maxTxPointerAge := int64(5)
 	err := db.SetTxPointer(ctx, gnosisDatabase.SetTxPointerParams{
 		Eon: 2,
 		Age: sql.NullInt64{
@@ -79,7 +81,7 @@ func TestGetTxPointerOutdatedIntegration(t *testing.T) {
 	})
 	assert.NilError(t, err)
 
-	txPointer, err := getTxPointer(ctx, dbpool, 2)
+	txPointer, err := getTxPointer(ctx, dbpool, 2, maxTxPointerAge)
 	assert.NilError(t, err)
 	assert.Equal(t, txPointer, int64(10))
 }
@@ -89,7 +91,7 @@ func TestGetTxPointerMissingIntegration(t *testing.T) {
 	dbpool, dbclose := testsetup.NewTestDBPool(ctx, t, gnosisDatabase.Definition)
 	t.Cleanup(dbclose)
 
-	txPointer, err := getTxPointer(ctx, dbpool, 2)
+	txPointer, err := getTxPointer(ctx, dbpool, 2, 5)
 	assert.NilError(t, err)
 	assert.Equal(t, txPointer, int64(0))