Add slot timing metrics

Author: jannikluhn

rolling-shutter/keyperimpl/gnosis/messagingmiddleware.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"time"
 
 	"github.com/jackc/pgx/v4"
 	"github.com/jackc/pgx/v4/pgxpool"
@@ -17,6 +18,7 @@ import (
 	corekeyperdatabase "github.com/shutter-network/rolling-shutter/rolling-shutter/keyper/database"
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/keyperimpl/gnosis/database"
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/keyperimpl/gnosis/gnosisssztypes"
+	"github.com/shutter-network/rolling-shutter/rolling-shutter/medley"
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/medley/identitypreimage"
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/medley/retry"
 	"github.com/shutter-network/rolling-shutter/rolling-shutter/medley/service"
@@ -173,14 +175,21 @@ func (i *MessagingMiddleware) interceptDecryptionKeyShares(
 		)
 	}
 
-	msg := proto.Clone(originalMsg).(*p2pmsg.DecryptionKeyShares)
-	msg.Extra = &p2pmsg.DecryptionKeyShares_Gnosis{
-		Gnosis: &p2pmsg.GnosisDecryptionKeySharesExtra{
-			Slot:      uint64(currentDecryptionTrigger.Slot),
-			TxPointer: uint64(currentDecryptionTrigger.TxPointer),
-			Signature: signature,
-		},
+	extra := &p2pmsg.GnosisDecryptionKeySharesExtra{
+		Slot:      uint64(currentDecryptionTrigger.Slot),
+		TxPointer: uint64(currentDecryptionTrigger.TxPointer),
+		Signature: signature,
 	}
+	msg := proto.Clone(originalMsg).(*p2pmsg.DecryptionKeyShares)
+	msg.Extra = &p2pmsg.DecryptionKeyShares_Gnosis{Gnosis: extra}
+	slotStartTimestamp := medley.SlotToTimestamp(
+		extra.Slot,
+		i.config.Gnosis.GenesisSlotTimestamp,
+		i.config.Gnosis.SecondsPerSlot,
+	)
+	slotStartTime := time.Unix(int64(slotStartTimestamp), 0)
+	delta := time.Since(slotStartTime)
+	metricsKeySharesSentTimeDelta.WithLabelValues(fmt.Sprint(originalMsg.Eon)).Observe(delta.Seconds())
 	return msg, nil
 }
 
@@ -267,6 +276,15 @@ func (i *MessagingMiddleware) interceptDecryptionKeys(
 		Int("num-signatures", len(signaturesDB)).
 		Int("num-keys", len(msg.Keys)).
 		Msg("sending keys")
+
+	slotStartTimestamp := medley.SlotToTimestamp(
+		extra.Slot,
+		i.config.Gnosis.GenesisSlotTimestamp,
+		i.config.Gnosis.SecondsPerSlot,
+	)
+	slotStartTime := time.Unix(int64(slotStartTimestamp), 0)
+	delta := time.Since(slotStartTime)
+	metricsKeysSentTimeDelta.WithLabelValues(fmt.Sprint(originalMsg.Eon)).Observe(delta.Seconds())
 	return msg, nil
 }
 

rolling-shutter/keyperimpl/gnosis/metrics.go

@@ -59,11 +59,37 @@ var metricsNumValidatorRegistrations = prometheus.NewGauge(
 	},
 )
 
+var slotTimeDeltaBuckets = []float64{-5, -4.5, -4.0, -3.5, -3.0, -2.5, -2.0, -1.5, -1.0, -0.5, -0, 1.0, 100}
+
+var metricsKeysSentTimeDelta = prometheus.NewHistogramVec(
+	prometheus.HistogramOpts{
+		Namespace: "shutter",
+		Subsystem: "gnosis",
+		Name:      "keys_sent_time_delta_seconds",
+		Help:      "Time at which keys are sent relative to slot",
+		Buckets:   slotTimeDeltaBuckets,
+	},
+	[]string{"eon"},
+)
+
+var metricsKeySharesSentTimeDelta = prometheus.NewHistogramVec(
+	prometheus.HistogramOpts{
+		Namespace: "shutter",
+		Subsystem: "gnosis",
+		Name:      "key_shares_sent_time_delta_seconds",
+		Help:      "Time at which key shares are sent relative to slot",
+		Buckets:   slotTimeDeltaBuckets,
+	},
+	[]string{"eon"},
+)
+
 func init() {
 	prometheus.MustRegister(metricsTxPointer)
 	prometheus.MustRegister(metricsTxPointerAge)
 	prometheus.MustRegister(metricsLatestTxSubmittedEventIndex)
 	prometheus.MustRegister(metricsTxSubmittedEventsSyncedUntil)
 	prometheus.MustRegister(metricsValidatorRegistrationsSyncedUntil)
 	prometheus.MustRegister(metricsNumValidatorRegistrations)
+	prometheus.MustRegister(metricsKeysSentTimeDelta)
+	prometheus.MustRegister(metricsKeySharesSentTimeDelta)
 }

rolling-shutter/medley/slots.go

@@ -7,3 +7,7 @@ func BlockTimestampToSlot(blockTimestamp uint64, genesisSlotTimestamp uint64, se
 func SlotToEpoch(slot uint64, slotsPerEpoch uint64) uint64 {
 	return slot / slotsPerEpoch
 }
+
+func SlotToTimestamp(slot uint64, genesisSlotTimestamp uint64, secondsPerSlot uint64) uint64 {
+	return genesisSlotTimestamp + slot*secondsPerSlot
+}