Reduce database redundancy

We used to explicitly count the number of txs inserted into the db. This
is the value we reset the tx pointer if key generation fails. However,
if for some reason, eg due to a reorg, some tx events are missed, this
value is a bad choice because the other keypers will likely disagree.

Now we use the index of the latest inserted tx instead which is
automatically corrected with every new tx, irrespective of what happened
in the past.

Author: jannikluhn

rolling-shutter/keyperimpl/gnosis/database/gnosiskeyper.sqlc.gen.go

@@ -34,16 +34,9 @@ SET block_hash = $1, block_number = $2, slot = $3;
 -- name: GetTransactionSubmittedEventsSyncedUntil :one
 SELECT * FROM transaction_submitted_events_synced_until LIMIT 1;
 
--- name: SetTransactionSubmittedEventCount :exec
-INSERT INTO transaction_submitted_event_count (eon, event_count)
-VALUES ($1, $2)
-ON CONFLICT (eon) DO UPDATE
-SET event_count = $2;
-
 -- name: GetTransactionSubmittedEventCount :one
-SELECT event_count FROM transaction_submitted_event_count
-WHERE eon = $1
-LIMIT 1;
+SELECT max(index) + 1 FROM transaction_submitted_event
+WHERE eon = $1;
 
 -- name: GetTxPointer :one
 SELECT * FROM tx_pointer

rolling-shutter/keyperimpl/gnosis/database/sql/queries/gnosiskeyper.sql

@@ -219,7 +219,8 @@ func getTxPointer(ctx context.Context, db *pgxpool.Pool, eon int64, maxTxPointer
 			Int64("tx-pointer", txPointer).
 			Int64("tx-pointer-age", txPointerAge).
 			Msg("outdated tx pointer")
-		txPointer, err = gnosisKeyperDB.GetTransactionSubmittedEventCount(ctx, eon)
+		txPointerInt32, err := gnosisKeyperDB.GetTransactionSubmittedEventCount(ctx, eon)
+		txPointer = int64(txPointerInt32)
 		if err == pgx.ErrNoRows {
 			txPointer = 0
 		} else if err != nil {

rolling-shutter/keyperimpl/gnosis/newslot.go

@@ -48,9 +48,11 @@ func TestGetTxPointerInfiniteIntegration(t *testing.T) {
 		Value: 5,
 	})
 	assert.NilError(t, err)
-	err = db.SetTransactionSubmittedEventCount(ctx, gnosisDatabase.SetTransactionSubmittedEventCountParams{
-		Eon:        2,
-		EventCount: 10,
+	_, err = db.InsertTransactionSubmittedEvent(ctx, gnosisDatabase.InsertTransactionSubmittedEventParams{
+		Index:          9,
+		Eon:            2,
+		BlockHash:      []byte{},
+		IdentityPrefix: []byte{},
 	})
 	assert.NilError(t, err)
 
@@ -75,9 +77,11 @@ func TestGetTxPointerOutdatedIntegration(t *testing.T) {
 		Value: 5,
 	})
 	assert.NilError(t, err)
-	err = db.SetTransactionSubmittedEventCount(ctx, gnosisDatabase.SetTransactionSubmittedEventCountParams{
-		Eon:        2,
-		EventCount: 10,
+	_, err = db.InsertTransactionSubmittedEvent(ctx, gnosisDatabase.InsertTransactionSubmittedEventParams{
+		Index:          9,
+		Eon:            2,
+		BlockHash:      []byte{},
+		IdentityPrefix: []byte{},
 	})
 	assert.NilError(t, err)
 

rolling-shutter/keyperimpl/gnosis/newslot_test.go

@@ -152,7 +152,6 @@ func (s *SequencerSyncer) insertTransactionSubmittedEvents(
 	events []*sequencerBindings.SequencerTransactionSubmitted,
 ) error {
 	queries := database.New(tx)
-	nextEventIndices := make(map[uint64]int64)
 	for _, event := range events {
 		_, err := queries.InsertTransactionSubmittedEvent(ctx, database.InsertTransactionSubmittedEventParams{
 			Index:          int64(event.TxIndex),
@@ -169,7 +168,6 @@ func (s *SequencerSyncer) insertTransactionSubmittedEvents(
 			return errors.Wrap(err, "failed to insert transaction submitted event into db")
 		}
 		metricsLatestTxSubmittedEventIndex.WithLabelValues(fmt.Sprint(event.Eon)).Set(float64(event.TxIndex))
-		nextEventIndices[event.Eon]++
 		log.Debug().
 			Uint64("index", event.TxIndex).
 			Uint64("block", event.Raw.BlockNumber).
@@ -179,14 +177,5 @@ func (s *SequencerSyncer) insertTransactionSubmittedEvents(
 			Uint64("gasLimit", event.GasLimit.Uint64()).
 			Msg("synced new transaction submitted event")
 	}
-	for eon, nextEventIndex := range nextEventIndices {
-		err := queries.SetTransactionSubmittedEventCount(ctx, database.SetTransactionSubmittedEventCountParams{
-			Eon:        int64(eon),
-			EventCount: nextEventIndex,
-		})
-		if err != nil {
-			return err
-		}
-	}
 	return nil
 }