Fix TestStartNetworkNodeIntegration

The test TestStartNetworkNodeIntegration was failing due to a detected
race condition. The race condition was due to a write and read on the
package-level `version` variable in shversion. To fix it, we stop
caching the version. This should not have a performance impact because
the version is expected to be accessed only once.

Author: jannikluhn

rolling-shutter/cmd/shversion/shversion.go

@@ -24,15 +24,15 @@ func VersionShort() string {
 	if version == "" {
 		info, ok := debug.ReadBuildInfo()
 		if ok {
-			version = info.Main.Version
-			if version == "(devel)" {
+			versionShort := info.Main.Version
+			if versionShort == "(devel)" {
 				for _, s := range info.Settings {
 					if s.Key == "vcs.revision" {
-						version = fmt.Sprintf("(devel-%s)", s.Value)
-						break
+						return fmt.Sprintf("(devel-%s)", s.Value)
 					}
 				}
 			}
+			return versionShort
 		}
 	}
 	return version