Skip to content

Commit e02ee61

Browse files
chore: lint fixes for successful_dkg metric
1 parent a2bebbf commit e02ee61

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

rolling-shutter/keyper/epochkghandler/key.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,23 +62,23 @@ func (handler *DecryptionKeyHandler) ValidateMessage(ctx context.Context, msg p2
6262

6363
dkgResultDB, err := queries.GetDKGResultForKeyperConfigIndex(ctx, eon)
6464
if errors.Is(err, pgx.ErrNoRows) {
65-
keypermetrics.MetricsKeyperSuccessfullDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(0)
65+
keypermetrics.MetricsKeyperSuccessfulDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(0)
6666
return pubsub.ValidationReject, errors.Errorf("no DKG result found for eon %d", eon)
6767
}
6868
if err != nil {
69-
keypermetrics.MetricsKeyperSuccessfullDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(0)
69+
keypermetrics.MetricsKeyperSuccessfulDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(0)
7070
return pubsub.ValidationReject, errors.Wrapf(err, "failed to get dkg result for eon %d from db", eon)
7171
}
7272
if !dkgResultDB.Success {
73-
keypermetrics.MetricsKeyperSuccessfullDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(0)
73+
keypermetrics.MetricsKeyperSuccessfulDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(0)
7474
return pubsub.ValidationReject, errors.Errorf("no successful DKG result found for eon %d", eon)
7575
}
7676
pureDKGResult, err := shdb.DecodePureDKGResult(dkgResultDB.PureResult)
7777
if err != nil {
7878
return pubsub.ValidationReject, errors.Wrapf(err, "error while decoding pure DKG result for eon %d", eon)
7979
}
8080

81-
keypermetrics.MetricsKeyperSuccessfullDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(1)
81+
keypermetrics.MetricsKeyperSuccessfulDKG.WithLabelValues(strconv.FormatInt(eon, 10)).Set(1)
8282
if len(decryptionKeys.Keys) == 0 {
8383
return pubsub.ValidationReject, errors.New("no keys in message")
8484
}

rolling-shutter/keyper/keypermetrics/metrics.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,11 @@ var MetricsKeyperBatchConfigInfo = prometheus.NewGaugeVec(
7979
},
8080
[]string{"batch_config_index", "keyper_addresses"})
8181

82-
var MetricsKeyperSuccessfullDKG = prometheus.NewGaugeVec(
82+
var MetricsKeyperSuccessfulDKG = prometheus.NewGaugeVec(
8383
prometheus.GaugeOpts{
8484
Namespace: "shutter",
8585
Subsystem: "keyper",
86-
Name: "successfull_dkg",
86+
Name: "successful_dkg",
8787
Help: "Is DKG successful",
8888
},
8989
[]string{"eon"},
@@ -98,5 +98,5 @@ func InitMetrics() {
9898
prometheus.MustRegister(MetricsKeyperCurrentPhase)
9999
prometheus.MustRegister(MetricsKeyperCurrentBatchConfigIndex)
100100
prometheus.MustRegister(MetricsKeyperBatchConfigInfo)
101-
prometheus.MustRegister(MetricsKeyperSuccessfullDKG)
101+
prometheus.MustRegister(MetricsKeyperSuccessfulDKG)
102102
}

rolling-shutter/keyper/smobserver/smstate.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ func (st *ShuttermintState) finalizeDKG(
489489
dkgresultmsg := shmsg.NewDKGResult(eon, err == nil)
490490

491491
if err != nil {
492-
keypermetrics.MetricsKeyperSuccessfullDKG.WithLabelValues(strconv.FormatInt(int64(eon), 10)).Set(0)
492+
keypermetrics.MetricsKeyperSuccessfulDKG.WithLabelValues(strconv.FormatUint(eon, 10)).Set(0)
493493
log.Error().Err(err).Uint64("eon", eon).Bool("success", false).
494494
Msg("DKG process failed")
495495
dkgerror = sql.NullString{String: err.Error(), Valid: true}
@@ -498,7 +498,7 @@ func (st *ShuttermintState) finalizeDKG(
498498
return err
499499
}
500500
} else {
501-
keypermetrics.MetricsKeyperSuccessfullDKG.WithLabelValues(strconv.FormatInt(int64(eon), 10)).Set(1)
501+
keypermetrics.MetricsKeyperSuccessfulDKG.WithLabelValues(strconv.FormatUint(eon, 10)).Set(1)
502502
log.Info().Uint64("eon", eon).Bool("success", true).Msg("DKG process succeeded")
503503
pureResult, err = shdb.EncodePureDKGResult(&dkgresult)
504504
if err != nil {

0 commit comments

Comments
 (0)