chore(codegen): type imports and index tests (aws#7545)

* chore(codegen): type imports and index tests

* chore: enable index tests

* chore: add index tests

Author: kuhe

Makefile

@@ -1,7 +1,7 @@
 # This is the public Makefile containing some build commands.
 # You can implement some additional personal commands such as login and sync in Makefile.private.mk (unversioned).
 
-.PHONY: bundles test-unit test-integration test-protocols test-e2e
+.PHONY: bundles test-unit test-integration test-protocols test-e2e test-indices test-schema test-endpoints test-bundlers
 
 # fetch AWS testing credentials
 login:
@@ -26,6 +26,9 @@ test-unit: bundles
 test-types:
 	npx tsc -p tsconfig.test.json
 
+test-indices:
+	node ./scripts/validation/client-index-tests.mjs
+
 test-protocols: bundles
 	yarn g:vitest run -c vitest.config.protocols.integ.mts
 
@@ -38,6 +41,7 @@ test-integration: bundles
 	yarn g:vitest run -c vitest.config.integ.mts
 	make test-protocols
 	make test-types
+	make test-indices
 	make test-endpoints
 
 test-endpoints:

clients/client-accessanalyzer/package.json

@@ -11,7 +11,8 @@
     "build:types:downlevel": "downlevel-dts dist-types dist-types/ts3.4",
     "clean": "rimraf ./dist-* && rimraf *.tsbuildinfo",
     "extract:docs": "api-extractor run --local",
-    "generate:client": "node ../../scripts/generate-clients/single-service --solo accessanalyzer"
+    "generate:client": "node ../../scripts/generate-clients/single-service --solo accessanalyzer",
+    "test:index": "tsc --noEmit ./test/index-types.ts && node ./test/index-objects.spec.mjs"
   },
   "main": "./dist-cjs/index.js",
   "types": "./dist-types/index.d.ts",
@@ -32,26 +33,26 @@
     "@aws-sdk/util-user-agent-browser": "*",
     "@aws-sdk/util-user-agent-node": "*",
     "@smithy/config-resolver": "^4.4.3",
-    "@smithy/core": "^3.18.5",
+    "@smithy/core": "^3.18.6",
     "@smithy/fetch-http-handler": "^5.3.6",
     "@smithy/hash-node": "^4.2.5",
     "@smithy/invalid-dependency": "^4.2.5",
     "@smithy/middleware-content-length": "^4.2.5",
-    "@smithy/middleware-endpoint": "^4.3.12",
-    "@smithy/middleware-retry": "^4.4.12",
+    "@smithy/middleware-endpoint": "^4.3.13",
+    "@smithy/middleware-retry": "^4.4.13",
     "@smithy/middleware-serde": "^4.2.6",
     "@smithy/middleware-stack": "^4.2.5",
     "@smithy/node-config-provider": "^4.3.5",
     "@smithy/node-http-handler": "^4.4.5",
     "@smithy/protocol-http": "^5.3.5",
-    "@smithy/smithy-client": "^4.9.8",
+    "@smithy/smithy-client": "^4.9.9",
     "@smithy/types": "^4.9.0",
     "@smithy/url-parser": "^4.2.5",
     "@smithy/util-base64": "^4.3.0",
     "@smithy/util-body-length-browser": "^4.2.0",
     "@smithy/util-body-length-node": "^4.2.1",
-    "@smithy/util-defaults-mode-browser": "^4.3.11",
-    "@smithy/util-defaults-mode-node": "^4.2.14",
+    "@smithy/util-defaults-mode-browser": "^4.3.12",
+    "@smithy/util-defaults-mode-node": "^4.2.15",
     "@smithy/util-endpoints": "^3.2.5",
     "@smithy/util-middleware": "^4.2.5",
     "@smithy/util-retry": "^4.2.5",

clients/client-accessanalyzer/src/AccessAnalyzer.ts

@@ -1,8 +1,8 @@
 // smithy-typescript generated code
 import { createAggregatedClient } from "@smithy/smithy-client";
-import { HttpHandlerOptions as __HttpHandlerOptions } from "@smithy/types";
+import type { HttpHandlerOptions as __HttpHandlerOptions } from "@smithy/types";
 
-import { AccessAnalyzerClient, AccessAnalyzerClientConfig } from "./AccessAnalyzerClient";
+import { AccessAnalyzerClient } from "./AccessAnalyzerClient";
 import {
   ApplyArchiveRuleCommand,
   ApplyArchiveRuleCommandInput,

clients/client-accessanalyzer/src/AccessAnalyzerClient.ts

@@ -1,60 +1,69 @@
 // smithy-typescript generated code
 import {
+  type HostHeaderInputConfig,
+  type HostHeaderResolvedConfig,
   getHostHeaderPlugin,
-  HostHeaderInputConfig,
-  HostHeaderResolvedConfig,
   resolveHostHeaderConfig,
 } from "@aws-sdk/middleware-host-header";
 import { getLoggerPlugin } from "@aws-sdk/middleware-logger";
 import { getRecursionDetectionPlugin } from "@aws-sdk/middleware-recursion-detection";
 import {
+  type UserAgentInputConfig,
+  type UserAgentResolvedConfig,
   getUserAgentPlugin,
   resolveUserAgentConfig,
-  UserAgentInputConfig,
-  UserAgentResolvedConfig,
 } from "@aws-sdk/middleware-user-agent";
-import { RegionInputConfig, RegionResolvedConfig, resolveRegionConfig } from "@smithy/config-resolver";
+import { type RegionInputConfig, type RegionResolvedConfig, resolveRegionConfig } from "@smithy/config-resolver";
 import {
   DefaultIdentityProviderConfig,
   getHttpAuthSchemeEndpointRuleSetPlugin,
   getHttpSigningPlugin,
 } from "@smithy/core";
 import { getSchemaSerdePlugin } from "@smithy/core/schema";
 import { getContentLengthPlugin } from "@smithy/middleware-content-length";
-import { EndpointInputConfig, EndpointResolvedConfig, resolveEndpointConfig } from "@smithy/middleware-endpoint";
-import { getRetryPlugin, resolveRetryConfig, RetryInputConfig, RetryResolvedConfig } from "@smithy/middleware-retry";
-import { HttpHandlerUserInput as __HttpHandlerUserInput } from "@smithy/protocol-http";
 import {
+  type EndpointInputConfig,
+  type EndpointResolvedConfig,
+  resolveEndpointConfig,
+} from "@smithy/middleware-endpoint";
+import {
+  type RetryInputConfig,
+  type RetryResolvedConfig,
+  getRetryPlugin,
+  resolveRetryConfig,
+} from "@smithy/middleware-retry";
+import type { HttpHandlerUserInput as __HttpHandlerUserInput } from "@smithy/protocol-http";
+import {
+  type DefaultsMode as __DefaultsMode,
+  type SmithyConfiguration as __SmithyConfiguration,
+  type SmithyResolvedConfiguration as __SmithyResolvedConfiguration,
   Client as __Client,
-  DefaultsMode as __DefaultsMode,
-  SmithyConfiguration as __SmithyConfiguration,
-  SmithyResolvedConfiguration as __SmithyResolvedConfiguration,
 } from "@smithy/smithy-client";
 import {
+  type BodyLengthCalculator as __BodyLengthCalculator,
+  type CheckOptionalClientConfig as __CheckOptionalClientConfig,
+  type ChecksumConstructor as __ChecksumConstructor,
+  type ClientProtocol,
+  type Decoder as __Decoder,
+  type Encoder as __Encoder,
+  type HashConstructor as __HashConstructor,
+  type HttpHandlerOptions as __HttpHandlerOptions,
+  type HttpRequest,
+  type HttpResponse,
+  type Logger as __Logger,
+  type Provider as __Provider,
+  type StreamCollector as __StreamCollector,
+  type UrlParser as __UrlParser,
   AwsCredentialIdentityProvider,
-  BodyLengthCalculator as __BodyLengthCalculator,
-  CheckOptionalClientConfig as __CheckOptionalClientConfig,
-  ChecksumConstructor as __ChecksumConstructor,
-  ClientProtocol,
-  Decoder as __Decoder,
-  Encoder as __Encoder,
   EndpointV2 as __EndpointV2,
-  HashConstructor as __HashConstructor,
-  HttpHandlerOptions as __HttpHandlerOptions,
-  HttpRequest,
-  HttpResponse,
-  Logger as __Logger,
-  Provider as __Provider,
   Provider,
-  StreamCollector as __StreamCollector,
-  UrlParser as __UrlParser,
   UserAgent as __UserAgent,
 } from "@smithy/types";
 
 import {
+  type HttpAuthSchemeInputConfig,
+  type HttpAuthSchemeResolvedConfig,
   defaultAccessAnalyzerHttpAuthSchemeParametersProvider,
-  HttpAuthSchemeInputConfig,
-  HttpAuthSchemeResolvedConfig,
   resolveHttpAuthSchemeConfig,
 } from "./auth/httpAuthSchemeProvider";
 import { ApplyArchiveRuleCommandInput, ApplyArchiveRuleCommandOutput } from "./commands/ApplyArchiveRuleCommand";
@@ -140,7 +149,7 @@ import {
   resolveClientEndpointParameters,
 } from "./endpoint/EndpointParameters";
 import { getRuntimeConfig as __getRuntimeConfig } from "./runtimeConfig";
-import { resolveRuntimeExtensions, RuntimeExtension, RuntimeExtensionsConfig } from "./runtimeExtensions";
+import { type RuntimeExtension, type RuntimeExtensionsConfig, resolveRuntimeExtensions } from "./runtimeExtensions";
 
 export { __Client };
 

clients/client-accessanalyzer/src/auth/httpAuthExtensionConfiguration.ts

@@ -1,7 +1,7 @@
 // smithy-typescript generated code
-import { AwsCredentialIdentity, AwsCredentialIdentityProvider, HttpAuthScheme } from "@smithy/types";
+import { type HttpAuthScheme, AwsCredentialIdentity, AwsCredentialIdentityProvider } from "@smithy/types";
 
-import { AccessAnalyzerHttpAuthSchemeProvider } from "./httpAuthSchemeProvider";
+import type { AccessAnalyzerHttpAuthSchemeProvider } from "./httpAuthSchemeProvider";
 
 /**
  * @internal

clients/client-accessanalyzer/src/auth/httpAuthSchemeProvider.ts

@@ -5,7 +5,7 @@ import {
   AwsSdkSigV4PreviouslyResolved,
   resolveAwsSdkSigV4Config,
 } from "@aws-sdk/core";
-import {
+import type {
   HandlerExecutionContext,
   HttpAuthOption,
   HttpAuthScheme,
@@ -16,7 +16,7 @@ import {
 } from "@smithy/types";
 import { getSmithyContext, normalizeProvider } from "@smithy/util-middleware";
 
-import { AccessAnalyzerClientConfig, AccessAnalyzerClientResolvedConfig } from "../AccessAnalyzerClient";
+import { type AccessAnalyzerClientResolvedConfig, AccessAnalyzerClientConfig } from "../AccessAnalyzerClient";
 
 /**
  * @internal

clients/client-accessanalyzer/src/commands/ApplyArchiveRuleCommand.ts

@@ -1,11 +1,15 @@
 // smithy-typescript generated code
 import { getEndpointPlugin } from "@smithy/middleware-endpoint";
 import { Command as $Command } from "@smithy/smithy-client";
-import { MetadataBearer as __MetadataBearer } from "@smithy/types";
+import type { MetadataBearer as __MetadataBearer } from "@smithy/types";
 
-import { AccessAnalyzerClientResolvedConfig, ServiceInputTypes, ServiceOutputTypes } from "../AccessAnalyzerClient";
+import type {
+  AccessAnalyzerClientResolvedConfig,
+  ServiceInputTypes,
+  ServiceOutputTypes,
+} from "../AccessAnalyzerClient";
 import { commonParams } from "../endpoint/EndpointParameters";
-import { ApplyArchiveRuleRequest } from "../models/models_0";
+import type { ApplyArchiveRuleRequest } from "../models/models_0";
 import { ApplyArchiveRule } from "../schemas/schemas_0";
 
 /**

clients/client-accessanalyzer/src/commands/CancelPolicyGenerationCommand.ts

@@ -1,11 +1,15 @@
 // smithy-typescript generated code
 import { getEndpointPlugin } from "@smithy/middleware-endpoint";
 import { Command as $Command } from "@smithy/smithy-client";
-import { MetadataBearer as __MetadataBearer } from "@smithy/types";
+import type { MetadataBearer as __MetadataBearer } from "@smithy/types";
 
-import { AccessAnalyzerClientResolvedConfig, ServiceInputTypes, ServiceOutputTypes } from "../AccessAnalyzerClient";
+import type {
+  AccessAnalyzerClientResolvedConfig,
+  ServiceInputTypes,
+  ServiceOutputTypes,
+} from "../AccessAnalyzerClient";
 import { commonParams } from "../endpoint/EndpointParameters";
-import { CancelPolicyGenerationRequest, CancelPolicyGenerationResponse } from "../models/models_0";
+import type { CancelPolicyGenerationRequest, CancelPolicyGenerationResponse } from "../models/models_0";
 import { CancelPolicyGeneration } from "../schemas/schemas_0";
 
 /**

clients/client-accessanalyzer/src/commands/CheckAccessNotGrantedCommand.ts

@@ -1,11 +1,15 @@
 // smithy-typescript generated code
 import { getEndpointPlugin } from "@smithy/middleware-endpoint";
 import { Command as $Command } from "@smithy/smithy-client";
-import { MetadataBearer as __MetadataBearer } from "@smithy/types";
+import type { MetadataBearer as __MetadataBearer } from "@smithy/types";
 
-import { AccessAnalyzerClientResolvedConfig, ServiceInputTypes, ServiceOutputTypes } from "../AccessAnalyzerClient";
+import type {
+  AccessAnalyzerClientResolvedConfig,
+  ServiceInputTypes,
+  ServiceOutputTypes,
+} from "../AccessAnalyzerClient";
 import { commonParams } from "../endpoint/EndpointParameters";
-import { CheckAccessNotGrantedRequest, CheckAccessNotGrantedResponse } from "../models/models_0";
+import type { CheckAccessNotGrantedRequest, CheckAccessNotGrantedResponse } from "../models/models_0";
 import { CheckAccessNotGranted } from "../schemas/schemas_0";
 
 /**

clients/client-accessanalyzer/src/commands/CheckNoNewAccessCommand.ts

@@ -1,11 +1,15 @@
 // smithy-typescript generated code
 import { getEndpointPlugin } from "@smithy/middleware-endpoint";
 import { Command as $Command } from "@smithy/smithy-client";
-import { MetadataBearer as __MetadataBearer } from "@smithy/types";
+import type { MetadataBearer as __MetadataBearer } from "@smithy/types";
 
-import { AccessAnalyzerClientResolvedConfig, ServiceInputTypes, ServiceOutputTypes } from "../AccessAnalyzerClient";
+import type {
+  AccessAnalyzerClientResolvedConfig,
+  ServiceInputTypes,
+  ServiceOutputTypes,
+} from "../AccessAnalyzerClient";
 import { commonParams } from "../endpoint/EndpointParameters";
-import { CheckNoNewAccessRequest, CheckNoNewAccessResponse } from "../models/models_0";
+import type { CheckNoNewAccessRequest, CheckNoNewAccessResponse } from "../models/models_0";
 import { CheckNoNewAccess } from "../schemas/schemas_0";
 
 /**