fix: fallback to ExternalIP for boostrap if no InternalIP is found

Try finding any ExternalIPs addresses when bootstrapping a cluster if no InternalIPs address is found for the machine.

Signed-off-by: Damiano Donati <[email protected]>
Signed-off-by: Artem Chernyshev <[email protected]>
(cherry picked from commit f3ff7ad)

Author: damdo

controllers/taloscontrolplane_controller.go

@@ -407,6 +407,7 @@ func (r *TalosControlPlaneReconciler) bootstrapCluster(ctx context.Context, tcp
 	for _, machine := range machines {
 		found := false
 
+		// Prefer finding an InternalIP address for the machine first.
 		for _, addr := range machine.Status.Addresses {
 			if addr.Type == clusterv1.MachineInternalIP {
 				addresses = append(addresses, addr.Address)
@@ -417,8 +418,24 @@ func (r *TalosControlPlaneReconciler) bootstrapCluster(ctx context.Context, tcp
 			}
 		}
 
+		if found {
+			continue
+		}
+
+		// Fallback to finding an ExternalIP address for the machine
+		// if no InternalIP is found.
+		for _, addr := range machine.Status.Addresses {
+			if addr.Type == clusterv1.MachineExternalIP {
+				addresses = append(addresses, addr.Address)
+
+				found = true
+
+				break
+			}
+		}
+
 		if !found {
-			return fmt.Errorf("machine %q doesn't have an InternalIP address yet", machine.Name)
+			return fmt.Errorf("machine %q doesn't have an any InternalIP or ExternalIP address yet", machine.Name)
 		}
 	}