Trying to patch the default runtime in Omni not working

[urbaman]

Hi,

Trying to run gpu workloads on Omni managed cluster.

The needed patches work, and I can safely run pods defining the runtimeClass in the workload yaml.

Thing is: I cannot seem to be able to patch the default runtime on the node:

Is there a different way to make it work?

Thank you.

[urbaman]

Probably found out:

machine:
  files:
    - content: |
        [plugins]
          [plugins."io.containerd.grpc.v1.cri"]
            [plugins."io.containerd.grpc.v1.cri".containerd]
              default_runtime_name = "nvidia"
      path: /etc/cri/conf.d/20-customization.part

[urbaman]

Ok, the previous patch seems to be accepted, but cannot say if it really went through: I still cannot run workloads on those nodes without setting the runtimeClassName in the worload spec.

So, is the patch ok? How can I be sure it went through, letting me run workloads without having to always set the runtimeClassName?

Thank you.

[smira]

The patch is okay, it enables a new container runtime.

Kubernetes controls runtimes via RuntimeClass.

Talos runs containerd 2.x, so you should use appropriate config to change the runtime: https://github.com/containerd/containerd/blob/main/docs/cri/config.md#runtime-classes

But I wouldn't recommend making NVIDIA a default one, as you also have system pods which shouldn't use it.

[urbaman]

Hi,

So I think I was confused by the docs, stating the patch would make the runtimeClass the default one: https://docs.siderolabs.com/talos/v1.7/configure-your-talos-cluster/hardware-and-drivers/nvidia-gpu#optional-setting-the-default-runtime-class-as-nvidia

Thank you for the insight, there's probably some clearing on the docs to do?

[smira]

That is Talos v1.7 docs, you should not be using new version https://docs.siderolabs.com/talos/v1.12/configure-your-talos-cluster/hardware-and-drivers/nvidia-gpu#optional-setting-the-default-runtime-class-as-nvidia

[urbaman]

Well, sorry for the confusion (I usually check the doc version), but it still states the patch would make it the default runtimeClass on the node?

[smira]

yes, it should

[smira]

@Iheanacho-ai we should update the docs and drop all JSON6902 patches in favor of strategic merge patches