fix: remove interactive installer

The interactive installer has been deprecated since v1.12 cycle,
now removed completely including the API method.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>

Author: smira

api/lock.binpb

@@ -64,10 +64,6 @@ service MachineService {
   // EtcdDowngradeCancel cancels etcd cluster downgrade that is in progress.
   // This method is available only on control plane nodes (which run etcd).
   rpc EtcdDowngradeCancel(google.protobuf.Empty) returns (EtcdDowngradeCancelResponse);
-  rpc GenerateConfiguration(GenerateConfigurationRequest) returns (GenerateConfigurationResponse) {
-    option (common.remove_deprecated_method) = "v1.13";
-    option deprecated = true;
-  }
   rpc Hostname(google.protobuf.Empty) returns (HostnameResponse);
   rpc Kubeconfig(google.protobuf.Empty) returns (stream common.Data);
   rpc List(ListRequest) returns (stream FileInfo);
@@ -1228,26 +1224,6 @@ message ClusterConfig {
   bool allow_scheduling_on_control_planes = 4;
 }
 
-// GenerateConfigurationRequest describes a request to generate a new configuration
-// on a node.
-message GenerateConfigurationRequest {
-  string config_version = 1;
-  ClusterConfig cluster_config = 2;
-  MachineConfig machine_config = 3;
-  google.protobuf.Timestamp override_time = 4;
-}
-
-// GenerateConfiguration describes the response to a generate configuration request.
-message GenerateConfiguration {
-  common.Metadata metadata = 1;
-  repeated bytes data = 2;
-  bytes talosconfig = 3;
-}
-
-message GenerateConfigurationResponse {
-  repeated GenerateConfiguration messages = 1;
-}
-
 message GenerateClientConfigurationRequest {
   // Roles in the generated client certificate.
   repeated string roles = 1;

api/machine/machine.proto

@@ -16,7 +16,6 @@ import (
 	"google.golang.org/protobuf/types/known/durationpb"
 
 	"github.com/siderolabs/talos/cmd/talosctl/pkg/talos/helpers"
-	"github.com/siderolabs/talos/internal/pkg/tui/installer"
 	machineapi "github.com/siderolabs/talos/pkg/machinery/api/machine"
 	"github.com/siderolabs/talos/pkg/machinery/client"
 	"github.com/siderolabs/talos/pkg/machinery/config/configpatcher"
@@ -59,39 +58,39 @@ var applyConfigCmd = &cobra.Command{
 			}
 		}
 
-		if applyConfigCmdFlags.filename != "" {
-			cfgBytes, err = os.ReadFile(applyConfigCmdFlags.filename)
+		if applyConfigCmdFlags.filename == "" {
+			return errors.New("no filename supplied for configuration")
+		}
+
+		cfgBytes, err = os.ReadFile(applyConfigCmdFlags.filename)
+		if err != nil {
+			return fmt.Errorf("failed to read configuration from %q: %w", applyConfigCmdFlags.filename, err)
+		}
+
+		if len(cfgBytes) < 1 {
+			return errors.New("no configuration data read")
+		}
+
+		if len(applyConfigCmdFlags.patches) != 0 {
+			var (
+				cfg     configpatcher.Input
+				patches []configpatcher.Patch
+			)
+
+			patches, err = configpatcher.LoadPatches(applyConfigCmdFlags.patches)
 			if err != nil {
-				return fmt.Errorf("failed to read configuration from %q: %w", applyConfigCmdFlags.filename, err)
+				return err
 			}
 
-			if len(cfgBytes) < 1 {
-				return errors.New("no configuration data read")
+			cfg, err = configpatcher.Apply(configpatcher.WithBytes(cfgBytes), patches)
+			if err != nil {
+				return err
 			}
 
-			if len(applyConfigCmdFlags.patches) != 0 {
-				var (
-					cfg     configpatcher.Input
-					patches []configpatcher.Patch
-				)
-
-				patches, err = configpatcher.LoadPatches(applyConfigCmdFlags.patches)
-				if err != nil {
-					return err
-				}
-
-				cfg, err = configpatcher.Apply(configpatcher.WithBytes(cfgBytes), patches)
-				if err != nil {
-					return err
-				}
-
-				cfgBytes, err = cfg.Bytes()
-				if err != nil {
-					return err
-				}
+			cfgBytes, err = cfg.Bytes()
+			if err != nil {
+				return err
 			}
-		} else if applyConfigCmdFlags.Mode.Mode != helpers.InteractiveMode { //nolint:staticcheck
-			return errors.New("no filename supplied for configuration")
 		}
 
 		withClient := func(f func(context.Context, *client.Client) error) error {
@@ -103,44 +102,6 @@ var applyConfigCmd = &cobra.Command{
 		}
 
 		return withClient(func(ctx context.Context, c *client.Client) error {
-			if applyConfigCmdFlags.Mode.Mode == helpers.InteractiveMode { //nolint:staticcheck
-				install := installer.NewInstaller()
-				node := GlobalArgs.Nodes[0]
-
-				if len(GlobalArgs.Endpoints) > 0 {
-					return WithClientNoNodes(func(bootstrapCtx context.Context, bootstrapClient *client.Client) error {
-						opts := []installer.Option{
-							installer.WithBootstrapNode(bootstrapCtx, bootstrapClient, GlobalArgs.Endpoints[0]),
-							installer.WithDryRun(applyConfigCmdFlags.dryRun),
-						}
-
-						conn, err := installer.NewConnection(
-							ctx,
-							c,
-							node,
-							opts...,
-						)
-						if err != nil {
-							return err
-						}
-
-						return install.Run(conn)
-					})
-				}
-
-				conn, err := installer.NewConnection(
-					ctx,
-					c,
-					node,
-					installer.WithDryRun(applyConfigCmdFlags.dryRun),
-				)
-				if err != nil {
-					return err
-				}
-
-				return install.Run(conn)
-			}
-
 			resp, err := c.ApplyConfiguration(ctx, &machineapi.ApplyConfigurationRequest{
 				Data:           cfgBytes,
 				Mode:           applyConfigCmdFlags.Mode.Mode,

cmd/talosctl/cmd/talos/apply-config.go

@@ -11,20 +11,12 @@ import (
 	"strings"
 
 	"github.com/siderolabs/gen/maps"
-	"github.com/siderolabs/gen/xslices"
 	"github.com/spf13/cobra"
 
 	"github.com/siderolabs/talos/pkg/cli"
 	"github.com/siderolabs/talos/pkg/machinery/api/machine"
 )
 
-// InteractiveMode fake mode value for the interactive config mode.
-// Should be never passed to the API.
-//
-// Deprecated: Interactive configuration mode will be removed and
-// should no longer be used.
-const InteractiveMode machine.ApplyConfigurationRequest_Mode = -1
-
 // Mode apply, patch, edit config update mode.
 type Mode struct {
 	options map[string]machine.ApplyConfigurationRequest_Mode
@@ -43,8 +35,6 @@ func (m Mode) String() string {
 		return modeReboot
 	case machine.ApplyConfigurationRequest_STAGED:
 		return modeStaged
-	case InteractiveMode:
-		return modeInteractive
 	default:
 		return modeAuto
 	}
@@ -66,20 +56,16 @@ func (m *Mode) Set(value string) error {
 func (m *Mode) Type() string {
 	options := maps.Keys(m.options)
 	slices.Sort(options)
-	options = xslices.Filter(options, func(opt string) bool {
-		return opt != modeInteractive
-	})
 
 	return strings.Join(options, ", ")
 }
 
 const (
-	modeAuto        = "auto"
-	modeNoReboot    = "no-reboot"
-	modeReboot      = "reboot"
-	modeStaged      = "staged"
-	modeInteractive = "interactive"
-	modeTry         = "try"
+	modeAuto     = "auto"
+	modeNoReboot = "no-reboot"
+	modeReboot   = "reboot"
+	modeStaged   = "staged"
+	modeTry      = "try"
 )
 
 // AddModeFlags adds deprecated flags to the command and registers mode flag with it's parser.
@@ -92,10 +78,6 @@ func AddModeFlags(mode *Mode, command *cobra.Command) {
 		modeTry:      machine.ApplyConfigurationRequest_TRY,
 	}
 
-	if command.Use == "apply-config" {
-		modes[modeInteractive] = InteractiveMode
-	}
-
 	mode.Mode = machine.ApplyConfigurationRequest_AUTO
 	mode.options = modes
 

cmd/talosctl/pkg/talos/helpers/mode.go

@@ -77,6 +77,15 @@ Users verifying reproducible images should use raw images, verify checksums, and
         title = "VM Hot-Add Support"
         description = """\
 Talos now includes udev rules to support hot-adding of CPUs in virtualized environments.
+"""
+
+    [notest.interactive-installer]
+        title = "Interactive Installer Removal"
+        description = """\
+The interactive installer mode has been removed from `talosctl apply-config` (`--mode=interactive`).
+It has been deprecated since Talos v1.12.0, and now fully removed.
+The related `GenerateConfiguration` API method has also been removed.
+Users are encouraged to use other installation methods, such as using pre-generated configuration files, or using Omni.
 """
 
 [make_deps]

hack/release.toml

@@ -57,7 +57,6 @@ import (
 	"github.com/siderolabs/talos/internal/app/machined/pkg/system"
 	"github.com/siderolabs/talos/internal/app/resources"
 	storaged "github.com/siderolabs/talos/internal/app/storaged"
-	"github.com/siderolabs/talos/internal/pkg/configuration"
 	"github.com/siderolabs/talos/internal/pkg/containers"
 	taloscontainerd "github.com/siderolabs/talos/internal/pkg/containers/containerd"
 	"github.com/siderolabs/talos/internal/pkg/containers/cri"
@@ -330,15 +329,6 @@ func generateDiff(r runtime.Runtime, provider config.Provider) (string, error) {
 	return "Config diff:\n\n" + documentsDiff, nil
 }
 
-// GenerateConfiguration implements the machine.MachineServer interface.
-func (s *Server) GenerateConfiguration(ctx context.Context, in *machine.GenerateConfigurationRequest) (reply *machine.GenerateConfigurationResponse, err error) {
-	if s.Controller.Runtime().Config().Machine().Type() == machinetype.TypeWorker {
-		return nil, errors.New("config can't be generated on worker nodes")
-	}
-
-	return configuration.Generate(ctx, s.Controller.Runtime().State().V1Alpha2().Resources(), in)
-}
-
 // Reboot implements the machine.MachineServer interface.
 func (s *Server) Reboot(ctx context.Context, in *machine.RebootRequest) (reply *machine.RebootResponse, err error) {
 	actorID := uuid.New().String()

internal/app/machined/internal/server/v1alpha1/v1alpha1_server.go

@@ -62,7 +62,6 @@ var rules = map[string]role.Set{
 	"/machine.MachineService/EtcdDowngradeValidate":       role.MakeSet(role.Admin),
 	"/machine.MachineService/Events":                      role.MakeSet(role.Admin, role.Operator, role.Reader),
 	"/machine.MachineService/GenerateClientConfiguration": role.MakeSet(role.Admin),
-	"/machine.MachineService/GenerateConfiguration":       role.MakeSet(role.Admin),
 	"/machine.MachineService/Hostname":                    role.MakeSet(role.Admin, role.Operator, role.Reader),
 	"/machine.MachineService/ImageList":                   role.MakeSet(role.Admin, role.Operator, role.Reader),
 	"/machine.MachineService/ImagePull":                   role.MakeSet(role.Admin, role.Operator),

internal/app/machined/pkg/system/services/machined.go

@@ -26,13 +26,11 @@ import (
 	"github.com/siderolabs/talos/internal/app/machined/pkg/runtime"
 	"github.com/siderolabs/talos/internal/app/resources"
 	storaged "github.com/siderolabs/talos/internal/app/storaged"
-	"github.com/siderolabs/talos/internal/pkg/configuration"
 	"github.com/siderolabs/talos/pkg/grpc/middleware/authz"
 	"github.com/siderolabs/talos/pkg/machinery/api/machine"
 	"github.com/siderolabs/talos/pkg/machinery/api/storage"
 	"github.com/siderolabs/talos/pkg/machinery/config"
 	"github.com/siderolabs/talos/pkg/machinery/config/configloader"
-	v1alpha1machine "github.com/siderolabs/talos/pkg/machinery/config/machine"
 	blockres "github.com/siderolabs/talos/pkg/machinery/resources/block"
 	"github.com/siderolabs/talos/pkg/machinery/role"
 	"github.com/siderolabs/talos/pkg/machinery/version"
@@ -133,25 +131,6 @@ Node is running in maintenance mode and does not have a config yet.`
 	return reply, nil
 }
 
-// GenerateConfiguration implements the [machine.MachineServiceServer] interface.
-func (s *Server) GenerateConfiguration(ctx context.Context, in *machine.GenerateConfigurationRequest) (*machine.GenerateConfigurationResponse, error) {
-	if s.mode.IsAgent() {
-		return nil, status.Error(codes.Unimplemented, "API is not implemented in agent mode")
-	}
-
-	if in.MachineConfig == nil {
-		return nil, errors.New("invalid generate request")
-	}
-
-	machineType := v1alpha1machine.Type(in.MachineConfig.Type)
-
-	if machineType == v1alpha1machine.TypeWorker {
-		return nil, errors.New("join config can't be generated in the maintenance mode")
-	}
-
-	return configuration.Generate(ctx, s.controller.Runtime().State().V1Alpha2().Resources(), in)
-}
-
 // GenerateClientConfiguration implements the [machine.MachineServiceServer] interface.
 func (s *Server) GenerateClientConfiguration(context.Context, *machine.GenerateClientConfigurationRequest) (*machine.GenerateClientConfigurationResponse, error) {
 	return nil, status.Error(codes.Unimplemented, "client configuration (talosconfig) can't be generated in the maintenance mode")