Support Java 8

Same language level as OpenFeature SDK

Author: sideshowcoder

pom.xml

@@ -15,7 +15,8 @@
     <description>OpenFeature bundle for Dropwizard</description>
 
     <properties>
-        <java.version>21</java.version>
+        <!-- Support Java 8 as the same language level supported by the Openfeature SDK -->
+        <java.version>8</java.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <dropwizard.version>4.0.13</dropwizard.version>

src/main/java/io/github/sideshowcoder/dropwizard_openfeature/FlagdConfiguration.java

@@ -65,7 +65,7 @@ public class FlagdConfiguration {
     private int offlinePollIntervalMs;
 
     public FlagdOptions getFlagdOptions() {
-        var builder = FlagdOptions.builder();
+        FlagdOptions.FlagdOptionsBuilder builder = FlagdOptions.builder();
         if (resolver != null) {
             builder.resolverType(Config.Resolver.valueOf(resolver.toUpperCase()));
         }

src/main/java/io/github/sideshowcoder/dropwizard_openfeature/OpenFeatureBundle.java

@@ -1,29 +1,30 @@
 package io.github.sideshowcoder.dropwizard_openfeature;
 
 import dev.openfeature.contrib.providers.flagd.FlagdProvider;
+import dev.openfeature.sdk.Client;
 import dev.openfeature.sdk.FeatureProvider;
 import dev.openfeature.sdk.OpenFeatureAPI;
 import dev.openfeature.sdk.providers.memory.InMemoryProvider;
 import io.dropwizard.core.ConfiguredBundle;
 import io.dropwizard.core.setup.Environment;
 import io.github.sideshowcoder.dropwizard_openfeature.health.OpenFeatureHealthCheck;
 
-import java.util.Map;
+import java.util.HashMap;
 
 public class OpenFeatureBundle implements ConfiguredBundle<OpenFeatureBundleConfiguration> {
 
     private FeatureProvider featureProvider;
 
     @Override
     public void run(OpenFeatureBundleConfiguration configuration, Environment environment) {
-        var config = configuration.getOpenFeatureConfiguration();
+        OpenFeatureConfiguration config = configuration.getOpenFeatureConfiguration();
         initializeFeatureProvider(config);
-        var manager = new OpenFeatureAPIManager(getFeatureProvider());
+        OpenFeatureAPIManager manager = new OpenFeatureAPIManager(getFeatureProvider());
         environment.lifecycle().manage(manager);
 
         if (config.getHealthcheck().isEnabled()) {
-            var client = OpenFeatureAPI.getInstance().getClient(config.getHealthcheck().getClientDomain());
-            var healthcheck = new OpenFeatureHealthCheck(client);
+            Client client = OpenFeatureAPI.getInstance().getClient(config.getHealthcheck().getClientDomain());
+            OpenFeatureHealthCheck healthcheck = new OpenFeatureHealthCheck(client);
             environment.healthChecks().register(config.getHealthcheck().getName(), healthcheck);
         }
     }
@@ -36,9 +37,13 @@ public FeatureProvider getFeatureProvider() {
     }
 
     private synchronized void initializeFeatureProvider(OpenFeatureConfiguration config) {
-        featureProvider = switch (config.getProviderType()) {
-            case FLAGD -> new FlagdProvider(config.getFlagd().getFlagdOptions());
-            case INMEMORY -> new InMemoryProvider(Map.of());
-        };
+        switch (config.getProviderType()) {
+            case INMEMORY:
+                featureProvider = new InMemoryProvider(new HashMap<>());
+                break;
+            case FLAGD:
+                featureProvider = new FlagdProvider(config.getFlagd().getFlagdOptions());
+                break;
+        }
     }
 }

src/test/java/io/github/sideshowcoder/dropwizard_openfeature/FlagdConfigurationTest.java

@@ -22,7 +22,7 @@ public class FlagdConfigurationTest {
 
     @Test
     public void providesFlagdOptions() throws Exception {
-        var configuration = factory.build(new ResourceConfigurationSourceProvider(), "basic-flagd-config.yml");
+        FlagdConfiguration configuration = factory.build(new ResourceConfigurationSourceProvider(), "basic-flagd-config.yml");
         assertEquals("flagd", configuration.getFlagdOptions().getHost());
         assertEquals(8082, configuration.getFlagdOptions().getPort());
         assertEquals(Config.Resolver.RPC, configuration.getFlagdOptions().getResolverType());

src/test/java/io/github/sideshowcoder/dropwizard_openfeature/OpenFeatureBundleFlagdProviderTest.java

@@ -1,5 +1,7 @@
 package io.github.sideshowcoder.dropwizard_openfeature;
 
+import com.codahale.metrics.health.HealthCheck;
+import dev.openfeature.sdk.Client;
 import dev.openfeature.sdk.OpenFeatureAPI;
 import io.dropwizard.testing.ResourceHelpers;
 import io.dropwizard.testing.junit5.DropwizardAppExtension;
@@ -21,14 +23,14 @@ public class OpenFeatureBundleFlagdProviderTest {
 
     @Test
     public void initializesHealthCheck() throws Exception {
-        var healthcheckResult = APP.getEnvironment().healthChecks().runHealthCheck("openfeature-health-check");
+        HealthCheck.Result healthcheckResult = APP.getEnvironment().healthChecks().runHealthCheck("openfeature-health-check");
         assertTrue(healthcheckResult.isHealthy());
     }
 
     @Test
     public void providesFeatureFlagsViaInMemoryProvider() throws Exception {
         // See flagd-test-flags.json for flag definitions used!
-        var client = OpenFeatureAPI.getInstance().getClient("flagd-client");
+        Client client = OpenFeatureAPI.getInstance().getClient("flagd-client");
         assertEquals("red", client.getStringValue("static-string-flag", "not-expected-value"));
     }
 

src/test/java/io/github/sideshowcoder/dropwizard_openfeature/OpenFeatureBundleInMemoryProviderTest.java

@@ -1,5 +1,7 @@
 package io.github.sideshowcoder.dropwizard_openfeature;
 
+import com.codahale.metrics.health.HealthCheck;
+import dev.openfeature.sdk.Client;
 import dev.openfeature.sdk.OpenFeatureAPI;
 import dev.openfeature.sdk.providers.memory.Flag;
 import dev.openfeature.sdk.providers.memory.InMemoryProvider;
@@ -11,6 +13,7 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 
+import java.util.HashMap;
 import java.util.Map;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -25,23 +28,25 @@ public class OpenFeatureBundleInMemoryProviderTest {
 
     @Test
     public void initializesHealthCheck() throws Exception {
-        var healthcheckResult = APP.getEnvironment().healthChecks().runHealthCheck("openfeature-health-check");
+        HealthCheck.Result healthcheckResult = APP.getEnvironment().healthChecks().runHealthCheck("openfeature-health-check");
         assertTrue(healthcheckResult.isHealthy());
     }
 
     @Test
     public void providesFeatureFlagsViaInMemoryProvider() throws Exception {
-        var expectedValue = "expected-value";
-        var flagKey = "flag-key";
-        var flag = Flag.builder().variant("variant-key", expectedValue).defaultVariant("variant-key").build();
-        var flags = Map.<String, Flag<?>>of(flagKey, flag);
+        String expectedValue = "expected-value";
+
+        String flagKey = "flag-key";
+        Flag<Object> flag = Flag.builder().variant("variant-key", expectedValue).defaultVariant("variant-key").build();
+        Map<String, Flag<?>> flags = new HashMap<>();
+        flags.put(flagKey, flag);
 
         // set the in memory flags
-        var bundle = ((App) APP.getApplication()).getOpenFeatureBundle();
-        var provider = (InMemoryProvider) bundle.getFeatureProvider();
+        OpenFeatureBundle bundle = ((App) APP.getApplication()).getOpenFeatureBundle();
+        InMemoryProvider provider = (InMemoryProvider) bundle.getFeatureProvider();
         provider.updateFlags(flags);
 
-        var client = OpenFeatureAPI.getInstance().getClient("in-memory-provider-client");
+        Client client = OpenFeatureAPI.getInstance().getClient("in-memory-provider-client");
         assertEquals(expectedValue, client.getStringValue(flagKey, "not-expected-value"));
     }
 }

src/test/java/io/github/sideshowcoder/dropwizard_openfeature/health/OpenFeatureHealthCheckTest.java

@@ -1,5 +1,6 @@
 package io.github.sideshowcoder.dropwizard_openfeature.health;
 
+import com.codahale.metrics.health.HealthCheck;
 import dev.openfeature.sdk.Client;
 import dev.openfeature.sdk.ClientMetadata;
 import dev.openfeature.sdk.ProviderState;
@@ -41,7 +42,7 @@ public void testProviderUnhealthy() throws Exception {
         when(client.getMetadata()).thenReturn(metadata);
         when(metadata.getDomain()).thenReturn("domain");
 
-        var result = healthCheck.check();
+        HealthCheck.Result result = healthCheck.check();
 
         assertFalse(result.isHealthy());
     }