feat: add Flatpak setup dialog and enhance permissions handling; update version to 1.4.4

Author: sidevesh

.gitmodules

@@ -5,3 +5,6 @@
 [submodule "arch"]
 	path = arch
 	url = https://aur.archlinux.org/luminance.git
+[submodule "flathub"]
+	path = flathub
+	url = git@github.com:flathub/com.sidevesh.Luminance.git

Makefile

@@ -1,4 +1,4 @@
-.PHONY: all release debug install uninstall install-debug uninstall-debug clean package-deb package-rpm package-arch package-arch-test install-arch uninstall-arch flatpak install-flatpak uninstall-flatpak lint-flatpak run-flatpak flatpak-bundle pack-gnome-extension install-gnome-extension uninstall-gnome-extension
+.PHONY: all release debug install uninstall install-debug uninstall-debug package-deb package-rpm package-arch package-arch-test install-arch uninstall-arch flatpak flatpak-bundle install-flatpak uninstall-flatpak run-flatpak package-flatpak-flathub lint-flatpak-flathub package-gnome-extension install-gnome-extension uninstall-gnome-extension clean
 
 # Build directories
 BUILD_RELEASE_DIR = build/release
@@ -13,7 +13,7 @@ RPMBUILD_DIR = $(RPM_DIR)/rpmbuild
 OUTPUTS_DIR = $(PKG_DIR)/outputs
 FLATPAK_DIR = $(PKG_DIR)/flatpak
 FLATPAK_REPO_DIR = $(FLATPAK_DIR)/repo
-FLATPAK_MANIFEST = $(CURDIR)/packaging/flatpak/com.sidevesh.Luminance.yml
+FLATPAK_MANIFEST_IN = $(CURDIR)/packaging/flatpak/com.sidevesh.Luminance.yml.in
 FLATPAK_APP_ID = com.sidevesh.Luminance
 
 VERSION = $(shell cat version.txt)
@@ -124,12 +124,13 @@ uninstall-arch:
 	@echo "Uninstalling Arch package..."
 	sudo pacman -R luminance
 
-flatpak:
+flatpak: $(FLATPAK_MANIFEST_IN)
 	@echo "Building Flatpak..."
 	mkdir -p $(FLATPAK_DIR)
-	# Copy manifest to build directory to satisfy flatpak-builder output requirements
-	# This is necessary because flatpak-builder forbids 'path' from pointing outside the manifest directory
-	cp $(FLATPAK_MANIFEST) $(CURDIR)/.flatpak-manifest.yml
+	# Generate manifest for local build directly to .flatpak-manifest.yml
+	sed -e "s|@LUMINANCE_SOURCE_TYPE@|dir|g" \
+	    -e "s|@LUMINANCE_SOURCE_DETAILS@|path: $(CURDIR)|g" \
+	    $(FLATPAK_MANIFEST_IN) > $(CURDIR)/.flatpak-manifest.yml
 
 	# Run flathub-build from root. This creates 'repo' and 'builddir' in $(CURDIR)
 	flatpak run --filesystem=$(CURDIR) --command=flathub-build org.flatpak.Builder --force-clean $(CURDIR)/.flatpak-manifest.yml
@@ -140,6 +141,12 @@ flatpak:
 	mv builddir $(FLATPAK_DIR)/
 	rm $(CURDIR)/.flatpak-manifest.yml
 
+flatpak-bundle: flatpak
+	@echo "Creating Flatpak bundle..."
+	mkdir -p $(OUTPUTS_DIR)
+	flatpak build-bundle $(FLATPAK_REPO_DIR) $(OUTPUTS_DIR)/$(FLATPAK_APP_ID).flatpak $(FLATPAK_APP_ID)
+	@echo "Flatpak bundle created at $(OUTPUTS_DIR)/$(FLATPAK_APP_ID).flatpak"
+
 install-flatpak: flatpak
 	@echo "Installing Flatpak..."
 	flatpak remote-add --user --if-not-exists --no-gpg-verify luminance-local-repo $(CURDIR)/$(FLATPAK_REPO_DIR)
@@ -150,38 +157,28 @@ uninstall-flatpak:
 	-flatpak uninstall --user -y $(FLATPAK_APP_ID)
 	-flatpak remote-delete --user luminance-local-repo
 
-lint-flatpak: flatpak
-	@echo "Linting Flatpak manifest..."
-	# Lint the original manifest
-	-flatpak run --filesystem=$(CURDIR) --command=flatpak-builder-lint org.flatpak.Builder manifest $(FLATPAK_MANIFEST)
-	@echo "Linting Flatpak repo..."
-	@if [ -d "$(FLATPAK_REPO_DIR)" ]; then \
-		flatpak run --filesystem=$(CURDIR) --command=flatpak-builder-lint org.flatpak.Builder repo $(CURDIR)/$(FLATPAK_REPO_DIR); \
-	else \
-		echo "Repo directory not found. Skipping repo linting (run 'make flatpak-build' first)."; \
-	fi
-
 run-flatpak: install-flatpak
 	@echo "Running Flatpak with GDB..."
 	flatpak run --devel --command=sh $(FLATPAK_APP_ID) -c "gdb -batch -ex run -ex \"bt full\" --args /app/bin/$(FLATPAK_APP_ID)"
 
-flatpak-bundle: flatpak
-	@echo "Creating Flatpak bundle..."
-	mkdir -p $(OUTPUTS_DIR)
-	flatpak build-bundle $(FLATPAK_REPO_DIR) $(OUTPUTS_DIR)/$(FLATPAK_APP_ID).flatpak $(FLATPAK_APP_ID)
-	@echo "Flatpak bundle created at $(OUTPUTS_DIR)/$(FLATPAK_APP_ID).flatpak"
+package-flatpak-flathub: $(FLATPAK_MANIFEST_IN) version.txt
+	@echo "Updating flathub manifest..."
+	sed -e "s|@LUMINANCE_SOURCE_TYPE@|git|g" \
+	    -e "s|@LUMINANCE_SOURCE_DETAILS@|url: https://github.com/sidevesh/Luminance.git\n        tag: $(VERSION)|g" \
+	    $(FLATPAK_MANIFEST_IN) > flathub/com.sidevesh.Luminance.yml
 
-# Remove build directories
-clean:
-	rm -rf build
+lint-flatpak-flathub: package-flatpak-flathub
+	@echo "Linting Flatpak manifest..."
+	# Lint the manifest generated for flathub
+	-flatpak run --filesystem=$(CURDIR) --command=flatpak-builder-lint org.flatpak.Builder manifest flathub/com.sidevesh.Luminance.yml
 
 # GNOME Extension
 EXTENSION_UUID = luminance-extension@sidevesh
 SRC_EXTENSION_DIR = gnome-extension/$(EXTENSION_UUID)
 EXTENSION_BUILD_DIR = $(PKG_DIR)/gnome-extension
 EXTENSION_ZIP = $(OUTPUTS_DIR)/$(EXTENSION_UUID).shell-extension.zip
 
-pack-gnome-extension:
+package-gnome-extension:
 	@echo "Packing GNOME extension..."
 	rm -rf $(EXTENSION_BUILD_DIR)
 	mkdir -p $(EXTENSION_BUILD_DIR)
@@ -190,7 +187,7 @@ pack-gnome-extension:
 	gnome-extensions pack $(EXTENSION_BUILD_DIR) --force --out-dir=$(OUTPUTS_DIR)
 	@echo "Extension packed at $(EXTENSION_ZIP)"
 
-install-gnome-extension: pack-gnome-extension
+install-gnome-extension: package-gnome-extension
 	@echo "Installing GNOME extension..."
 	gnome-extensions install --force $(EXTENSION_ZIP)
 	@echo "GNOME extension installed. You may need to enable it with: gnome-extensions enable $(EXTENSION_UUID)"
@@ -200,3 +197,6 @@ uninstall-gnome-extension:
 	@echo "Uninstalling GNOME extension..."
 	-gnome-extensions uninstall $(EXTENSION_UUID)
 	@echo "Extension uninstalled."
+
+clean:
+	rm -rf build

arch

@@ -26,6 +26,10 @@
         <image type="source">https://raw.githubusercontent.com/sidevesh/Luminance/main/screenshots/screenshot.dark.png</image>
       </screenshot>
   </screenshots>
+  <branding>
+    <color type="primary" scheme_preference="light">#70b0ff</color>
+    <color type="primary" scheme_preference="dark">#144785</color>
+  </branding>
   <releases>
 @RELEASES@
   </releases>

flathub

@@ -7,6 +7,7 @@ finish-args:
   - --socket=fallback-x11
   - --socket=wayland
   - --device=all
+  - --filesystem=/sys
   - --system-talk-name=org.freedesktop.UPower
   - --share=ipc
 modules:
@@ -36,5 +37,5 @@ modules:
       - --buildtype=release
       - -Dinstall_udev_rules=false
     sources:
-      - type: dir
-        path: .
+      - type: @LUMINANCE_SOURCE_TYPE@
+        @LUMINANCE_SOURCE_DETAILS@

install_files/com.sidevesh.Luminance.metainfo.xml.in

@@ -1,3 +1,4 @@
+<release version="1.4.4" date="2026-02-16"/>
 <release version="1.4.3" date="2026-02-13"/>
 <release version="1.4.2" date="2026-02-03"/>
 <release version="1.4.1" date="2026-02-03"/>

…aging/flatpak/com.sidevesh.Luminance.yml …ng/flatpak/com.sidevesh.Luminance.yml.inpackaging/flatpak/com.sidevesh.Luminance.yml renamed to packaging/flatpak/com.sidevesh.Luminance.yml.in packaging/flatpak/com.sidevesh.Luminance.yml renamed to packaging/flatpak/com.sidevesh.Luminance.yml.in

@@ -77,6 +77,17 @@ verify() {
         BACKLIGHT_COUNT=$(ls /sys/class/backlight/ | wc -l)
         if [ "$BACKLIGHT_COUNT" -gt 0 ]; then
             echo -e "[${GREEN}OK${NC}] Found $BACKLIGHT_COUNT backlight interfaces in /sys/class/backlight/"
+            
+            # Check for actual write permissions
+            CAN_WRITE=0
+            for backlight in /sys/class/backlight/*; do
+                if [ -w "$backlight/brightness" ]; then
+                    echo -e "[${GREEN}OK${NC}] Write permission available for $(basename "$backlight")"
+                    CAN_WRITE=1
+                else
+                    echo -e "[${RED}FAIL${NC}] No write permission for $(basename "$backlight")/brightness. (Current user: $(whoami))"
+                fi
+            done
         else
             echo -e "[${YELLOW}INFO${NC}] No internal backlight interfaces found (normal for desktops)"
         fi
@@ -89,15 +100,40 @@ verify() {
     exit 0
 }
 
-# Check for uninstall flag
-if [ "$1" == "--uninstall" ]; then
-    uninstall
-fi
+# Function to show help
+show_help() {
+    echo "Usage: $(basename "$0") [OPTION]"
+    echo "Setup permissions for Luminance Flatpak to control monitors."
+    echo ""
+    echo "Options:"
+    echo "  --verify     Verify the installation and permissions"
+    echo "  --uninstall  Uninstall the setup and revert changes"
+    echo "  --help       Show this help message"
+    echo ""
+    echo "If no option is provided, the setup will be performed."
+    exit 0
+}
 
-# Check for verify flag
-if [ "$1" == "--verify" ]; then
-    verify
-fi
+# Parse arguments
+case "$1" in
+    --uninstall)
+        uninstall
+        ;;
+    --verify)
+        verify
+        ;;
+    --help|-h)
+        show_help
+        ;;
+    "")
+        # Proceed with setup
+        ;;
+    *)
+        echo "Error: Unknown option '$1'"
+        echo "Try '$(basename "$0") --help' for more information."
+        exit 1
+        ;;
+esac
 
 echo "Starting setup for Luminance..."
 
@@ -155,6 +191,15 @@ if [ "$STEAMOS" = 1 ] ; then
 	fi
 fi
 
+# Check if user is in video group
+if groups "$USER" | grep &>/dev/null '\bvideo\b'; then
+    echo "User $USER is already in the video group."
+else
+    echo "Adding user $USER to the video group..."
+    sudo usermod -aG video "$USER"
+    echo "PLEASE NOTE: You may need to log out and log back in for group changes to take effect."
+fi
+
 echo "Setup complete!"
 echo "To verify the installation, run this script with the --verify flag."
 echo "./flatpak-setup.sh --verify"

releases.xml

@@ -219,10 +219,10 @@ char* get_display_name(guint index) {
   GlobalDisplayIndex display_index = _display_indexes[index];
   if (display_index.type == DISPLAY_TYPE_INTERNAL_BACKLIGHT) {
 		if (_internal_backlight_display_directories_count == 1) {
-			return "Built-in display";
+			return "Built-in Display";
 		}
 		gchar *display_name = malloc(256);
-		snprintf(display_name, 256, "Built-in display %d", display_index.index + 1);
+		snprintf(display_name, 256, "Built-in Display %d", display_index.index + 1);
 		return display_name;
   } else {
     ddcbc_display* display = _get_ddcbc_display(index);
@@ -286,7 +286,7 @@ void set_display_brightness_percentage(guint index, gdouble brightness_percentag
   if (emit_osd_signal) {
     gchar model_name[256];
     if (display_index.type == DISPLAY_TYPE_INTERNAL_BACKLIGHT) {
-      snprintf(model_name, sizeof(model_name), "Built-in display");
+      snprintf(model_name, sizeof(model_name), "Built-in Display");
     } else {
       ddcbc_display* display = _get_ddcbc_display(index);
       if (display)
@@ -298,4 +298,24 @@ void set_display_brightness_percentage(guint index, gdouble brightness_percentag
   }
 }
 
+gboolean have_internal_displays_without_permission_in_flatpak() {
+  if (is_running_in_flatpak() == FALSE) {
+    return FALSE;
+  }
+  
+  if (_internal_backlight_display_directories_count == 0) {
+    return FALSE;
+  }
+
+  for (guint i = 0; i < _internal_backlight_display_directories_count; i++) {
+    gchar brightness_file_path[256];
+    snprintf(brightness_file_path, sizeof(brightness_file_path), "/sys/class/backlight/%s/brightness", _internal_backlight_display_directories[i]);
+    if (access(brightness_file_path, W_OK) != 0) {
+      return TRUE;
+    }
+  }
+
+  return FALSE;
+}
+
 #endif

scripts/flatpak-setup.sh

@@ -0,0 +1,90 @@
+#ifndef UI_COMPONENTS_FLATPAK_SETUP_DIALOG_C
+#define UI_COMPONENTS_FLATPAK_SETUP_DIALOG_C
+
+#include <gtk/gtk.h>
+#include <adwaita.h>
+#include "../../constants/main.c"
+
+void show_flatpak_setup_dialog(GtkWindow *parent_window) {
+    GtkWidget *dialog;
+    GtkWidget *main_box;
+    GtkWidget *header;
+    GtkWidget *content_box;
+    GtkWidget *intro_label;
+    GtkWidget *step1_label;
+    GtkWidget *link_button;
+    GtkWidget *step2_label;
+    GtkWidget *step3_label;
+    GtkWidget *command_label;
+    GtkCssProvider *css_provider;
+    
+    dialog = gtk_window_new();
+    gtk_window_set_modal(GTK_WINDOW(dialog), TRUE);
+    if (parent_window) {
+        gtk_window_set_transient_for(GTK_WINDOW(dialog), parent_window);
+    }
+    gtk_window_set_title(GTK_WINDOW(dialog), "Flatpak Setup");
+    gtk_window_set_resizable(GTK_WINDOW(dialog), FALSE);
+    gtk_window_set_default_size(GTK_WINDOW(dialog), 450, -1);
+
+    main_box = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
+    gtk_window_set_child(GTK_WINDOW(dialog), main_box);
+
+    header = adw_header_bar_new();
+    gtk_widget_add_css_class(header, "flat");
+    gtk_window_set_titlebar(GTK_WINDOW(dialog), header);
+
+    // CSS for the command well
+    css_provider = gtk_css_provider_new();
+    gtk_css_provider_load_from_string(css_provider,
+        ".command-well { background-color: alpha(currentColor, 0.08); border-radius: 6px; padding: 6px 12px; }");
+    gtk_style_context_add_provider_for_display(gdk_display_get_default(),
+                                               GTK_STYLE_PROVIDER(css_provider),
+                                               GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
+
+    content_box = gtk_box_new(GTK_ORIENTATION_VERTICAL, 12);
+    gtk_widget_set_margin_top(content_box, 24);
+    gtk_widget_set_margin_bottom(content_box, 24);
+    gtk_widget_set_margin_start(content_box, 24);
+    gtk_widget_set_margin_end(content_box, 24);
+    gtk_box_append(GTK_BOX(main_box), content_box);
+    
+    // Intro
+    intro_label = gtk_label_new("To control monitors from a Flatpak app, you need to grant permissions on your host system.");
+    gtk_label_set_wrap(GTK_LABEL(intro_label), TRUE);
+    gtk_label_set_xalign(GTK_LABEL(intro_label), 0);
+    gtk_box_append(GTK_BOX(content_box), intro_label);
+
+    // Step 1
+    step1_label = gtk_label_new(NULL);
+    gtk_label_set_markup(GTK_LABEL(step1_label), "<b>1.</b> Download the setup script below:");
+    gtk_label_set_xalign(GTK_LABEL(step1_label), 0);
+    gtk_box_append(GTK_BOX(content_box), step1_label);
+
+    link_button = gtk_link_button_new_with_label(APP_INFO_FLATPAK_SETUP_SCRIPT_URL, "Download Setup Script");
+    gtk_widget_set_halign(link_button, GTK_ALIGN_START);
+    gtk_box_append(GTK_BOX(content_box), link_button);
+
+    // Step 2
+    step2_label = gtk_label_new(NULL);
+    gtk_label_set_markup(GTK_LABEL(step2_label), "<b>2.</b> Allow the file to be executed (Properties > Permissions > Allow executing file as program).");
+    gtk_label_set_wrap(GTK_LABEL(step2_label), TRUE);
+    gtk_label_set_xalign(GTK_LABEL(step2_label), 0);
+    gtk_box_append(GTK_BOX(content_box), step2_label);
+
+    // Step 3
+    step3_label = gtk_label_new(NULL);
+    gtk_label_set_markup(GTK_LABEL(step3_label), "<b>3.</b> Run the script (double-click or run from terminal).");
+    gtk_label_set_wrap(GTK_LABEL(step3_label), TRUE);
+    gtk_label_set_xalign(GTK_LABEL(step3_label), 0);
+    gtk_box_append(GTK_BOX(content_box), step3_label);
+
+    command_label = gtk_label_new(NULL);
+    gtk_label_set_markup(GTK_LABEL(command_label), "<b>4.</b> Restart this app for changes to take effect.");
+    gtk_label_set_xalign(GTK_LABEL(command_label), 0);
+    gtk_box_append(GTK_BOX(content_box), command_label);
+    
+    gtk_window_present(GTK_WINDOW(dialog));
+}
+
+#endif