throw error for invalid data type

Author: sidhant92

src/main/java/com/github/sidhant92/boolparser/constant/ContainerDataType.java

@@ -2,20 +2,28 @@
 
 import java.util.Optional;
 import com.github.sidhant92.boolparser.datatype.DataTypeFactory;
+import com.github.sidhant92.boolparser.exception.InvalidDataType;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
 
 /**
  * @author sidhant.aggarwal
  * @since 05/02/2023
  */
 @Getter
 @AllArgsConstructor
+@Slf4j
 public enum ContainerDataType {
     primitive() {
         @Override
         public <T> Optional<T> getValue(final DataType dataType, final Object value) {
-            return DataTypeFactory.getDataType(dataType).getValue(value);
+            final Optional<T> result = DataTypeFactory.getDataType(dataType).getValue(value);
+            if (!result.isPresent()) {
+                log.error("Invalid data type for value {} for data type {}", value.toString(), dataType.name());
+                throw new InvalidDataType(String.format("Invalid data type for value %s for data type %s", value, dataType.name()));
+            }
+            return result;
         }
 
         @Override

src/main/java/com/github/sidhant92/boolparser/exception/InvalidDataType.java

@@ -0,0 +1,16 @@
+package com.github.sidhant92.boolparser.exception;
+
+public class InvalidDataType extends RuntimeException {
+    public InvalidDataType(final String message) {
+        super(message);
+    }
+
+    public InvalidDataType() {
+        super();
+    }
+
+    @Override
+    public String getMessage() {
+        return "Invalid Data Type";
+    }
+}

src/main/java/com/github/sidhant92/boolparser/operator/AbstractOperator.java

@@ -15,6 +15,4 @@ public abstract <T extends Comparable<? super T>> boolean evaluate(final Contain
     public abstract Operator getOperator();
 
     public abstract String getSymbol();
-
-    //public boolean validate(final ContainerDataType containerDataType, final DataType dataType, final Object leftOperand)
 }

src/test/java/com/github/sidhant92/boolparser/application/BooleanExpressionEvaluatorTest.java

@@ -5,6 +5,7 @@
 import java.util.HashMap;
 import java.util.Map;
 import org.junit.jupiter.api.Test;
+import com.github.sidhant92.boolparser.exception.InvalidDataType;
 import com.github.sidhant92.boolparser.exception.InvalidUnaryOperand;
 import com.github.sidhant92.boolparser.parser.antlr.BoolParser;
 import io.vavr.control.Try;
@@ -62,6 +63,15 @@ public void testSimpleTrueCorrectExpressions() {
         assertTrue(booleanOptional.get());
     }
 
+    @Test
+    public void testInvalidDataType() {
+        final Map<String, Object> data = new HashMap<>();
+        data.put("name", "abc-");
+        final Try<Boolean> booleanOptional = booleanExpressionEvaluator.evaluate("name > 123", data);
+        assertTrue(booleanOptional.isFailure());
+        assertTrue(booleanOptional.getCause() instanceof InvalidDataType);
+    }
+
     @Test
     public void testSimpleFalseIncorrectExpression() {
         final Map<String, Object> data = new HashMap<>();
@@ -311,8 +321,8 @@ public void testWrongDataType1() {
         final Map<String, Object> data = new HashMap<>();
         data.put("age", "sf");
         final Try<Boolean> booleanOptional = booleanExpressionEvaluator.evaluate("age = 24", data);
-        assertTrue(booleanOptional.isSuccess());
-        assertFalse(booleanOptional.get());
+        assertTrue(booleanOptional.isFailure());
+        assertTrue(booleanOptional.getCause() instanceof InvalidDataType);
     }
 
     @Test

src/test/java/com/github/sidhant92/boolparser/parser/antlr/benchmark/ParserBenchmarkService.java

@@ -47,7 +47,7 @@ public void setup() {
     @Warmup (iterations = 2)
     @BenchmarkMode (Mode.SampleTime) //change here to check for specific mode
     public void benchmarkEvaluation() {
-        final String rule = "b>0";
+        final String rule = "b>0 AND z IN ('c1', 'c2')";
         parser.parseExpression(rule);
     }
 }